Add binary conformance test for enum fields. (#6434)

* Add binary conformance test for enum fields.

* Add failed conformance test to js failure list
pull/6436/head
Paul Yang 6 years ago committed by GitHub
parent 2c76c2c413
commit 455440fc47
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
  1. 7
      conformance/binary_json_conformance_suite.cc
  2. 1
      conformance/failure_list_js.txt

@ -804,11 +804,16 @@ void BinaryAndJsonConformanceSuite::RunSuiteImpl() {
{delim("\xfb"), "\"\xfb\""},
{delim(""), "\"\""},
});
TestValidDataForType(FieldDescriptor::TYPE_ENUM, {
{varint(0), "FOO"},
{varint(1), "BAR"},
{varint(2), "BAZ"},
{varint(-1), "NEG"},
});
// TODO(haberman):
// TestValidDataForType(FieldDescriptor::TYPE_GROUP
// TestValidDataForType(FieldDescriptor::TYPE_MESSAGE
// TestValidDataForType(FieldDescriptor::TYPE_ENUM
RunValidJsonTest("HelloWorld", REQUIRED,
"{\"optionalString\":\"Hello, World!\"}",

@ -11,3 +11,4 @@ Required.Proto3.ProtobufInput.ValidDataRepeated.SINT32.ProtobufOutput
Required.Proto3.ProtobufInput.ValidDataRepeated.SINT64.ProtobufOutput
Required.Proto3.ProtobufInput.ValidDataRepeated.UINT32.ProtobufOutput
Required.Proto3.ProtobufInput.ValidDataRepeated.UINT64.ProtobufOutput
Required.Proto3.ProtobufInput.ValidDataRepeated.ENUM.ProtobufOutput

Loading…
Cancel
Save