diff --git a/.github/workflows/test_php.yml b/.github/workflows/test_php.yml index e03ce98fcd..bd89924c45 100644 --- a/.github/workflows/test_php.yml +++ b/.github/workflows/test_php.yml @@ -176,6 +176,13 @@ jobs: composer test; composer test_c' + - name: Run conformance tests + uses: protocolbuffers/protobuf-ci/bazel@v3 + with: + credentials: ${{ secrets.GAR_SERVICE_ACCOUNT }} + bazel-cache: php_linux/${{ matrix.version }} + bazel: test //php:conformance_test //php:conformance_test_c --action_env=PATH --test_env=PATH + macos: strategy: fail-fast: false # Don't cancel all jobs if one fails. @@ -236,4 +243,4 @@ jobs: with: credentials: ${{ secrets.GAR_SERVICE_ACCOUNT }} bazel-cache: php_macos/${{ matrix.version }} - bazel: test //php:conformance_test_c --action_env=PATH --test_env=PATH + bazel: test //php:conformance_test //php:conformance_test_c --action_env=PATH --test_env=PATH diff --git a/php/BUILD.bazel b/php/BUILD.bazel index cc0ba5b174..f373259a4d 100644 --- a/php/BUILD.bazel +++ b/php/BUILD.bazel @@ -65,10 +65,6 @@ conformance_test( name = "conformance_test", failure_list = "//conformance:failure_list_php.txt", maximum_edition = "2023", - target_compatible_with = select({ - "@platforms//os:osx": ["@platforms//:incompatible"], - "//conditions:default": [], - }), testee = "//conformance:conformance_php", text_format_failure_list = "//conformance:text_format_failure_list_php.txt", ) @@ -77,10 +73,6 @@ conformance_test( name = "conformance_test_c", failure_list = "//conformance:failure_list_php_c.txt", maximum_edition = "2023", - target_compatible_with = select({ - "@platforms//os:osx": [], - "//conditions:default": ["@platforms//:incompatible"], - }), testee = "//conformance:conformance_php_c", text_format_failure_list = "//conformance:text_format_failure_list_php.txt", )