Remove TODO and unnecessary branch/store in optimized builds.

PiperOrigin-RevId: 546382890
pull/13242/head
Chris Kennelly 1 year ago committed by Copybara-Service
parent 6bae7c2295
commit 3fec30fe28
  1. 10
      src/google/protobuf/metadata_lite.h

@ -182,11 +182,11 @@ class PROTOBUF_EXPORT InternalMetadata {
template <typename T>
PROTOBUF_NOINLINE void DeleteOutOfLineHelper() {
// TODO(b/188560391): Determine if this branch is needed.
if (!arena()) {
delete PtrValue<Container<T>>();
ptr_ = 0;
}
ABSL_DCHECK(!arena());
delete PtrValue<Container<T>>();
#ifndef NDEBUG
ptr_ = 0;
#endif // NDEBUG
}
template <typename T>

Loading…
Cancel
Save