Review feedback.

- Better error message for unknown messageType.
- Remove unneeded if.
pull/3420/head
Thomas Van Lenten 8 years ago
parent c2831a346c
commit 3caf9fd00a
  1. 4
      conformance/conformance_objc.m

@ -78,16 +78,14 @@ static ConformanceResponse *DoTest(ConformanceRequest *request) {
} else if ([request.messageType isEqual:@"protobuf_test_messages.proto2.TestAllTypesProto2"]) { } else if ([request.messageType isEqual:@"protobuf_test_messages.proto2.TestAllTypesProto2"]) {
msgClass = [TestAllTypesProto2 class]; msgClass = [TestAllTypesProto2 class];
} else { } else {
Die(@"Protobuf request doesn't have specific payload type"); Die(@"Protobuf request had an unknown message_type: %@", request.messageType);
} }
if (msgClass) {
NSError *error = nil; NSError *error = nil;
testMessage = [msgClass parseFromData:request.protobufPayload error:&error]; testMessage = [msgClass parseFromData:request.protobufPayload error:&error];
if (!testMessage) { if (!testMessage) {
response.parseError = response.parseError =
[NSString stringWithFormat:@"Parse error: %@", error]; [NSString stringWithFormat:@"Parse error: %@", error];
} }
}
break; break;
} }

Loading…
Cancel
Save