From 3838f62aa505fcfd106bc19d2160587225805fa8 Mon Sep 17 00:00:00 2001 From: Esun Kim Date: Wed, 31 Jul 2019 17:46:38 -0700 Subject: [PATCH] Fixed ubsan error on memmove --- upb/encode.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/upb/encode.c b/upb/encode.c index 7ec952e6d9..43d24cdbfc 100644 --- a/upb/encode.c +++ b/upb/encode.c @@ -48,7 +48,9 @@ static bool upb_encode_growbuffer(upb_encstate *e, size_t bytes) { CHK(new_buf); /* We want previous data at the end, realloc() put it at the beginning. */ - memmove(new_buf + new_size - old_size, e->buf, old_size); + if (old_size > 0) { + memmove(new_buf + new_size - old_size, e->buf, old_size); + } e->ptr = new_buf + new_size - (e->limit - e->ptr); e->limit = new_buf + new_size;