From 315b93fdccd329a8492e6df8e06c7c305a678a5e Mon Sep 17 00:00:00 2001 From: Chris Fallin Date: Fri, 13 Feb 2015 14:32:09 -0800 Subject: [PATCH] Addressed code-review comment. --- ruby/ext/google/protobuf_c/encode_decode.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/ruby/ext/google/protobuf_c/encode_decode.c b/ruby/ext/google/protobuf_c/encode_decode.c index 256fc829cb..5730504d57 100644 --- a/ruby/ext/google/protobuf_c/encode_decode.c +++ b/ruby/ext/google/protobuf_c/encode_decode.c @@ -208,6 +208,10 @@ typedef struct { size_t ofs; upb_fieldtype_t key_field_type; upb_fieldtype_t value_field_type; + + // We know that we can hold this reference because the handlerdata has the + // same lifetime as the upb_handlers struct, and the upb_handlers struct holds + // a reference to the upb_msgdef, which in turn has references to its subdefs. const upb_def* value_field_subdef; } map_handlerdata_t;