C#: Remove TODO, replacing it with an explanation.

PiperOrigin-RevId: 626125905
pull/16560/head
Protobuf Team Bot 7 months ago committed by Copybara-Service
parent ffd5c1b92b
commit 2be4364e4c
  1. 7
      csharp/src/Google.Protobuf/Reflection/FieldDescriptor.cs

@ -379,7 +379,12 @@ namespace Google.Protobuf.Reflection
IDescriptor typeDescriptor =
File.DescriptorPool.LookupSymbol(Proto.TypeName, this);
// TODO: See how much of this is actually required.
// In most cases, the type will be specified in the descriptor proto. This may be
// guaranteed in descriptor.proto in the future (with respect to spring 2024), but
// we may still see older descriptors created by old versions of protoc, and there
// may be some code creating descriptor protos directly. This code effectively
// maintains backward compatibility, but we don't expect it to be a path taken
// often at all.
if (!Proto.HasType)
{
// Choose field type based on symbol.

Loading…
Cancel
Save