Add binary conformance test case for bytes field (#6428)

* Add binary conformance test case for bytes field * Add failed conformance test to php's failure list
5 years ago · 29e4fadbfb
parent 180d3e3287
commit 29e4fadbfb
2 changed files with 7 additions and 1 deletions
--- a/conformance/binary_json_conformance_suite.cc
+++ b/conformance/binary_json_conformance_suite.cc
@ -799,11 +799,15 @@ void BinaryAndJsonConformanceSuite::RunSuiteImpl() {
    {delim("\xF0\x9F\x98\x81"), "\"\xF0\x9F\x98\x81\""},  // emoji: 😁
    {delim(""), "\"\""},
  });
+  TestValidDataForType(FieldDescriptor::TYPE_BYTES, {
+    {delim("\x01\x02"), "\"\x01\x02\""},
+    {delim("\xfb"), "\"\xfb\""},
+    {delim(""), "\"\""},
+  });

  // TODO(haberman):
  // TestValidDataForType(FieldDescriptor::TYPE_GROUP
  // TestValidDataForType(FieldDescriptor::TYPE_MESSAGE
-  // TestValidDataForType(FieldDescriptor::TYPE_BYTES
  // TestValidDataForType(FieldDescriptor::TYPE_ENUM

  RunValidJsonTest("HelloWorld", REQUIRED,
--- a/conformance/failure_list_php_c.txt
+++ b/conformance/failure_list_php_c.txt
@ -44,3 +44,5 @@ Required.Proto3.ProtobufInput.ValidDataRepeated.FLOAT.JsonOutput
 Required.Proto3.JsonInput.RejectTopLevelNull
 Required.Proto3.ProtobufInput.ValidDataRepeated.STRING.JsonOutput
 Required.Proto3.ProtobufInput.ValidDataRepeated.STRING.ProtobufOutput
+Required.Proto3.ProtobufInput.ValidDataRepeated.BYTES.JsonOutput
+Required.Proto3.ProtobufInput.ValidDataRepeated.BYTES.ProtobufOutput