From 292f9646797d9e23fc66ba70fbda5903f2301ff0 Mon Sep 17 00:00:00 2001 From: Jie Luo Date: Tue, 22 Oct 2024 12:50:05 -0700 Subject: [PATCH] Breaking Change: Remove deprecated reflection methods See https://protobuf.dev/news/2024-10-02/#reflection-methods for detail PiperOrigin-RevId: 688656103 --- python/google/protobuf/reflection.py | 49 ---------------------------- 1 file changed, 49 deletions(-) diff --git a/python/google/protobuf/reflection.py b/python/google/protobuf/reflection.py index 0943c2fe8d..a29f41a052 100644 --- a/python/google/protobuf/reflection.py +++ b/python/google/protobuf/reflection.py @@ -34,52 +34,3 @@ from google.protobuf import symbol_database GeneratedProtocolMessageType = message_factory._GENERATED_PROTOCOL_MESSAGE_TYPE MESSAGE_CLASS_CACHE = {} - - -# Deprecated. Please NEVER use reflection.ParseMessage(). -def ParseMessage(descriptor, byte_str): - """Generate a new Message instance from this Descriptor and a byte string. - - DEPRECATED: ParseMessage is deprecated because it is using MakeClass(). - Please use MessageFactory.GetMessageClass() instead. - - Args: - descriptor: Protobuf Descriptor object - byte_str: Serialized protocol buffer byte string - - Returns: - Newly created protobuf Message object. - """ - warnings.warn( - 'reflection.ParseMessage() is deprecated. Please use ' - 'MessageFactory.GetMessageClass() and message.ParseFromString() instead. ' - 'reflection.ParseMessage() will be removed in Jan 2025.', - stacklevel=2, - ) - result_class = MakeClass(descriptor) - new_msg = result_class() - new_msg.ParseFromString(byte_str) - return new_msg - - -# Deprecated. Please NEVER use reflection.MakeClass(). -def MakeClass(descriptor): - """Construct a class object for a protobuf described by descriptor. - - DEPRECATED: use MessageFactory.GetMessageClass() instead. - - Args: - descriptor: A descriptor.Descriptor object describing the protobuf. - Returns: - The Message class object described by the descriptor. - """ - warnings.warn( - 'reflection.MakeClass() is deprecated. Please use ' - 'MessageFactory.GetMessageClass() instead. ' - 'reflection.MakeClass() will be removed in Jan 2025.', - stacklevel=2, - ) - # Original implementation leads to duplicate message classes, which won't play - # well with extensions. Message factory info is also missing. - # Redirect to message_factory. - return message_factory.GetMessageClass(descriptor)