From 2772f0d55313d5427738205012ee916099a7eeb1 Mon Sep 17 00:00:00 2001 From: Tamir Duberstein Date: Wed, 4 Aug 2021 08:08:40 -0400 Subject: [PATCH] Disallow unused-function, write-strings unused-function was suppressed way back in b2b65842ea. write-strings was suppressed in 2506cf5cf4. Neither appears to be needed today. --- BUILD | 4 ---- 1 file changed, 4 deletions(-) diff --git a/BUILD b/BUILD index a06baee7b5..92658413ec 100644 --- a/BUILD +++ b/BUILD @@ -39,7 +39,6 @@ MSVC_COPTS = [ "/wd4334", # 'operator' : result of 32-bit shift implicitly converted to 64 bits (was 64-bit shift intended?) "/wd4355", # 'this' : used in base member initializer list "/wd4506", # no definition for inline function 'function' - "/wd4514", # -Wno-unused-function "/wd4800", # 'type' : forcing value to bool 'true' or 'false' (performance warning) "/wd4996", # The compiler encountered a deprecated declaration. ] @@ -51,9 +50,6 @@ COPTS = select({ "-DHAVE_ZLIB", "-Woverloaded-virtual", "-Wno-sign-compare", - "-Wno-unused-function", - # Prevents ISO C++ const string assignment warnings for pyext sources. - "-Wno-write-strings", "-Wno-deprecated-declarations", ], })