Merge "Don't return NULL from {Boxed}PrimitiveTypeName."

pull/91/head
Brian Duff 10 years ago committed by Gerrit Code Review
commit 23c5978a76
  1. 8
      src/google/protobuf/compiler/javanano/javanano_helpers.cc

@ -336,14 +336,14 @@ string PrimitiveTypeName(JavaType type) {
case JAVATYPE_STRING : return "java.lang.String";
case JAVATYPE_BYTES : return "byte[]";
case JAVATYPE_ENUM : return "int";
case JAVATYPE_MESSAGE: return NULL;
case JAVATYPE_MESSAGE: return "";
// No default because we want the compiler to complain if any new
// JavaTypes are added.
}
GOOGLE_LOG(FATAL) << "Can't get here.";
return NULL;
return "";
}
string BoxedPrimitiveTypeName(JavaType type) {
@ -356,14 +356,14 @@ string BoxedPrimitiveTypeName(JavaType type) {
case JAVATYPE_STRING : return "java.lang.String";
case JAVATYPE_BYTES : return "byte[]";
case JAVATYPE_ENUM : return "java.lang.Integer";
case JAVATYPE_MESSAGE: return NULL;
case JAVATYPE_MESSAGE: return "";
// No default because we want the compiler to complain if any new
// JavaTypes are added.
}
GOOGLE_LOG(FATAL) << "Can't get here.";
return NULL;
return "";
}
string EmptyArrayName(const Params& params, const FieldDescriptor* field) {

Loading…
Cancel
Save