From 207d01daa170306370308eb27a5da38d5822a21a Mon Sep 17 00:00:00 2001 From: Paul Yang Date: Tue, 12 Mar 2019 22:33:13 -0700 Subject: [PATCH] Remove GPBWrapperUtil from generated code (#5880) * Remove GPBWrapperUtil from generated code * Add newline --- php/src/Google/Protobuf/Internal/DescriptorProto.php | 1 - .../Protobuf/Internal/DescriptorProto/ExtensionRange.php | 1 - .../Protobuf/Internal/DescriptorProto/ReservedRange.php | 1 - php/src/Google/Protobuf/Internal/EnumDescriptorProto.php | 1 - .../Internal/EnumDescriptorProto/EnumReservedRange.php | 1 - php/src/Google/Protobuf/Internal/EnumOptions.php | 1 - .../Google/Protobuf/Internal/EnumValueDescriptorProto.php | 1 - php/src/Google/Protobuf/Internal/EnumValueOptions.php | 1 - php/src/Google/Protobuf/Internal/ExtensionRangeOptions.php | 1 - php/src/Google/Protobuf/Internal/FieldDescriptorProto.php | 1 - php/src/Google/Protobuf/Internal/FieldOptions.php | 1 - php/src/Google/Protobuf/Internal/FileDescriptorProto.php | 1 - php/src/Google/Protobuf/Internal/FileDescriptorSet.php | 1 - php/src/Google/Protobuf/Internal/FileOptions.php | 1 - php/src/Google/Protobuf/Internal/GeneratedCodeInfo.php | 1 - .../Protobuf/Internal/GeneratedCodeInfo/Annotation.php | 1 - php/src/Google/Protobuf/Internal/MessageOptions.php | 1 - php/src/Google/Protobuf/Internal/MethodDescriptorProto.php | 1 - php/src/Google/Protobuf/Internal/MethodOptions.php | 1 - php/src/Google/Protobuf/Internal/OneofDescriptorProto.php | 1 - php/src/Google/Protobuf/Internal/OneofOptions.php | 1 - php/src/Google/Protobuf/Internal/ServiceDescriptorProto.php | 1 - php/src/Google/Protobuf/Internal/ServiceOptions.php | 1 - php/src/Google/Protobuf/Internal/SourceCodeInfo.php | 1 - .../Google/Protobuf/Internal/SourceCodeInfo/Location.php | 1 - php/src/Google/Protobuf/Internal/UninterpretedOption.php | 1 - .../Protobuf/Internal/UninterpretedOption/NamePart.php | 1 - src/google/protobuf/compiler/php/php_generator.cc | 6 ++---- 28 files changed, 2 insertions(+), 31 deletions(-) diff --git a/php/src/Google/Protobuf/Internal/DescriptorProto.php b/php/src/Google/Protobuf/Internal/DescriptorProto.php index 40ea19ad7b..3b215d52ae 100644 --- a/php/src/Google/Protobuf/Internal/DescriptorProto.php +++ b/php/src/Google/Protobuf/Internal/DescriptorProto.php @@ -9,7 +9,6 @@ use Google\Protobuf\Internal\GPBWire; use Google\Protobuf\Internal\RepeatedField; use Google\Protobuf\Internal\InputStream; use Google\Protobuf\Internal\GPBUtil; -use Google\Protobuf\Internal\GPBWrapperUtils; /** * Describes a message type. diff --git a/php/src/Google/Protobuf/Internal/DescriptorProto/ExtensionRange.php b/php/src/Google/Protobuf/Internal/DescriptorProto/ExtensionRange.php index 85d0f28ec3..c06a0a6ea9 100644 --- a/php/src/Google/Protobuf/Internal/DescriptorProto/ExtensionRange.php +++ b/php/src/Google/Protobuf/Internal/DescriptorProto/ExtensionRange.php @@ -9,7 +9,6 @@ use Google\Protobuf\Internal\GPBWire; use Google\Protobuf\Internal\RepeatedField; use Google\Protobuf\Internal\InputStream; use Google\Protobuf\Internal\GPBUtil; -use Google\Protobuf\Internal\GPBWrapperUtils; /** * Generated from protobuf message google.protobuf.DescriptorProto.ExtensionRange diff --git a/php/src/Google/Protobuf/Internal/DescriptorProto/ReservedRange.php b/php/src/Google/Protobuf/Internal/DescriptorProto/ReservedRange.php index e3c6e5489a..73c964faa0 100644 --- a/php/src/Google/Protobuf/Internal/DescriptorProto/ReservedRange.php +++ b/php/src/Google/Protobuf/Internal/DescriptorProto/ReservedRange.php @@ -9,7 +9,6 @@ use Google\Protobuf\Internal\GPBWire; use Google\Protobuf\Internal\RepeatedField; use Google\Protobuf\Internal\InputStream; use Google\Protobuf\Internal\GPBUtil; -use Google\Protobuf\Internal\GPBWrapperUtils; /** * Range of reserved tag numbers. Reserved tag numbers may not be used by diff --git a/php/src/Google/Protobuf/Internal/EnumDescriptorProto.php b/php/src/Google/Protobuf/Internal/EnumDescriptorProto.php index 25f4933ab8..da30fa9906 100644 --- a/php/src/Google/Protobuf/Internal/EnumDescriptorProto.php +++ b/php/src/Google/Protobuf/Internal/EnumDescriptorProto.php @@ -9,7 +9,6 @@ use Google\Protobuf\Internal\GPBWire; use Google\Protobuf\Internal\RepeatedField; use Google\Protobuf\Internal\InputStream; use Google\Protobuf\Internal\GPBUtil; -use Google\Protobuf\Internal\GPBWrapperUtils; /** * Describes an enum type. diff --git a/php/src/Google/Protobuf/Internal/EnumDescriptorProto/EnumReservedRange.php b/php/src/Google/Protobuf/Internal/EnumDescriptorProto/EnumReservedRange.php index d84e2af316..e1079585ec 100644 --- a/php/src/Google/Protobuf/Internal/EnumDescriptorProto/EnumReservedRange.php +++ b/php/src/Google/Protobuf/Internal/EnumDescriptorProto/EnumReservedRange.php @@ -9,7 +9,6 @@ use Google\Protobuf\Internal\GPBWire; use Google\Protobuf\Internal\RepeatedField; use Google\Protobuf\Internal\InputStream; use Google\Protobuf\Internal\GPBUtil; -use Google\Protobuf\Internal\GPBWrapperUtils; /** * Range of reserved numeric values. Reserved values may not be used by diff --git a/php/src/Google/Protobuf/Internal/EnumOptions.php b/php/src/Google/Protobuf/Internal/EnumOptions.php index 6af31af8b3..3d74c81c21 100644 --- a/php/src/Google/Protobuf/Internal/EnumOptions.php +++ b/php/src/Google/Protobuf/Internal/EnumOptions.php @@ -9,7 +9,6 @@ use Google\Protobuf\Internal\GPBWire; use Google\Protobuf\Internal\RepeatedField; use Google\Protobuf\Internal\InputStream; use Google\Protobuf\Internal\GPBUtil; -use Google\Protobuf\Internal\GPBWrapperUtils; /** * Generated from protobuf message google.protobuf.EnumOptions diff --git a/php/src/Google/Protobuf/Internal/EnumValueDescriptorProto.php b/php/src/Google/Protobuf/Internal/EnumValueDescriptorProto.php index 8601c2b26c..50bda008e8 100644 --- a/php/src/Google/Protobuf/Internal/EnumValueDescriptorProto.php +++ b/php/src/Google/Protobuf/Internal/EnumValueDescriptorProto.php @@ -9,7 +9,6 @@ use Google\Protobuf\Internal\GPBWire; use Google\Protobuf\Internal\RepeatedField; use Google\Protobuf\Internal\InputStream; use Google\Protobuf\Internal\GPBUtil; -use Google\Protobuf\Internal\GPBWrapperUtils; /** * Describes a value within an enum. diff --git a/php/src/Google/Protobuf/Internal/EnumValueOptions.php b/php/src/Google/Protobuf/Internal/EnumValueOptions.php index d1f5edd0e0..a267c6d5e2 100644 --- a/php/src/Google/Protobuf/Internal/EnumValueOptions.php +++ b/php/src/Google/Protobuf/Internal/EnumValueOptions.php @@ -9,7 +9,6 @@ use Google\Protobuf\Internal\GPBWire; use Google\Protobuf\Internal\RepeatedField; use Google\Protobuf\Internal\InputStream; use Google\Protobuf\Internal\GPBUtil; -use Google\Protobuf\Internal\GPBWrapperUtils; /** * Generated from protobuf message google.protobuf.EnumValueOptions diff --git a/php/src/Google/Protobuf/Internal/ExtensionRangeOptions.php b/php/src/Google/Protobuf/Internal/ExtensionRangeOptions.php index caeb802d45..00fbebecaf 100644 --- a/php/src/Google/Protobuf/Internal/ExtensionRangeOptions.php +++ b/php/src/Google/Protobuf/Internal/ExtensionRangeOptions.php @@ -9,7 +9,6 @@ use Google\Protobuf\Internal\GPBWire; use Google\Protobuf\Internal\RepeatedField; use Google\Protobuf\Internal\InputStream; use Google\Protobuf\Internal\GPBUtil; -use Google\Protobuf\Internal\GPBWrapperUtils; /** * Generated from protobuf message google.protobuf.ExtensionRangeOptions diff --git a/php/src/Google/Protobuf/Internal/FieldDescriptorProto.php b/php/src/Google/Protobuf/Internal/FieldDescriptorProto.php index 1dd6523e98..e578197515 100644 --- a/php/src/Google/Protobuf/Internal/FieldDescriptorProto.php +++ b/php/src/Google/Protobuf/Internal/FieldDescriptorProto.php @@ -9,7 +9,6 @@ use Google\Protobuf\Internal\GPBWire; use Google\Protobuf\Internal\RepeatedField; use Google\Protobuf\Internal\InputStream; use Google\Protobuf\Internal\GPBUtil; -use Google\Protobuf\Internal\GPBWrapperUtils; /** * Describes a field within a message. diff --git a/php/src/Google/Protobuf/Internal/FieldOptions.php b/php/src/Google/Protobuf/Internal/FieldOptions.php index c709564984..751c278d78 100644 --- a/php/src/Google/Protobuf/Internal/FieldOptions.php +++ b/php/src/Google/Protobuf/Internal/FieldOptions.php @@ -9,7 +9,6 @@ use Google\Protobuf\Internal\GPBWire; use Google\Protobuf\Internal\RepeatedField; use Google\Protobuf\Internal\InputStream; use Google\Protobuf\Internal\GPBUtil; -use Google\Protobuf\Internal\GPBWrapperUtils; /** * Generated from protobuf message google.protobuf.FieldOptions diff --git a/php/src/Google/Protobuf/Internal/FileDescriptorProto.php b/php/src/Google/Protobuf/Internal/FileDescriptorProto.php index 8eee320ae3..cb10aa7939 100644 --- a/php/src/Google/Protobuf/Internal/FileDescriptorProto.php +++ b/php/src/Google/Protobuf/Internal/FileDescriptorProto.php @@ -9,7 +9,6 @@ use Google\Protobuf\Internal\GPBWire; use Google\Protobuf\Internal\RepeatedField; use Google\Protobuf\Internal\InputStream; use Google\Protobuf\Internal\GPBUtil; -use Google\Protobuf\Internal\GPBWrapperUtils; /** * Describes a complete .proto file. diff --git a/php/src/Google/Protobuf/Internal/FileDescriptorSet.php b/php/src/Google/Protobuf/Internal/FileDescriptorSet.php index b5cc1f11a5..9907b17d73 100644 --- a/php/src/Google/Protobuf/Internal/FileDescriptorSet.php +++ b/php/src/Google/Protobuf/Internal/FileDescriptorSet.php @@ -9,7 +9,6 @@ use Google\Protobuf\Internal\GPBWire; use Google\Protobuf\Internal\RepeatedField; use Google\Protobuf\Internal\InputStream; use Google\Protobuf\Internal\GPBUtil; -use Google\Protobuf\Internal\GPBWrapperUtils; /** * The protocol compiler can output a FileDescriptorSet containing the .proto diff --git a/php/src/Google/Protobuf/Internal/FileOptions.php b/php/src/Google/Protobuf/Internal/FileOptions.php index c6064965d4..c6b36bbc89 100644 --- a/php/src/Google/Protobuf/Internal/FileOptions.php +++ b/php/src/Google/Protobuf/Internal/FileOptions.php @@ -9,7 +9,6 @@ use Google\Protobuf\Internal\GPBWire; use Google\Protobuf\Internal\RepeatedField; use Google\Protobuf\Internal\InputStream; use Google\Protobuf\Internal\GPBUtil; -use Google\Protobuf\Internal\GPBWrapperUtils; /** * Generated from protobuf message google.protobuf.FileOptions diff --git a/php/src/Google/Protobuf/Internal/GeneratedCodeInfo.php b/php/src/Google/Protobuf/Internal/GeneratedCodeInfo.php index 2d6fe0053b..f5a65bea46 100644 --- a/php/src/Google/Protobuf/Internal/GeneratedCodeInfo.php +++ b/php/src/Google/Protobuf/Internal/GeneratedCodeInfo.php @@ -9,7 +9,6 @@ use Google\Protobuf\Internal\GPBWire; use Google\Protobuf\Internal\RepeatedField; use Google\Protobuf\Internal\InputStream; use Google\Protobuf\Internal\GPBUtil; -use Google\Protobuf\Internal\GPBWrapperUtils; /** * Describes the relationship between generated code and its original source diff --git a/php/src/Google/Protobuf/Internal/GeneratedCodeInfo/Annotation.php b/php/src/Google/Protobuf/Internal/GeneratedCodeInfo/Annotation.php index 74e089cc4d..09f958d251 100644 --- a/php/src/Google/Protobuf/Internal/GeneratedCodeInfo/Annotation.php +++ b/php/src/Google/Protobuf/Internal/GeneratedCodeInfo/Annotation.php @@ -9,7 +9,6 @@ use Google\Protobuf\Internal\GPBWire; use Google\Protobuf\Internal\RepeatedField; use Google\Protobuf\Internal\InputStream; use Google\Protobuf\Internal\GPBUtil; -use Google\Protobuf\Internal\GPBWrapperUtils; /** * Generated from protobuf message google.protobuf.GeneratedCodeInfo.Annotation diff --git a/php/src/Google/Protobuf/Internal/MessageOptions.php b/php/src/Google/Protobuf/Internal/MessageOptions.php index ccf0919bef..bf490de686 100644 --- a/php/src/Google/Protobuf/Internal/MessageOptions.php +++ b/php/src/Google/Protobuf/Internal/MessageOptions.php @@ -9,7 +9,6 @@ use Google\Protobuf\Internal\GPBWire; use Google\Protobuf\Internal\RepeatedField; use Google\Protobuf\Internal\InputStream; use Google\Protobuf\Internal\GPBUtil; -use Google\Protobuf\Internal\GPBWrapperUtils; /** * Generated from protobuf message google.protobuf.MessageOptions diff --git a/php/src/Google/Protobuf/Internal/MethodDescriptorProto.php b/php/src/Google/Protobuf/Internal/MethodDescriptorProto.php index fba0c9966c..1bd5dd3e1c 100644 --- a/php/src/Google/Protobuf/Internal/MethodDescriptorProto.php +++ b/php/src/Google/Protobuf/Internal/MethodDescriptorProto.php @@ -9,7 +9,6 @@ use Google\Protobuf\Internal\GPBWire; use Google\Protobuf\Internal\RepeatedField; use Google\Protobuf\Internal\InputStream; use Google\Protobuf\Internal\GPBUtil; -use Google\Protobuf\Internal\GPBWrapperUtils; /** * Describes a method of a service. diff --git a/php/src/Google/Protobuf/Internal/MethodOptions.php b/php/src/Google/Protobuf/Internal/MethodOptions.php index 21c07f5c2a..a2c729a9bb 100644 --- a/php/src/Google/Protobuf/Internal/MethodOptions.php +++ b/php/src/Google/Protobuf/Internal/MethodOptions.php @@ -9,7 +9,6 @@ use Google\Protobuf\Internal\GPBWire; use Google\Protobuf\Internal\RepeatedField; use Google\Protobuf\Internal\InputStream; use Google\Protobuf\Internal\GPBUtil; -use Google\Protobuf\Internal\GPBWrapperUtils; /** * Generated from protobuf message google.protobuf.MethodOptions diff --git a/php/src/Google/Protobuf/Internal/OneofDescriptorProto.php b/php/src/Google/Protobuf/Internal/OneofDescriptorProto.php index c471c80afe..9ecfe5cbfe 100644 --- a/php/src/Google/Protobuf/Internal/OneofDescriptorProto.php +++ b/php/src/Google/Protobuf/Internal/OneofDescriptorProto.php @@ -9,7 +9,6 @@ use Google\Protobuf\Internal\GPBWire; use Google\Protobuf\Internal\RepeatedField; use Google\Protobuf\Internal\InputStream; use Google\Protobuf\Internal\GPBUtil; -use Google\Protobuf\Internal\GPBWrapperUtils; /** * Describes a oneof. diff --git a/php/src/Google/Protobuf/Internal/OneofOptions.php b/php/src/Google/Protobuf/Internal/OneofOptions.php index dab1db4ae3..46b516f301 100644 --- a/php/src/Google/Protobuf/Internal/OneofOptions.php +++ b/php/src/Google/Protobuf/Internal/OneofOptions.php @@ -9,7 +9,6 @@ use Google\Protobuf\Internal\GPBWire; use Google\Protobuf\Internal\RepeatedField; use Google\Protobuf\Internal\InputStream; use Google\Protobuf\Internal\GPBUtil; -use Google\Protobuf\Internal\GPBWrapperUtils; /** * Generated from protobuf message google.protobuf.OneofOptions diff --git a/php/src/Google/Protobuf/Internal/ServiceDescriptorProto.php b/php/src/Google/Protobuf/Internal/ServiceDescriptorProto.php index a7173719a9..8de7afd0bc 100644 --- a/php/src/Google/Protobuf/Internal/ServiceDescriptorProto.php +++ b/php/src/Google/Protobuf/Internal/ServiceDescriptorProto.php @@ -9,7 +9,6 @@ use Google\Protobuf\Internal\GPBWire; use Google\Protobuf\Internal\RepeatedField; use Google\Protobuf\Internal\InputStream; use Google\Protobuf\Internal\GPBUtil; -use Google\Protobuf\Internal\GPBWrapperUtils; /** * Describes a service. diff --git a/php/src/Google/Protobuf/Internal/ServiceOptions.php b/php/src/Google/Protobuf/Internal/ServiceOptions.php index d59d9c3be2..67162f3764 100644 --- a/php/src/Google/Protobuf/Internal/ServiceOptions.php +++ b/php/src/Google/Protobuf/Internal/ServiceOptions.php @@ -9,7 +9,6 @@ use Google\Protobuf\Internal\GPBWire; use Google\Protobuf\Internal\RepeatedField; use Google\Protobuf\Internal\InputStream; use Google\Protobuf\Internal\GPBUtil; -use Google\Protobuf\Internal\GPBWrapperUtils; /** * Generated from protobuf message google.protobuf.ServiceOptions diff --git a/php/src/Google/Protobuf/Internal/SourceCodeInfo.php b/php/src/Google/Protobuf/Internal/SourceCodeInfo.php index 75cc3dd247..6e413f77a2 100644 --- a/php/src/Google/Protobuf/Internal/SourceCodeInfo.php +++ b/php/src/Google/Protobuf/Internal/SourceCodeInfo.php @@ -9,7 +9,6 @@ use Google\Protobuf\Internal\GPBWire; use Google\Protobuf\Internal\RepeatedField; use Google\Protobuf\Internal\InputStream; use Google\Protobuf\Internal\GPBUtil; -use Google\Protobuf\Internal\GPBWrapperUtils; /** * Encapsulates information about the original source file from which a diff --git a/php/src/Google/Protobuf/Internal/SourceCodeInfo/Location.php b/php/src/Google/Protobuf/Internal/SourceCodeInfo/Location.php index dd39e5b63e..bad247a11f 100644 --- a/php/src/Google/Protobuf/Internal/SourceCodeInfo/Location.php +++ b/php/src/Google/Protobuf/Internal/SourceCodeInfo/Location.php @@ -9,7 +9,6 @@ use Google\Protobuf\Internal\GPBWire; use Google\Protobuf\Internal\RepeatedField; use Google\Protobuf\Internal\InputStream; use Google\Protobuf\Internal\GPBUtil; -use Google\Protobuf\Internal\GPBWrapperUtils; /** * Generated from protobuf message google.protobuf.SourceCodeInfo.Location diff --git a/php/src/Google/Protobuf/Internal/UninterpretedOption.php b/php/src/Google/Protobuf/Internal/UninterpretedOption.php index 2a13d98a02..3b517ec552 100644 --- a/php/src/Google/Protobuf/Internal/UninterpretedOption.php +++ b/php/src/Google/Protobuf/Internal/UninterpretedOption.php @@ -9,7 +9,6 @@ use Google\Protobuf\Internal\GPBWire; use Google\Protobuf\Internal\RepeatedField; use Google\Protobuf\Internal\InputStream; use Google\Protobuf\Internal\GPBUtil; -use Google\Protobuf\Internal\GPBWrapperUtils; /** * A message representing a option the parser does not recognize. This only diff --git a/php/src/Google/Protobuf/Internal/UninterpretedOption/NamePart.php b/php/src/Google/Protobuf/Internal/UninterpretedOption/NamePart.php index f40c485e77..92ee4b44b9 100644 --- a/php/src/Google/Protobuf/Internal/UninterpretedOption/NamePart.php +++ b/php/src/Google/Protobuf/Internal/UninterpretedOption/NamePart.php @@ -9,7 +9,6 @@ use Google\Protobuf\Internal\GPBWire; use Google\Protobuf\Internal\RepeatedField; use Google\Protobuf\Internal\InputStream; use Google\Protobuf\Internal\GPBUtil; -use Google\Protobuf\Internal\GPBWrapperUtils; /** * The name of the uninterpreted option. Each string represents a segment in diff --git a/src/google/protobuf/compiler/php/php_generator.cc b/src/google/protobuf/compiler/php/php_generator.cc index 3e7c320768..d7e33b2c06 100644 --- a/src/google/protobuf/compiler/php/php_generator.cc +++ b/src/google/protobuf/compiler/php/php_generator.cc @@ -1023,16 +1023,14 @@ void GenerateUseDeclaration(bool is_descriptor, io::Printer* printer) { printer->Print( "use Google\\Protobuf\\Internal\\GPBType;\n" "use Google\\Protobuf\\Internal\\RepeatedField;\n" - "use Google\\Protobuf\\Internal\\GPBUtil;\n" - "use Google\\Protobuf\\Internal\\GPBWrapperUtils;\n\n"); + "use Google\\Protobuf\\Internal\\GPBUtil;\n\n"); } else { printer->Print( "use Google\\Protobuf\\Internal\\GPBType;\n" "use Google\\Protobuf\\Internal\\GPBWire;\n" "use Google\\Protobuf\\Internal\\RepeatedField;\n" "use Google\\Protobuf\\Internal\\InputStream;\n" - "use Google\\Protobuf\\Internal\\GPBUtil;\n" - "use Google\\Protobuf\\Internal\\GPBWrapperUtils;\n\n"); + "use Google\\Protobuf\\Internal\\GPBUtil;\n\n"); } }