From 1c5e8cbb8fedafbb45f62d28d9d4ff2362168601 Mon Sep 17 00:00:00 2001 From: Keith Smiley Date: Wed, 10 Apr 2019 11:08:59 -0700 Subject: [PATCH] Remove -Wall from default build options All bazel crosstools automatically pass -Wall to compiles. The order of operations is: - bazel crosstool flags - `--host_copt` flags and other variations like `--host_cxxopt` - the `copts` defined on the rule Because of this when protobuf produces warnings, there's no way to disable them from the consumer side if they are re-enabled later by another `-Wall` flag. --- BUILD | 1 - 1 file changed, 1 deletion(-) diff --git a/BUILD b/BUILD index 1961cc4e75..2fb2605093 100644 --- a/BUILD +++ b/BUILD @@ -49,7 +49,6 @@ COPTS = select({ "//conditions:default": [ "-DHAVE_PTHREAD", "-DHAVE_ZLIB", - "-Wall", "-Woverloaded-virtual", "-Wno-sign-compare", "-Wno-unused-function",