Add comment and Assert.DoesNotThrow to RequiredFieldsNoThrow

pull/6674/head
Sydney Acksman 5 years ago
parent f084d622c2
commit 1a0ff9551a
  1. 7
      csharp/src/Google.Protobuf.Test/GeneratedMessageTest.Proto2.cs

@ -261,11 +261,14 @@ namespace Google.Protobuf
Assert.True(message.IsInitialized());
}
// Code was accidentally left in message parser that threw exceptions when missing required fields after parsing.
// We've decided to not throw exceptions on missing fields, instead leaving it up to the consumer how they
// want to check and handle missing fields.
[Test]
public void RequiredFieldsNoThrow()
{
TestRequired.Parser.ParseFrom(new byte[0]);
(TestRequired.Parser as MessageParser).ParseFrom(new byte[0]);
Assert.DoesNotThrow(() => TestRequired.Parser.ParseFrom(new byte[0]));
Assert.DoesNotThrow(() => (TestRequired.Parser as MessageParser).ParseFrom(new byte[0]));
}
[Test]

Loading…
Cancel
Save