Revert guava depedency to version 19.

pull/2981/merge
Feng Xiao 8 years ago
parent 474cca52a3
commit 129a6e2aca
  1. 5
      java/core/pom.xml
  2. 28
      java/core/src/test/java/com/google/protobuf/TextFormatTest.java
  3. 8
      java/pom.xml

@ -34,11 +34,6 @@
<artifactId>easymockclassextension</artifactId> <artifactId>easymockclassextension</artifactId>
<scope>test</scope> <scope>test</scope>
</dependency> </dependency>
<dependency>
<groupId>com.google.truth</groupId>
<artifactId>truth</artifactId>
<scope>test</scope>
</dependency>
</dependencies> </dependencies>
<build> <build>

@ -30,8 +30,6 @@
package com.google.protobuf; package com.google.protobuf;
import static com.google.common.truth.Truth.assertThat;
import com.google.protobuf.Descriptors.Descriptor; import com.google.protobuf.Descriptors.Descriptor;
import com.google.protobuf.Descriptors.FieldDescriptor; import com.google.protobuf.Descriptors.FieldDescriptor;
import com.google.protobuf.TextFormat.Parser.SingularOverwritePolicy; import com.google.protobuf.TextFormat.Parser.SingularOverwritePolicy;
@ -1079,12 +1077,12 @@ public class TextFormatTest extends TestCase {
{ {
TestMap.Builder dest = TestMap.newBuilder(); TestMap.Builder dest = TestMap.newBuilder();
TextFormat.merge(text, dest); TextFormat.merge(text, dest);
assertThat(dest.build()).isEqualTo(message); assertEquals(message, dest.build());
} }
{ {
TestMap.Builder dest = TestMap.newBuilder(); TestMap.Builder dest = TestMap.newBuilder();
parserWithOverwriteForbidden.merge(text, dest); parserWithOverwriteForbidden.merge(text, dest);
assertThat(dest.build()).isEqualTo(message); assertEquals(message, dest.build());
} }
} }
@ -1096,10 +1094,10 @@ public class TextFormatTest extends TestCase {
TestMap.Builder dest = TestMap.newBuilder(); TestMap.Builder dest = TestMap.newBuilder();
parserWithOverwriteForbidden.merge(text, dest); parserWithOverwriteForbidden.merge(text, dest);
TestMap message = dest.build(); TestMap message = dest.build();
assertThat(message.getStringToInt32Field().size()).isEqualTo(2); assertEquals(2, message.getStringToInt32Field().size());
assertThat(message.getInt32ToMessageField().size()).isEqualTo(2); assertEquals(2, message.getInt32ToMessageField().size());
assertThat(message.getStringToInt32Field().get("x")).isEqualTo(10); assertEquals(10, message.getStringToInt32Field().get("x").intValue());
assertThat(message.getInt32ToMessageField().get(2).getValue()).isEqualTo(200); assertEquals(200, message.getInt32ToMessageField().get(2).getValue());
} }
public void testMapShortFormEmpty() throws Exception { public void testMapShortFormEmpty() throws Exception {
@ -1108,8 +1106,8 @@ public class TextFormatTest extends TestCase {
TestMap.Builder dest = TestMap.newBuilder(); TestMap.Builder dest = TestMap.newBuilder();
parserWithOverwriteForbidden.merge(text, dest); parserWithOverwriteForbidden.merge(text, dest);
TestMap message = dest.build(); TestMap message = dest.build();
assertThat(message.getStringToInt32Field().size()).isEqualTo(0); assertEquals(0, message.getStringToInt32Field().size());
assertThat(message.getInt32ToMessageField().size()).isEqualTo(0); assertEquals(0, message.getInt32ToMessageField().size());
} }
public void testMapShortFormTrailingComma() throws Exception { public void testMapShortFormTrailingComma() throws Exception {
@ -1119,7 +1117,7 @@ public class TextFormatTest extends TestCase {
parserWithOverwriteForbidden.merge(text, dest); parserWithOverwriteForbidden.merge(text, dest);
fail("Expected parse exception."); fail("Expected parse exception.");
} catch (TextFormat.ParseException e) { } catch (TextFormat.ParseException e) {
assertThat(e).hasMessageThat().isEqualTo("1:48: Expected \"{\"."); assertEquals("1:48: Expected \"{\".", e.getMessage());
} }
} }
@ -1134,8 +1132,8 @@ public class TextFormatTest extends TestCase {
TestMap.Builder builder = TestMap.newBuilder(); TestMap.Builder builder = TestMap.newBuilder();
defaultParser.merge(text, builder); defaultParser.merge(text, builder);
TestMap map = builder.build(); TestMap map = builder.build();
assertThat(map.getInt32ToInt32Field().size()).isEqualTo(2); assertEquals(2, map.getInt32ToInt32Field().size());
assertThat(map.getInt32ToInt32Field().get(1).intValue()).isEqualTo(30); assertEquals(30, map.getInt32ToInt32Field().get(1).intValue());
} }
{ {
@ -1144,8 +1142,8 @@ public class TextFormatTest extends TestCase {
TestMap.Builder builder = TestMap.newBuilder(); TestMap.Builder builder = TestMap.newBuilder();
defaultParser.merge(text, builder); defaultParser.merge(text, builder);
TestMap map = builder.build(); TestMap map = builder.build();
assertThat(map.getInt32ToInt32Field().size()).isEqualTo(2); assertEquals(2, map.getInt32ToInt32Field().size());
assertThat(map.getInt32ToInt32Field().get(1).intValue()).isEqualTo(30); assertEquals(30, map.getInt32ToInt32Field().get(1).intValue());
} }
} }

@ -84,13 +84,7 @@
<dependency> <dependency>
<groupId>com.google.guava</groupId> <groupId>com.google.guava</groupId>
<artifactId>guava</artifactId> <artifactId>guava</artifactId>
<version>20.0</version> <version>19.0</version>
</dependency>
<dependency>
<groupId>com.google.truth</groupId>
<artifactId>truth</artifactId>
<scope>test</scope>
<version>0.32</version>
</dependency> </dependency>
</dependencies> </dependencies>
</dependencyManagement> </dependencyManagement>

Loading…
Cancel
Save