Merge pull request #1923 from bryongloden/patch-1

close opened file descriptors properly
8 years ago · 1102a8a767
parent e30b7b4461 a375e1acfd
commit 1102a8a767
1 changed files with 1 additions and 0 deletions
--- a/src/google/protobuf/testing/file.cc
+++ b/src/google/protobuf/testing/file.cc
@ -91,6 +91,7 @@ bool File::WriteStringToFile(const string& contents, const string& name) {

  if (fwrite(contents.data(), 1, contents.size(), file) != contents.size()) {
    GOOGLE_LOG(ERROR) << "fwrite(" << name << "): " << strerror(errno);
+    fclose(file);
    return false;
  }