From 0ea9f73be35e35db242ccc65aa9c87487b792324 Mon Sep 17 00:00:00 2001 From: Jie Luo Date: Mon, 12 Jun 2023 15:49:48 -0700 Subject: [PATCH] skip some upb python test which extend non iterable value to repeated field PiperOrigin-RevId: 539783147 --- python/pb_unit_tests/message_test_wrapper.py | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/python/pb_unit_tests/message_test_wrapper.py b/python/pb_unit_tests/message_test_wrapper.py index bb1b6c7de9..08cd363051 100644 --- a/python/pb_unit_tests/message_test_wrapper.py +++ b/python/pb_unit_tests/message_test_wrapper.py @@ -26,14 +26,12 @@ from google.protobuf.internal.message_test import * import unittest -# We don't want to support extending repeated fields with nothing; this behavior -# is marked for deprecation in the existing library. -MessageTest.testExtendFloatWithNothing_proto2.__unittest_expecting_failure__ = True -MessageTest.testExtendFloatWithNothing_proto3.__unittest_expecting_failure__ = True -MessageTest.testExtendInt32WithNothing_proto2.__unittest_expecting_failure__ = True -MessageTest.testExtendInt32WithNothing_proto3.__unittest_expecting_failure__ = True -MessageTest.testExtendStringWithNothing_proto2.__unittest_expecting_failure__ = True -MessageTest.testExtendStringWithNothing_proto3.__unittest_expecting_failure__ = True +MessageTest.testExtendFloatWithNothing_proto2.__unittest_skip__ = True +MessageTest.testExtendFloatWithNothing_proto3.__unittest_skip__ = True +MessageTest.testExtendInt32WithNothing_proto2.__unittest_skip__ = True +MessageTest.testExtendInt32WithNothing_proto3.__unittest_skip__ = True +MessageTest.testExtendStringWithNothing_proto2.__unittest_skip__ = True +MessageTest.testExtendStringWithNothing_proto3.__unittest_skip__ = True # Python/C++ customizes the C++ TextFormat to always print trailing ".0" for # floats. upb doesn't do this, it matches C++ TextFormat.