diff --git a/csharp/src/Google.Protobuf.Test/GeneratedMessageTest.Proto2.cs b/csharp/src/Google.Protobuf.Test/GeneratedMessageTest.Proto2.cs index aa977db141..e1d4d7809a 100644 --- a/csharp/src/Google.Protobuf.Test/GeneratedMessageTest.Proto2.cs +++ b/csharp/src/Google.Protobuf.Test/GeneratedMessageTest.Proto2.cs @@ -278,7 +278,7 @@ namespace Google.Protobuf Assert.True(message.IsInitialized()); - message.GetOrRegisterExtension(TestRequired.Extensions.Multi); + message.GetOrInitializeExtension(TestRequired.Extensions.Multi); Assert.True(message.IsInitialized()); @@ -297,7 +297,7 @@ namespace Google.Protobuf Assert.True(message.IsInitialized()); - message.GetOrRegisterExtension(UnittestExtensions.RepeatedBoolExtension).Add(true); + message.GetOrInitializeExtension(UnittestExtensions.RepeatedBoolExtension).Add(true); Assert.True(message.IsInitialized()); } @@ -342,7 +342,7 @@ namespace Google.Protobuf { var message = new TestAllExtensions(); message.SetExtension(UnittestExtensions.OptionalGroupExtension, new OptionalGroup_extension { A = 10 }); - message.GetOrRegisterExtension(UnittestExtensions.RepeatedGroupExtension).AddRange(new[] + message.GetOrInitializeExtension(UnittestExtensions.RepeatedGroupExtension).AddRange(new[] { new RepeatedGroup_extension { A = 10 }, new RepeatedGroup_extension { A = 20 }, diff --git a/csharp/src/Google.Protobuf.Test/SampleMessages.cs b/csharp/src/Google.Protobuf.Test/SampleMessages.cs index b2c50397d6..03a20d6685 100644 --- a/csharp/src/Google.Protobuf.Test/SampleMessages.cs +++ b/csharp/src/Google.Protobuf.Test/SampleMessages.cs @@ -32,8 +32,8 @@ using System; using Google.Protobuf.TestProtos; -using Proto2 = Google.Protobuf.TestProtos.Proto2; - +using Proto2 = Google.Protobuf.TestProtos.Proto2; + using static Google.Protobuf.TestProtos.Proto2.UnittestExtensions; namespace Google.Protobuf @@ -152,9 +152,9 @@ namespace Google.Protobuf }; } - public static Proto2.TestAllExtensions CreateFullTestAllExtensions() - { - var message = new Proto2.TestAllExtensions(); + public static Proto2.TestAllExtensions CreateFullTestAllExtensions() + { + var message = new Proto2.TestAllExtensions(); message.SetExtension(OptionalBoolExtension, true); message.SetExtension(OptionalBytesExtension, ByteString.CopyFrom(1, 2, 3, 4)); message.SetExtension(OptionalDoubleExtension, 23.5); @@ -178,30 +178,30 @@ namespace Google.Protobuf message.SetExtension(OptionalUint32Extension, UInt32.MaxValue); message.SetExtension(OptionalUint64Extension, UInt64.MaxValue); message.SetExtension(OptionalGroupExtension, new Proto2.OptionalGroup_extension { A = 10 }); - message.GetOrRegisterExtension(RepeatedBoolExtension).AddRange(new[] { true, false }); - message.GetOrRegisterExtension(RepeatedBytesExtension).AddRange(new[] { ByteString.CopyFrom(1, 2, 3, 4), ByteString.CopyFrom(5, 6), ByteString.CopyFrom(new byte[1000]) }); - message.GetOrRegisterExtension(RepeatedDoubleExtension).AddRange(new[] { -12.25, 23.5 }); - message.GetOrRegisterExtension(RepeatedFixed32Extension).AddRange(new[] { UInt32.MaxValue, 23u }); - message.GetOrRegisterExtension(RepeatedFixed64Extension).AddRange(new[] { UInt64.MaxValue, 1234567890123ul }); - message.GetOrRegisterExtension(RepeatedFloatExtension).AddRange(new[] { 100f, 12.25f }); - message.GetOrRegisterExtension(RepeatedForeignEnumExtension).AddRange(new[] { Proto2.ForeignEnum.ForeignFoo, Proto2.ForeignEnum.ForeignBar }); - message.GetOrRegisterExtension(RepeatedForeignMessageExtension).AddRange(new[] { new Proto2.ForeignMessage(), new Proto2.ForeignMessage { C = 10 } }); - message.GetOrRegisterExtension(RepeatedImportEnumExtension).AddRange(new[] { Proto2.ImportEnum.ImportBaz, Proto2.ImportEnum.ImportFoo }); - message.GetOrRegisterExtension(RepeatedImportMessageExtension).AddRange(new[] { new Proto2.ImportMessage { D = 20 }, new Proto2.ImportMessage { D = 25 } }); - message.GetOrRegisterExtension(RepeatedInt32Extension).AddRange(new[] { 100, 200 }); - message.GetOrRegisterExtension(RepeatedInt64Extension).AddRange(new[] { 3210987654321, Int64.MaxValue }); - message.GetOrRegisterExtension(RepeatedNestedEnumExtension).AddRange(new[] { Proto2.TestAllTypes.Types.NestedEnum.Foo, Proto2.TestAllTypes.Types.NestedEnum.Neg }); - message.GetOrRegisterExtension(RepeatedNestedMessageExtension).AddRange(new[] { new Proto2.TestAllTypes.Types.NestedMessage { Bb = 35 }, new Proto2.TestAllTypes.Types.NestedMessage { Bb = 10 } }); - message.GetOrRegisterExtension(RepeatedSfixed32Extension).AddRange(new[] { -123, 123 }); - message.GetOrRegisterExtension(RepeatedSfixed64Extension).AddRange(new[] { -12345678901234, 12345678901234 }); - message.GetOrRegisterExtension(RepeatedSint32Extension).AddRange(new[] { -456, 100 }); - message.GetOrRegisterExtension(RepeatedSint64Extension).AddRange(new[] { -12345678901235, 123 }); - message.GetOrRegisterExtension(RepeatedStringExtension).AddRange(new[] { "foo", "bar" }); - message.GetOrRegisterExtension(RepeatedUint32Extension).AddRange(new[] { UInt32.MaxValue, UInt32.MinValue }); - message.GetOrRegisterExtension(RepeatedUint64Extension).AddRange(new[] { UInt64.MaxValue, UInt32.MinValue }); - message.GetOrRegisterExtension(RepeatedGroupExtension).AddRange(new[] { new Proto2.RepeatedGroup_extension { A = 10 }, new Proto2.RepeatedGroup_extension { A = 20 } }); - message.SetExtension(OneofStringExtension, "Oneof string"); - return message; + message.GetOrInitializeExtension(RepeatedBoolExtension).AddRange(new[] { true, false }); + message.GetOrInitializeExtension(RepeatedBytesExtension).AddRange(new[] { ByteString.CopyFrom(1, 2, 3, 4), ByteString.CopyFrom(5, 6), ByteString.CopyFrom(new byte[1000]) }); + message.GetOrInitializeExtension(RepeatedDoubleExtension).AddRange(new[] { -12.25, 23.5 }); + message.GetOrInitializeExtension(RepeatedFixed32Extension).AddRange(new[] { UInt32.MaxValue, 23u }); + message.GetOrInitializeExtension(RepeatedFixed64Extension).AddRange(new[] { UInt64.MaxValue, 1234567890123ul }); + message.GetOrInitializeExtension(RepeatedFloatExtension).AddRange(new[] { 100f, 12.25f }); + message.GetOrInitializeExtension(RepeatedForeignEnumExtension).AddRange(new[] { Proto2.ForeignEnum.ForeignFoo, Proto2.ForeignEnum.ForeignBar }); + message.GetOrInitializeExtension(RepeatedForeignMessageExtension).AddRange(new[] { new Proto2.ForeignMessage(), new Proto2.ForeignMessage { C = 10 } }); + message.GetOrInitializeExtension(RepeatedImportEnumExtension).AddRange(new[] { Proto2.ImportEnum.ImportBaz, Proto2.ImportEnum.ImportFoo }); + message.GetOrInitializeExtension(RepeatedImportMessageExtension).AddRange(new[] { new Proto2.ImportMessage { D = 20 }, new Proto2.ImportMessage { D = 25 } }); + message.GetOrInitializeExtension(RepeatedInt32Extension).AddRange(new[] { 100, 200 }); + message.GetOrInitializeExtension(RepeatedInt64Extension).AddRange(new[] { 3210987654321, Int64.MaxValue }); + message.GetOrInitializeExtension(RepeatedNestedEnumExtension).AddRange(new[] { Proto2.TestAllTypes.Types.NestedEnum.Foo, Proto2.TestAllTypes.Types.NestedEnum.Neg }); + message.GetOrInitializeExtension(RepeatedNestedMessageExtension).AddRange(new[] { new Proto2.TestAllTypes.Types.NestedMessage { Bb = 35 }, new Proto2.TestAllTypes.Types.NestedMessage { Bb = 10 } }); + message.GetOrInitializeExtension(RepeatedSfixed32Extension).AddRange(new[] { -123, 123 }); + message.GetOrInitializeExtension(RepeatedSfixed64Extension).AddRange(new[] { -12345678901234, 12345678901234 }); + message.GetOrInitializeExtension(RepeatedSint32Extension).AddRange(new[] { -456, 100 }); + message.GetOrInitializeExtension(RepeatedSint64Extension).AddRange(new[] { -12345678901235, 123 }); + message.GetOrInitializeExtension(RepeatedStringExtension).AddRange(new[] { "foo", "bar" }); + message.GetOrInitializeExtension(RepeatedUint32Extension).AddRange(new[] { UInt32.MaxValue, UInt32.MinValue }); + message.GetOrInitializeExtension(RepeatedUint64Extension).AddRange(new[] { UInt64.MaxValue, UInt32.MinValue }); + message.GetOrInitializeExtension(RepeatedGroupExtension).AddRange(new[] { new Proto2.RepeatedGroup_extension { A = 10 }, new Proto2.RepeatedGroup_extension { A = 20 } }); + message.SetExtension(OneofStringExtension, "Oneof string"); + return message; } } } \ No newline at end of file diff --git a/csharp/src/Google.Protobuf.Test/TestProtos/TestMessagesProto2.cs b/csharp/src/Google.Protobuf.Test/TestProtos/TestMessagesProto2.cs index ac6ba48f8e..2f25195a1d 100644 --- a/csharp/src/Google.Protobuf.Test/TestProtos/TestMessagesProto2.cs +++ b/csharp/src/Google.Protobuf.Test/TestProtos/TestMessagesProto2.cs @@ -3904,8 +3904,8 @@ namespace ProtobufTestMessages.Proto2 { public pbc::RepeatedField GetExtension(pb::RepeatedExtension extension) { return pb::ExtensionSet.Get(ref _extensions, extension); } - public pbc::RepeatedField GetOrRegisterExtension(pb::RepeatedExtension extension) { - return pb::ExtensionSet.GetOrRegister(ref _extensions, extension); + public pbc::RepeatedField GetOrInitializeExtension(pb::RepeatedExtension extension) { + return pb::ExtensionSet.GetOrInitialize(ref _extensions, extension); } public void SetExtension(pb::Extension extension, TValue value) { pb::ExtensionSet.Set(ref _extensions, extension, value); @@ -4438,8 +4438,8 @@ namespace ProtobufTestMessages.Proto2 { public pbc::RepeatedField GetExtension(pb::RepeatedExtension extension) { return pb::ExtensionSet.Get(ref _extensions, extension); } - public pbc::RepeatedField GetOrRegisterExtension(pb::RepeatedExtension extension) { - return pb::ExtensionSet.GetOrRegister(ref _extensions, extension); + public pbc::RepeatedField GetOrInitializeExtension(pb::RepeatedExtension extension) { + return pb::ExtensionSet.GetOrInitialize(ref _extensions, extension); } public void SetExtension(pb::Extension extension, TValue value) { pb::ExtensionSet.Set(ref _extensions, extension, value); diff --git a/csharp/src/Google.Protobuf.Test/TestProtos/Unittest.cs b/csharp/src/Google.Protobuf.Test/TestProtos/Unittest.cs index 5d7339f150..5daf9fb8e2 100644 --- a/csharp/src/Google.Protobuf.Test/TestProtos/Unittest.cs +++ b/csharp/src/Google.Protobuf.Test/TestProtos/Unittest.cs @@ -5258,8 +5258,8 @@ namespace Google.Protobuf.TestProtos.Proto2 { public pbc::RepeatedField GetExtension(pb::RepeatedExtension extension) { return pb::ExtensionSet.Get(ref _extensions, extension); } - public pbc::RepeatedField GetOrRegisterExtension(pb::RepeatedExtension extension) { - return pb::ExtensionSet.GetOrRegister(ref _extensions, extension); + public pbc::RepeatedField GetOrInitializeExtension(pb::RepeatedExtension extension) { + return pb::ExtensionSet.GetOrInitialize(ref _extensions, extension); } public void SetExtension(pb::Extension extension, TValue value) { pb::ExtensionSet.Set(ref _extensions, extension, value); @@ -6033,8 +6033,8 @@ namespace Google.Protobuf.TestProtos.Proto2 { public pbc::RepeatedField GetExtension(pb::RepeatedExtension extension) { return pb::ExtensionSet.Get(ref _extensions, extension); } - public pbc::RepeatedField GetOrRegisterExtension(pb::RepeatedExtension extension) { - return pb::ExtensionSet.GetOrRegister(ref _extensions, extension); + public pbc::RepeatedField GetOrInitializeExtension(pb::RepeatedExtension extension) { + return pb::ExtensionSet.GetOrInitialize(ref _extensions, extension); } public void SetExtension(pb::Extension extension, TValue value) { pb::ExtensionSet.Set(ref _extensions, extension, value); @@ -8604,8 +8604,8 @@ namespace Google.Protobuf.TestProtos.Proto2 { public pbc::RepeatedField GetExtension(pb::RepeatedExtension extension) { return pb::ExtensionSet.Get(ref _extensions, extension); } - public pbc::RepeatedField GetOrRegisterExtension(pb::RepeatedExtension extension) { - return pb::ExtensionSet.GetOrRegister(ref _extensions, extension); + public pbc::RepeatedField GetOrInitializeExtension(pb::RepeatedExtension extension) { + return pb::ExtensionSet.GetOrInitialize(ref _extensions, extension); } public void SetExtension(pb::Extension extension, TValue value) { pb::ExtensionSet.Set(ref _extensions, extension, value); @@ -8745,8 +8745,8 @@ namespace Google.Protobuf.TestProtos.Proto2 { public pbc::RepeatedField GetExtension(pb::RepeatedExtension extension) { return pb::ExtensionSet.Get(ref _extensions, extension); } - public pbc::RepeatedField GetOrRegisterExtension(pb::RepeatedExtension extension) { - return pb::ExtensionSet.GetOrRegister(ref _extensions, extension); + public pbc::RepeatedField GetOrInitializeExtension(pb::RepeatedExtension extension) { + return pb::ExtensionSet.GetOrInitialize(ref _extensions, extension); } public void SetExtension(pb::Extension extension, TValue value) { pb::ExtensionSet.Set(ref _extensions, extension, value); @@ -12223,8 +12223,8 @@ namespace Google.Protobuf.TestProtos.Proto2 { public pbc::RepeatedField GetExtension(pb::RepeatedExtension extension) { return pb::ExtensionSet.Get(ref _extensions, extension); } - public pbc::RepeatedField GetOrRegisterExtension(pb::RepeatedExtension extension) { - return pb::ExtensionSet.GetOrRegister(ref _extensions, extension); + public pbc::RepeatedField GetOrInitializeExtension(pb::RepeatedExtension extension) { + return pb::ExtensionSet.GetOrInitialize(ref _extensions, extension); } public void SetExtension(pb::Extension extension, TValue value) { pb::ExtensionSet.Set(ref _extensions, extension, value); @@ -19369,8 +19369,8 @@ namespace Google.Protobuf.TestProtos.Proto2 { public pbc::RepeatedField GetExtension(pb::RepeatedExtension extension) { return pb::ExtensionSet.Get(ref _extensions, extension); } - public pbc::RepeatedField GetOrRegisterExtension(pb::RepeatedExtension extension) { - return pb::ExtensionSet.GetOrRegister(ref _extensions, extension); + public pbc::RepeatedField GetOrInitializeExtension(pb::RepeatedExtension extension) { + return pb::ExtensionSet.GetOrInitialize(ref _extensions, extension); } public void SetExtension(pb::Extension extension, TValue value) { pb::ExtensionSet.Set(ref _extensions, extension, value); @@ -19510,8 +19510,8 @@ namespace Google.Protobuf.TestProtos.Proto2 { public pbc::RepeatedField GetExtension(pb::RepeatedExtension extension) { return pb::ExtensionSet.Get(ref _extensions, extension); } - public pbc::RepeatedField GetOrRegisterExtension(pb::RepeatedExtension extension) { - return pb::ExtensionSet.GetOrRegister(ref _extensions, extension); + public pbc::RepeatedField GetOrInitializeExtension(pb::RepeatedExtension extension) { + return pb::ExtensionSet.GetOrInitialize(ref _extensions, extension); } public void SetExtension(pb::Extension extension, TValue value) { pb::ExtensionSet.Set(ref _extensions, extension, value); @@ -20586,8 +20586,8 @@ namespace Google.Protobuf.TestProtos.Proto2 { public pbc::RepeatedField GetExtension(pb::RepeatedExtension extension) { return pb::ExtensionSet.Get(ref _extensions, extension); } - public pbc::RepeatedField GetOrRegisterExtension(pb::RepeatedExtension extension) { - return pb::ExtensionSet.GetOrRegister(ref _extensions, extension); + public pbc::RepeatedField GetOrInitializeExtension(pb::RepeatedExtension extension) { + return pb::ExtensionSet.GetOrInitialize(ref _extensions, extension); } public void SetExtension(pb::Extension extension, TValue value) { pb::ExtensionSet.Set(ref _extensions, extension, value); @@ -23251,8 +23251,8 @@ namespace Google.Protobuf.TestProtos.Proto2 { public pbc::RepeatedField GetExtension(pb::RepeatedExtension extension) { return pb::ExtensionSet.Get(ref _extensions, extension); } - public pbc::RepeatedField GetOrRegisterExtension(pb::RepeatedExtension extension) { - return pb::ExtensionSet.GetOrRegister(ref _extensions, extension); + public pbc::RepeatedField GetOrInitializeExtension(pb::RepeatedExtension extension) { + return pb::ExtensionSet.GetOrInitialize(ref _extensions, extension); } public void SetExtension(pb::Extension extension, TValue value) { pb::ExtensionSet.Set(ref _extensions, extension, value); @@ -23916,8 +23916,8 @@ namespace Google.Protobuf.TestProtos.Proto2 { public pbc::RepeatedField GetExtension(pb::RepeatedExtension extension) { return pb::ExtensionSet.Get(ref _extensions, extension); } - public pbc::RepeatedField GetOrRegisterExtension(pb::RepeatedExtension extension) { - return pb::ExtensionSet.GetOrRegister(ref _extensions, extension); + public pbc::RepeatedField GetOrInitializeExtension(pb::RepeatedExtension extension) { + return pb::ExtensionSet.GetOrInitialize(ref _extensions, extension); } public void SetExtension(pb::Extension extension, TValue value) { pb::ExtensionSet.Set(ref _extensions, extension, value); diff --git a/csharp/src/Google.Protobuf/ExtensionSet.cs b/csharp/src/Google.Protobuf/ExtensionSet.cs index 5b3b3167aa..d1bbf69102 100644 --- a/csharp/src/Google.Protobuf/ExtensionSet.cs +++ b/csharp/src/Google.Protobuf/ExtensionSet.cs @@ -89,7 +89,7 @@ namespace Google.Protobuf /// /// Gets the value of the specified repeated extension, registering it if it doesn't exist /// - public static RepeatedField GetOrRegister(ref ExtensionSet set, RepeatedExtension extension) where TTarget : IExtendableMessage + public static RepeatedField GetOrInitialize(ref ExtensionSet set, RepeatedExtension extension) where TTarget : IExtendableMessage { IExtensionValue value; if (set == null) diff --git a/csharp/src/Google.Protobuf/IExtendableMessage.cs b/csharp/src/Google.Protobuf/IExtendableMessage.cs index 8857493826..8fca2b427b 100644 --- a/csharp/src/Google.Protobuf/IExtendableMessage.cs +++ b/csharp/src/Google.Protobuf/IExtendableMessage.cs @@ -35,7 +35,8 @@ using Google.Protobuf.Collections; namespace Google.Protobuf { /// - /// Generic interface for a Protocol Buffers message containing one or more extensions, where the type parameter is expected to be the same type as the implementation class + /// Generic interface for a Protocol Buffers message containing one or more extensions, where the type parameter is expected to be the same type as the implementation class. + /// This interface is experiemental and is subject to change. /// public interface IExtendableMessage : IMessage where T : IExtendableMessage { @@ -46,14 +47,14 @@ namespace Google.Protobuf /// /// Gets the value of the specified repeated extension or null if the extension isn't registered in this set. - /// For a version of this method that never returns null, use + /// For a version of this method that never returns null, use /// RepeatedField GetExtension(RepeatedExtension extension); /// /// Gets the value of the specified repeated extension, registering it if it hasn't already been registered. /// - RepeatedField GetOrRegisterExtension(RepeatedExtension extension); + RepeatedField GetOrInitializeExtension(RepeatedExtension extension); /// /// Sets the value of the specified extension diff --git a/csharp/src/Google.Protobuf/Reflection/Descriptor.cs b/csharp/src/Google.Protobuf/Reflection/Descriptor.cs index 8656cb5f87..7759a33cbc 100644 --- a/csharp/src/Google.Protobuf/Reflection/Descriptor.cs +++ b/csharp/src/Google.Protobuf/Reflection/Descriptor.cs @@ -1733,8 +1733,8 @@ namespace Google.Protobuf.Reflection { public pbc::RepeatedField GetExtension(pb::RepeatedExtension extension) { return pb::ExtensionSet.Get(ref _extensions, extension); } - public pbc::RepeatedField GetOrRegisterExtension(pb::RepeatedExtension extension) { - return pb::ExtensionSet.GetOrRegister(ref _extensions, extension); + public pbc::RepeatedField GetOrInitializeExtension(pb::RepeatedExtension extension) { + return pb::ExtensionSet.GetOrInitialize(ref _extensions, extension); } public void SetExtension(pb::Extension extension, TValue value) { pb::ExtensionSet.Set(ref _extensions, extension, value); @@ -4871,8 +4871,8 @@ namespace Google.Protobuf.Reflection { public pbc::RepeatedField GetExtension(pb::RepeatedExtension extension) { return pb::ExtensionSet.Get(ref _extensions, extension); } - public pbc::RepeatedField GetOrRegisterExtension(pb::RepeatedExtension extension) { - return pb::ExtensionSet.GetOrRegister(ref _extensions, extension); + public pbc::RepeatedField GetOrInitializeExtension(pb::RepeatedExtension extension) { + return pb::ExtensionSet.GetOrInitialize(ref _extensions, extension); } public void SetExtension(pb::Extension extension, TValue value) { pb::ExtensionSet.Set(ref _extensions, extension, value); @@ -5280,8 +5280,8 @@ namespace Google.Protobuf.Reflection { public pbc::RepeatedField GetExtension(pb::RepeatedExtension extension) { return pb::ExtensionSet.Get(ref _extensions, extension); } - public pbc::RepeatedField GetOrRegisterExtension(pb::RepeatedExtension extension) { - return pb::ExtensionSet.GetOrRegister(ref _extensions, extension); + public pbc::RepeatedField GetOrInitializeExtension(pb::RepeatedExtension extension) { + return pb::ExtensionSet.GetOrInitialize(ref _extensions, extension); } public void SetExtension(pb::Extension extension, TValue value) { pb::ExtensionSet.Set(ref _extensions, extension, value); @@ -5756,8 +5756,8 @@ namespace Google.Protobuf.Reflection { public pbc::RepeatedField GetExtension(pb::RepeatedExtension extension) { return pb::ExtensionSet.Get(ref _extensions, extension); } - public pbc::RepeatedField GetOrRegisterExtension(pb::RepeatedExtension extension) { - return pb::ExtensionSet.GetOrRegister(ref _extensions, extension); + public pbc::RepeatedField GetOrInitializeExtension(pb::RepeatedExtension extension) { + return pb::ExtensionSet.GetOrInitialize(ref _extensions, extension); } public void SetExtension(pb::Extension extension, TValue value) { pb::ExtensionSet.Set(ref _extensions, extension, value); @@ -5951,8 +5951,8 @@ namespace Google.Protobuf.Reflection { public pbc::RepeatedField GetExtension(pb::RepeatedExtension extension) { return pb::ExtensionSet.Get(ref _extensions, extension); } - public pbc::RepeatedField GetOrRegisterExtension(pb::RepeatedExtension extension) { - return pb::ExtensionSet.GetOrRegister(ref _extensions, extension); + public pbc::RepeatedField GetOrInitializeExtension(pb::RepeatedExtension extension) { + return pb::ExtensionSet.GetOrInitialize(ref _extensions, extension); } public void SetExtension(pb::Extension extension, TValue value) { pb::ExtensionSet.Set(ref _extensions, extension, value); @@ -6209,8 +6209,8 @@ namespace Google.Protobuf.Reflection { public pbc::RepeatedField GetExtension(pb::RepeatedExtension extension) { return pb::ExtensionSet.Get(ref _extensions, extension); } - public pbc::RepeatedField GetOrRegisterExtension(pb::RepeatedExtension extension) { - return pb::ExtensionSet.GetOrRegister(ref _extensions, extension); + public pbc::RepeatedField GetOrInitializeExtension(pb::RepeatedExtension extension) { + return pb::ExtensionSet.GetOrInitialize(ref _extensions, extension); } public void SetExtension(pb::Extension extension, TValue value) { pb::ExtensionSet.Set(ref _extensions, extension, value); @@ -6422,8 +6422,8 @@ namespace Google.Protobuf.Reflection { public pbc::RepeatedField GetExtension(pb::RepeatedExtension extension) { return pb::ExtensionSet.Get(ref _extensions, extension); } - public pbc::RepeatedField GetOrRegisterExtension(pb::RepeatedExtension extension) { - return pb::ExtensionSet.GetOrRegister(ref _extensions, extension); + public pbc::RepeatedField GetOrInitializeExtension(pb::RepeatedExtension extension) { + return pb::ExtensionSet.GetOrInitialize(ref _extensions, extension); } public void SetExtension(pb::Extension extension, TValue value) { pb::ExtensionSet.Set(ref _extensions, extension, value); @@ -6635,8 +6635,8 @@ namespace Google.Protobuf.Reflection { public pbc::RepeatedField GetExtension(pb::RepeatedExtension extension) { return pb::ExtensionSet.Get(ref _extensions, extension); } - public pbc::RepeatedField GetOrRegisterExtension(pb::RepeatedExtension extension) { - return pb::ExtensionSet.GetOrRegister(ref _extensions, extension); + public pbc::RepeatedField GetOrInitializeExtension(pb::RepeatedExtension extension) { + return pb::ExtensionSet.GetOrInitialize(ref _extensions, extension); } public void SetExtension(pb::Extension extension, TValue value) { pb::ExtensionSet.Set(ref _extensions, extension, value); @@ -6889,8 +6889,8 @@ namespace Google.Protobuf.Reflection { public pbc::RepeatedField GetExtension(pb::RepeatedExtension extension) { return pb::ExtensionSet.Get(ref _extensions, extension); } - public pbc::RepeatedField GetOrRegisterExtension(pb::RepeatedExtension extension) { - return pb::ExtensionSet.GetOrRegister(ref _extensions, extension); + public pbc::RepeatedField GetOrInitializeExtension(pb::RepeatedExtension extension) { + return pb::ExtensionSet.GetOrInitialize(ref _extensions, extension); } public void SetExtension(pb::Extension extension, TValue value) { pb::ExtensionSet.Set(ref _extensions, extension, value); diff --git a/csharp/src/Google.Protobuf/Reflection/ReflectionUtil.cs b/csharp/src/Google.Protobuf/Reflection/ReflectionUtil.cs index 28f724b2d8..fd1ad4e3e0 100644 --- a/csharp/src/Google.Protobuf/Reflection/ReflectionUtil.cs +++ b/csharp/src/Google.Protobuf/Reflection/ReflectionUtil.cs @@ -230,7 +230,7 @@ namespace Google.Protobuf.Reflection } else if (extension is RepeatedExtension) { - return extensionMessage.GetOrRegisterExtension(extension as RepeatedExtension); + return extensionMessage.GetOrInitializeExtension(extension as RepeatedExtension); } else { @@ -312,11 +312,11 @@ namespace Google.Protobuf.Reflection { public Func CreateIsInitializedCaller() { - var prop = typeof(T1).GetTypeInfo().GetDeclaredProperty("_Extensions"); + var prop = typeof(T1).GetTypeInfo().GetDeclaredProperty("_Extensions"); #if NET35 var getFunc = (Func>)prop.GetGetMethod(true).CreateDelegate(typeof(Func>)); #else - var getFunc = (Func>)prop.GetMethod.CreateDelegate(typeof(Func>)); + var getFunc = (Func>)prop.GetMethod.CreateDelegate(typeof(Func>)); #endif var initializedFunc = (Func, bool>) typeof(ExtensionSet) diff --git a/src/google/protobuf/compiler/csharp/csharp_message.cc b/src/google/protobuf/compiler/csharp/csharp_message.cc index e4b87dfbbe..fe2421a80e 100644 --- a/src/google/protobuf/compiler/csharp/csharp_message.cc +++ b/src/google/protobuf/compiler/csharp/csharp_message.cc @@ -272,8 +272,8 @@ void MessageGenerator::Generate(io::Printer* printer) { "public pbc::RepeatedField GetExtension(pb::RepeatedExtension<$class_name$, TValue> extension) {\n" " return pb::ExtensionSet.Get(ref _extensions, extension);\n" "}\n" - "public pbc::RepeatedField GetOrRegisterExtension(pb::RepeatedExtension<$class_name$, TValue> extension) {\n" - " return pb::ExtensionSet.GetOrRegister(ref _extensions, extension);\n" + "public pbc::RepeatedField GetOrInitializeExtension(pb::RepeatedExtension<$class_name$, TValue> extension) {\n" + " return pb::ExtensionSet.GetOrInitialize(ref _extensions, extension);\n" "}\n" "public void SetExtension(pb::Extension<$class_name$, TValue> extension, TValue value) {\n" " pb::ExtensionSet.Set(ref _extensions, extension, value);\n"