Use proto2::internal::Unreachable() to avoid control flow warnings in msvc when we have no return after an ABSL_LOG(FATAL)

PiperOrigin-RevId: 668010802

src/google/protobuf/compiler/rust/BUILD.bazel

@@ -233,6 +233,7 @@ cc_library(
     ],
     deps = [
         "//src/google/protobuf",
+        "//src/google/protobuf:port",
         "@com_google_absl//absl/log:absl_log",
     ],
 )

src/google/protobuf/compiler/rust/accessors/BUILD.bazel

@@ -35,6 +35,7 @@ cc_library(
     ],
     deps = [
         "//src/google/protobuf",
+        "//src/google/protobuf:port",
         "//src/google/protobuf/compiler/cpp:names_internal",
         "//src/google/protobuf/compiler/rust:context",
         "//src/google/protobuf/compiler/rust:naming",

src/google/protobuf/compiler/rust/accessors/accessors.cc

@@ -16,6 +16,7 @@
 #include "google/protobuf/compiler/rust/rust_field_type.h"
 #include "google/protobuf/descriptor.h"
 #include "google/protobuf/descriptor.pb.h"
+#include "google/protobuf/port.h"
 
 namespace google {
 namespace protobuf {
@@ -64,8 +65,8 @@ std::unique_ptr<AccessorGenerator> AccessorGeneratorFor(
       return std::make_unique<SingularMessage>();
   }
 
-  ABSL_LOG(FATAL) << "Unexpected field type: " << field.type();
+  ABSL_LOG(ERROR) << "Unknown field type: " << field.type();
-  return nullptr;
+  internal::Unreachable();
 }
 
 }  // namespace

src/google/protobuf/compiler/rust/accessors/default_value.cc

@@ -20,6 +20,7 @@
 #include "google/protobuf/compiler/rust/rust_field_type.h"
 #include "google/protobuf/descriptor.h"
 #include "google/protobuf/io/strtod.h"
+#include "google/protobuf/port.h"
 
 namespace google {
 namespace protobuf {
@@ -86,7 +87,8 @@ std::string DefaultValue(Context& ctx, const FieldDescriptor& field) {
     case RustFieldType::MESSAGE:
       ABSL_LOG(FATAL) << "Messages can't have defaults: " << field.type_name();
   }
-  ABSL_LOG(FATAL) << "unreachable";
+  ABSL_LOG(ERROR) << "unreachable";
+  internal::Unreachable();
 }
 
 }  // namespace rust

src/google/protobuf/compiler/rust/naming.cc

@@ -28,6 +28,7 @@
 #include "google/protobuf/compiler/rust/rust_field_type.h"
 #include "google/protobuf/compiler/rust/rust_keywords.h"
 #include "google/protobuf/descriptor.h"
+#include "google/protobuf/port.h"
 
 // Must be included last.
 #include "google/protobuf/port_def.inc"
@@ -211,8 +212,8 @@ std::string RsTypePath(Context& ctx, const FieldDescriptor& field) {
     case RustFieldType::ENUM:
       return GetFullyQualifiedPath(ctx, *field.enum_type());
   }
-  ABSL_LOG(FATAL) << "Unsupported field type: " << field.type_name();
+  ABSL_LOG(ERROR) << "Unknown field type: " << field.type_name();
-  return "";
+  internal::Unreachable();
 }
 
 std::string RsViewType(Context& ctx, const FieldDescriptor& field,
@@ -244,7 +245,7 @@ std::string RsViewType(Context& ctx, const FieldDescriptor& field,
       }
   }
   ABSL_LOG(FATAL) << "Unsupported field type: " << field.type_name();
-  return "";
+  internal::Unreachable();
 }
 
 std::string RustModuleForContainingType(Context& ctx,

src/google/protobuf/compiler/rust/rust_field_type.cc

@@ -2,6 +2,7 @@
 
 #include "absl/log/absl_log.h"
 #include "google/protobuf/descriptor.h"
+#include "google/protobuf/port.h"
 
 namespace google {
 namespace protobuf {
@@ -44,7 +45,8 @@ RustFieldType GetRustFieldType(FieldDescriptor::Type type) {
     case FieldDescriptor::TYPE_ENUM:
       return RustFieldType::ENUM;
   }
-  ABSL_LOG(FATAL) << "Unknown field type: " << type;
+  ABSL_LOG(ERROR) << "Unknown field type: " << type;
+  internal::Unreachable();
 }
 
 }  // namespace rust