|
|
|
require "rubygems"
|
|
|
|
require "rubygems/package_task"
|
|
|
|
require "rake/extensiontask" unless RUBY_PLATFORM == "java"
|
|
|
|
require "rake/testtask"
|
|
|
|
|
|
|
|
spec = Gem::Specification.load("google-protobuf.gemspec")
|
|
|
|
|
|
|
|
well_known_protos = %w[
|
|
|
|
google/protobuf/any.proto
|
|
|
|
google/protobuf/api.proto
|
|
|
|
google/protobuf/duration.proto
|
|
|
|
google/protobuf/empty.proto
|
|
|
|
google/protobuf/field_mask.proto
|
|
|
|
google/protobuf/source_context.proto
|
|
|
|
google/protobuf/struct.proto
|
|
|
|
google/protobuf/timestamp.proto
|
|
|
|
google/protobuf/type.proto
|
|
|
|
google/protobuf/wrappers.proto
|
|
|
|
]
|
|
|
|
|
|
|
|
# These are omitted for now because we don't support proto2.
|
|
|
|
proto2_protos = %w[
|
|
|
|
google/protobuf/descriptor.proto
|
|
|
|
google/protobuf/compiler/plugin.proto
|
|
|
|
]
|
|
|
|
|
|
|
|
genproto_output = []
|
|
|
|
|
|
|
|
# We won't have access to .. from within docker, but the proto files
|
|
|
|
# will be there, thanks to the :genproto rule dependency for gem:native.
|
|
|
|
unless ENV['IN_DOCKER'] == 'true'
|
|
|
|
well_known_protos.each do |proto_file|
|
|
|
|
input_file = "../src/" + proto_file
|
|
|
|
output_file = "lib/" + proto_file.sub(/\.proto$/, "_pb.rb")
|
|
|
|
genproto_output << output_file
|
|
|
|
file output_file => input_file do |file_task|
|
|
|
|
sh "../src/protoc -I../src --ruby_out=lib #{input_file}"
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
if RUBY_PLATFORM == "java"
|
|
|
|
if `which mvn` == ''
|
|
|
|
raise ArgumentError, "maven needs to be installed"
|
|
|
|
end
|
|
|
|
task :clean do
|
|
|
|
system("mvn --batch-mode clean")
|
|
|
|
end
|
|
|
|
|
|
|
|
task :compile do
|
|
|
|
system("mvn --batch-mode package")
|
|
|
|
end
|
|
|
|
else
|
Ported Ruby extension to upb_msg (#8184)
* WIP.
* WIP.
* WIP.
* WIP.
* WIP.
* WIP.
* Added some missing files.
* WIP.
* WIP.
* Updated upb.
* Extension loads, but crashes immediately.
* Gets through the test suite without SEGV!
Still a lot of bugs to fix, but it is a major step!
214 tests, 378 assertions, 37 failures, 147 errors, 0 pendings, 0 omissions, 0 notifications
14.0187% passed
* Test and build for Ruby 3.0
* Fixed a few more bugs, efficient #inspect is almost done.
214 tests, 134243 assertions, 30 failures, 144 errors, 0 pendings, 0 omissions, 0 notifications
18.6916% passed
* Fixed message hash initialization and encode depth checking.
214 tests, 124651 assertions, 53 failures, 70 errors, 0 pendings, 0 omissions, 0 notifications
42.5234% passed
* A bunch of fixes to failing tests, now 70% passing.
214 tests, 202091 assertions, 41 failures, 23 errors, 0 pendings, 0 omissions, 0 notifications
70.0935% passed
* More than 80% of tests are passing now.
214 tests, 322331 assertions, 30 failures, 9 errors, 0 pendings, 0 omissions, 0 notifications
81.7757% passed
Unfortunately there is also a sporadic bug/segfault hanging around
that appears to be GC-related.
* Add linux/ruby30 and macos/ruby30
* Use rvm master for 3.0.0-preview2
* Over 90% of tests are passing!
214 tests, 349898 assertions, 15 failures, 1 errors, 0 pendings, 0 omissions, 0 notifications
92.5234% passed
* Passes all tests!
214 tests, 369388 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed
* A bunch of cleanup.
1. Removed a bunch of internal-only symbols from headers.
2. Required a frozen check to get a non-const pointer to a map or array.
3. De-duplicated the code to get a type argument for Map/RepeatedField.
* Removed a bunch more stuff from protobuf.h. There is an intermittent assert failure.
Intermittent failure:
ruby: ../../../../ext/google/protobuf_c/protobuf.c:263: ObjectCache_Add: Assertion `rb_funcall(obj_cache2, (__builtin_constant_p("[]") ? __extension__ ({ static ID rb_intern_id_cache; if (!rb_intern_id_cache) rb_intern_id_cache = rb_intern2((("[]")
), (long)strlen(("[]"))); (ID) rb_intern_id_cache; }) : rb_intern("[]")), 1, key_rb) == val' failed
* Removed a few more things from protobuf.h.
* Ruby 3.0.0-preview2 to 3.0.0
* Require rake-compiler-dock >= 1.1.0
* More progress, fighting with the object cache.
* Passes on all Ruby versions!
* Updated and clarified comment regarding WeakMap.
* Fixed the wyhash compile.
* Fixed conformance tests for Ruby.
Conformance results now look like:
RUBYLIB=../ruby/lib:. ./conformance-test-runner --enforce_recommended --failure_list failure_list_ruby.txt --text_format_failure_list text_format_failure_list_ruby.txt ./conformance_ruby.rb
CONFORMANCE TEST BEGIN ====================================
CONFORMANCE SUITE PASSED: 1955 successes, 0 skipped, 58 expected failures, 0 unexpected failures.
CONFORMANCE TEST BEGIN ====================================
CONFORMANCE SUITE PASSED: 0 successes, 111 skipped, 8 expected failures, 0 unexpected failures.
Fixes include:
- Changed Ruby compiler to no longer reject proto2 maps.
- Changed Ruby compiler to emit a warning when proto2 extensions are
present instead of rejecting the .proto file completely.
- Fixed conformance tests to allow proto2 and look up message by name
instead of hardcoding a specific list of messages.
- Fixed conformance test to support the "ignore unknown" option for
JSON.
- Fixed conformance test to properly report serialization errors.
* Removed debug printf and fixed #inspect for floats.
* Fixed compatibility test to have proper semantics for #to_json.
* Updated Makefile.am with new file list.
* Don't try to copy wyhash when inside Docker.
* Fixed bug where we would forget that a sub-object is frozen in Ruby >=2.7.
* Avoid exporting unneeded symbols and refactored a bit of code.
* Some more refactoring.
* Simplified and added more comments.
* Some more comments and simplification. Added a missing license block.
Co-authored-by: Masaki Hara <hara@wantedly.com>
4 years ago
|
|
|
unless ENV['IN_DOCKER'] == 'true'
|
|
|
|
# We need wyhash in-tree.
|
|
|
|
FileUtils.mkdir_p("ext/google/protobuf_c/third_party/wyhash")
|
|
|
|
FileUtils.cp("../third_party/wyhash/wyhash.h", "ext/google/protobuf_c/third_party/wyhash/wyhash.h")
|
|
|
|
end
|
|
|
|
|
|
|
|
Rake::ExtensionTask.new("protobuf_c", spec) do |ext|
|
|
|
|
unless RUBY_PLATFORM =~ /darwin/
|
|
|
|
# TODO: also set "no_native to true" for mac if possible. As is,
|
|
|
|
# "no_native" can only be set if the RUBY_PLATFORM doing
|
|
|
|
# cross-compilation is contained in the "ext.cross_platform" array.
|
|
|
|
ext.no_native = true
|
|
|
|
end
|
|
|
|
ext.ext_dir = "ext/google/protobuf_c"
|
|
|
|
ext.lib_dir = "lib/google"
|
|
|
|
ext.cross_compile = true
|
|
|
|
ext.cross_platform = [
|
|
|
|
'x86-mingw32', 'x64-mingw32',
|
|
|
|
'x86_64-linux', 'x86-linux',
|
|
|
|
'universal-darwin'
|
|
|
|
]
|
|
|
|
end
|
|
|
|
|
|
|
|
task 'gem:windows' do
|
|
|
|
require 'rake_compiler_dock'
|
|
|
|
['x86-mingw32', 'x64-mingw32', 'x86_64-linux', 'x86-linux'].each do |plat|
|
|
|
|
RakeCompilerDock.sh <<-"EOT", platform: plat
|
|
|
|
bundle && \
|
Ported Ruby extension to upb_msg (#8184)
* WIP.
* WIP.
* WIP.
* WIP.
* WIP.
* WIP.
* Added some missing files.
* WIP.
* WIP.
* Updated upb.
* Extension loads, but crashes immediately.
* Gets through the test suite without SEGV!
Still a lot of bugs to fix, but it is a major step!
214 tests, 378 assertions, 37 failures, 147 errors, 0 pendings, 0 omissions, 0 notifications
14.0187% passed
* Test and build for Ruby 3.0
* Fixed a few more bugs, efficient #inspect is almost done.
214 tests, 134243 assertions, 30 failures, 144 errors, 0 pendings, 0 omissions, 0 notifications
18.6916% passed
* Fixed message hash initialization and encode depth checking.
214 tests, 124651 assertions, 53 failures, 70 errors, 0 pendings, 0 omissions, 0 notifications
42.5234% passed
* A bunch of fixes to failing tests, now 70% passing.
214 tests, 202091 assertions, 41 failures, 23 errors, 0 pendings, 0 omissions, 0 notifications
70.0935% passed
* More than 80% of tests are passing now.
214 tests, 322331 assertions, 30 failures, 9 errors, 0 pendings, 0 omissions, 0 notifications
81.7757% passed
Unfortunately there is also a sporadic bug/segfault hanging around
that appears to be GC-related.
* Add linux/ruby30 and macos/ruby30
* Use rvm master for 3.0.0-preview2
* Over 90% of tests are passing!
214 tests, 349898 assertions, 15 failures, 1 errors, 0 pendings, 0 omissions, 0 notifications
92.5234% passed
* Passes all tests!
214 tests, 369388 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed
* A bunch of cleanup.
1. Removed a bunch of internal-only symbols from headers.
2. Required a frozen check to get a non-const pointer to a map or array.
3. De-duplicated the code to get a type argument for Map/RepeatedField.
* Removed a bunch more stuff from protobuf.h. There is an intermittent assert failure.
Intermittent failure:
ruby: ../../../../ext/google/protobuf_c/protobuf.c:263: ObjectCache_Add: Assertion `rb_funcall(obj_cache2, (__builtin_constant_p("[]") ? __extension__ ({ static ID rb_intern_id_cache; if (!rb_intern_id_cache) rb_intern_id_cache = rb_intern2((("[]")
), (long)strlen(("[]"))); (ID) rb_intern_id_cache; }) : rb_intern("[]")), 1, key_rb) == val' failed
* Removed a few more things from protobuf.h.
* Ruby 3.0.0-preview2 to 3.0.0
* Require rake-compiler-dock >= 1.1.0
* More progress, fighting with the object cache.
* Passes on all Ruby versions!
* Updated and clarified comment regarding WeakMap.
* Fixed the wyhash compile.
* Fixed conformance tests for Ruby.
Conformance results now look like:
RUBYLIB=../ruby/lib:. ./conformance-test-runner --enforce_recommended --failure_list failure_list_ruby.txt --text_format_failure_list text_format_failure_list_ruby.txt ./conformance_ruby.rb
CONFORMANCE TEST BEGIN ====================================
CONFORMANCE SUITE PASSED: 1955 successes, 0 skipped, 58 expected failures, 0 unexpected failures.
CONFORMANCE TEST BEGIN ====================================
CONFORMANCE SUITE PASSED: 0 successes, 111 skipped, 8 expected failures, 0 unexpected failures.
Fixes include:
- Changed Ruby compiler to no longer reject proto2 maps.
- Changed Ruby compiler to emit a warning when proto2 extensions are
present instead of rejecting the .proto file completely.
- Fixed conformance tests to allow proto2 and look up message by name
instead of hardcoding a specific list of messages.
- Fixed conformance test to support the "ignore unknown" option for
JSON.
- Fixed conformance test to properly report serialization errors.
* Removed debug printf and fixed #inspect for floats.
* Fixed compatibility test to have proper semantics for #to_json.
* Updated Makefile.am with new file list.
* Don't try to copy wyhash when inside Docker.
* Fixed bug where we would forget that a sub-object is frozen in Ruby >=2.7.
* Avoid exporting unneeded symbols and refactored a bit of code.
* Some more refactoring.
* Simplified and added more comments.
* Some more comments and simplification. Added a missing license block.
Co-authored-by: Masaki Hara <hara@wantedly.com>
4 years ago
|
|
|
IN_DOCKER=true rake native:#{plat} pkg/#{spec.full_name}-#{plat}.gem RUBY_CC_VERSION=3.0.0:2.7.0:2.6.0:2.5.0:2.4.0:2.3.0
|
|
|
|
EOT
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
if RUBY_PLATFORM =~ /darwin/
|
|
|
|
task 'gem:native' do
|
|
|
|
system "rake genproto"
|
Ported Ruby extension to upb_msg (#8184)
* WIP.
* WIP.
* WIP.
* WIP.
* WIP.
* WIP.
* Added some missing files.
* WIP.
* WIP.
* Updated upb.
* Extension loads, but crashes immediately.
* Gets through the test suite without SEGV!
Still a lot of bugs to fix, but it is a major step!
214 tests, 378 assertions, 37 failures, 147 errors, 0 pendings, 0 omissions, 0 notifications
14.0187% passed
* Test and build for Ruby 3.0
* Fixed a few more bugs, efficient #inspect is almost done.
214 tests, 134243 assertions, 30 failures, 144 errors, 0 pendings, 0 omissions, 0 notifications
18.6916% passed
* Fixed message hash initialization and encode depth checking.
214 tests, 124651 assertions, 53 failures, 70 errors, 0 pendings, 0 omissions, 0 notifications
42.5234% passed
* A bunch of fixes to failing tests, now 70% passing.
214 tests, 202091 assertions, 41 failures, 23 errors, 0 pendings, 0 omissions, 0 notifications
70.0935% passed
* More than 80% of tests are passing now.
214 tests, 322331 assertions, 30 failures, 9 errors, 0 pendings, 0 omissions, 0 notifications
81.7757% passed
Unfortunately there is also a sporadic bug/segfault hanging around
that appears to be GC-related.
* Add linux/ruby30 and macos/ruby30
* Use rvm master for 3.0.0-preview2
* Over 90% of tests are passing!
214 tests, 349898 assertions, 15 failures, 1 errors, 0 pendings, 0 omissions, 0 notifications
92.5234% passed
* Passes all tests!
214 tests, 369388 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed
* A bunch of cleanup.
1. Removed a bunch of internal-only symbols from headers.
2. Required a frozen check to get a non-const pointer to a map or array.
3. De-duplicated the code to get a type argument for Map/RepeatedField.
* Removed a bunch more stuff from protobuf.h. There is an intermittent assert failure.
Intermittent failure:
ruby: ../../../../ext/google/protobuf_c/protobuf.c:263: ObjectCache_Add: Assertion `rb_funcall(obj_cache2, (__builtin_constant_p("[]") ? __extension__ ({ static ID rb_intern_id_cache; if (!rb_intern_id_cache) rb_intern_id_cache = rb_intern2((("[]")
), (long)strlen(("[]"))); (ID) rb_intern_id_cache; }) : rb_intern("[]")), 1, key_rb) == val' failed
* Removed a few more things from protobuf.h.
* Ruby 3.0.0-preview2 to 3.0.0
* Require rake-compiler-dock >= 1.1.0
* More progress, fighting with the object cache.
* Passes on all Ruby versions!
* Updated and clarified comment regarding WeakMap.
* Fixed the wyhash compile.
* Fixed conformance tests for Ruby.
Conformance results now look like:
RUBYLIB=../ruby/lib:. ./conformance-test-runner --enforce_recommended --failure_list failure_list_ruby.txt --text_format_failure_list text_format_failure_list_ruby.txt ./conformance_ruby.rb
CONFORMANCE TEST BEGIN ====================================
CONFORMANCE SUITE PASSED: 1955 successes, 0 skipped, 58 expected failures, 0 unexpected failures.
CONFORMANCE TEST BEGIN ====================================
CONFORMANCE SUITE PASSED: 0 successes, 111 skipped, 8 expected failures, 0 unexpected failures.
Fixes include:
- Changed Ruby compiler to no longer reject proto2 maps.
- Changed Ruby compiler to emit a warning when proto2 extensions are
present instead of rejecting the .proto file completely.
- Fixed conformance tests to allow proto2 and look up message by name
instead of hardcoding a specific list of messages.
- Fixed conformance test to support the "ignore unknown" option for
JSON.
- Fixed conformance test to properly report serialization errors.
* Removed debug printf and fixed #inspect for floats.
* Fixed compatibility test to have proper semantics for #to_json.
* Updated Makefile.am with new file list.
* Don't try to copy wyhash when inside Docker.
* Fixed bug where we would forget that a sub-object is frozen in Ruby >=2.7.
* Avoid exporting unneeded symbols and refactored a bit of code.
* Some more refactoring.
* Simplified and added more comments.
* Some more comments and simplification. Added a missing license block.
Co-authored-by: Masaki Hara <hara@wantedly.com>
4 years ago
|
|
|
system "rake cross native gem RUBY_CC_VERSION=3.0.0:2.7.0:2.6.0:2.5.1:2.4.0:2.3.0"
|
|
|
|
end
|
|
|
|
else
|
|
|
|
task 'gem:native' => [:genproto, 'gem:windows']
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
|
|
|
|
# Proto for tests.
|
|
|
|
genproto_output << "tests/generated_code.rb"
|
|
|
|
genproto_output << "tests/generated_code_proto2.rb"
|
|
|
|
genproto_output << "tests/test_import.rb"
|
|
|
|
genproto_output << "tests/test_import_proto2.rb"
|
|
|
|
genproto_output << "tests/test_ruby_package.rb"
|
|
|
|
genproto_output << "tests/test_ruby_package_proto2.rb"
|
|
|
|
genproto_output << "tests/basic_test.rb"
|
|
|
|
genproto_output << "tests/basic_test_proto2.rb"
|
|
|
|
genproto_output << "tests/multi_level_nesting_test.rb"
|
|
|
|
genproto_output << "tests/wrappers.rb"
|
|
|
|
|
|
|
|
file "tests/generated_code.rb" => "tests/generated_code.proto" do |file_task|
|
|
|
|
sh "../src/protoc --ruby_out=. tests/generated_code.proto"
|
|
|
|
end
|
|
|
|
|
|
|
|
file "tests/generated_code_proto2.rb" => "tests/generated_code_proto2.proto" do |file_task|
|
|
|
|
sh "../src/protoc --ruby_out=. tests/generated_code_proto2.proto"
|
|
|
|
end
|
|
|
|
|
|
|
|
file "tests/test_import.rb" => "tests/test_import.proto" do |file_task|
|
|
|
|
sh "../src/protoc --ruby_out=. tests/test_import.proto"
|
|
|
|
end
|
|
|
|
|
|
|
|
file "tests/test_import_proto2.rb" => "tests/test_import_proto2.proto" do |file_task|
|
|
|
|
sh "../src/protoc --ruby_out=. tests/test_import_proto2.proto"
|
|
|
|
end
|
|
|
|
|
|
|
|
file "tests/test_ruby_package.rb" => "tests/test_ruby_package.proto" do |file_task|
|
|
|
|
sh "../src/protoc --ruby_out=. tests/test_ruby_package.proto"
|
|
|
|
end
|
|
|
|
|
|
|
|
file "tests/test_ruby_package_proto2.rb" => "tests/test_ruby_package_proto2.proto" do |file_task|
|
|
|
|
sh "../src/protoc --ruby_out=. tests/test_ruby_package_proto2.proto"
|
|
|
|
end
|
|
|
|
|
|
|
|
file "tests/basic_test.rb" => "tests/basic_test.proto" do |file_task|
|
|
|
|
sh "../src/protoc --experimental_allow_proto3_optional -I../src -I. --ruby_out=. tests/basic_test.proto"
|
|
|
|
end
|
|
|
|
|
|
|
|
file "tests/basic_test_proto2.rb" => "tests/basic_test_proto2.proto" do |file_task|
|
|
|
|
sh "../src/protoc -I../src -I. --ruby_out=. tests/basic_test_proto2.proto"
|
|
|
|
end
|
|
|
|
|
|
|
|
file "tests/multi_level_nesting_test.rb" => "tests/multi_level_nesting_test.proto" do |file_task|
|
|
|
|
sh "../src/protoc -I../src -I. --ruby_out=. tests/multi_level_nesting_test.proto"
|
|
|
|
end
|
|
|
|
|
|
|
|
file "tests/wrappers.rb" => "../src/google/protobuf/wrappers.proto" do |file_task|
|
|
|
|
sh "../src/protoc -I../src -I. --ruby_out=tests ../src/google/protobuf/wrappers.proto"
|
|
|
|
end
|
|
|
|
|
|
|
|
task :genproto => genproto_output
|
|
|
|
|
|
|
|
task :clean do
|
|
|
|
sh "rm -f #{genproto_output.join(' ')}"
|
|
|
|
end
|
|
|
|
|
|
|
|
Gem::PackageTask.new(spec) do |pkg|
|
|
|
|
end
|
|
|
|
|
|
|
|
Rake::TestTask.new(:test => :build) do |t|
|
|
|
|
t.test_files = FileList["tests/*.rb"].exclude("tests/gc_test.rb", "tests/common_tests.rb")
|
|
|
|
end
|
|
|
|
|
|
|
|
# gc_test needs to be split out to ensure the generated file hasn't been
|
|
|
|
# imported by other tests.
|
|
|
|
Rake::TestTask.new(:gc_test => :build) do |t|
|
|
|
|
t.test_files = FileList["tests/gc_test.rb"]
|
|
|
|
end
|
|
|
|
|
|
|
|
task :build => [:clean, :compile, :genproto]
|
|
|
|
task :default => [:build]
|
|
|
|
|
|
|
|
# vim:sw=2:et
|