|
|
|
# Copyright (c) 2009-2021, Google LLC
|
|
|
|
# All rights reserved.
|
|
|
|
#
|
|
|
|
# Redistribution and use in source and binary forms, with or without
|
|
|
|
# modification, are permitted provided that the following conditions are met:
|
|
|
|
# * Redistributions of source code must retain the above copyright
|
|
|
|
# notice, this list of conditions and the following disclaimer.
|
|
|
|
# * Redistributions in binary form must reproduce the above copyright
|
|
|
|
# notice, this list of conditions and the following disclaimer in the
|
|
|
|
# documentation and/or other materials provided with the distribution.
|
|
|
|
# * Neither the name of Google LLC nor the
|
|
|
|
# names of its contributors may be used to endorse or promote products
|
|
|
|
# derived from this software without specific prior written permission.
|
|
|
|
#
|
|
|
|
# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND
|
|
|
|
# ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
|
|
|
|
# WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
|
|
|
|
# DISCLAIMED. IN NO EVENT SHALL Google LLC BE LIABLE FOR ANY
|
|
|
|
# DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
|
|
|
|
# (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
|
|
|
|
# LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
|
|
|
|
# ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
|
|
|
|
# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
|
|
|
|
# SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
|
|
|
|
|
|
|
|
"""Public rules for using upb protos:
|
|
|
|
- upb_proto_library()
|
|
|
|
- upb_proto_reflection_library()
|
|
|
|
"""
|
|
|
|
|
|
|
|
load("@bazel_skylib//lib:paths.bzl", "paths")
|
|
|
|
|
|
|
|
# begin:google_only
|
|
|
|
# load("@bazel_tools//tools/cpp:toolchain_utils.bzl", "find_cpp_toolchain", "use_cpp_toolchain")
|
|
|
|
# end:google_only
|
|
|
|
|
|
|
|
# begin:github_only
|
|
|
|
# Compatibility code for Bazel 4.x. Remove this when we drop support for Bazel 4.x.
|
|
|
|
load("@bazel_tools//tools/cpp:toolchain_utils.bzl", "find_cpp_toolchain")
|
|
|
|
|
|
|
|
def use_cpp_toolchain():
|
|
|
|
return ["@bazel_tools//tools/cpp:toolchain_type"]
|
|
|
|
# end:github_only
|
|
|
|
|
|
|
|
# Generic support code #########################################################
|
|
|
|
|
|
|
|
# begin:github_only
|
|
|
|
_is_google3 = False
|
|
|
|
# end:github_only
|
|
|
|
|
|
|
|
# begin:google_only
|
|
|
|
# _is_google3 = True
|
|
|
|
# end:google_only
|
|
|
|
|
|
|
|
def _get_real_short_path(file):
|
|
|
|
# For some reason, files from other archives have short paths that look like:
|
|
|
|
# ../com_google_protobuf/google/protobuf/descriptor.proto
|
|
|
|
short_path = file.short_path
|
|
|
|
if short_path.startswith("../"):
|
|
|
|
second_slash = short_path.index("/", 3)
|
|
|
|
short_path = short_path[second_slash + 1:]
|
|
|
|
|
|
|
|
# Sometimes it has another few prefixes like:
|
|
|
|
# _virtual_imports/any_proto/google/protobuf/any.proto
|
|
|
|
# benchmarks/_virtual_imports/100_msgs_proto/benchmarks/100_msgs.proto
|
|
|
|
# We want just google/protobuf/any.proto.
|
|
|
|
virtual_imports = "_virtual_imports/"
|
|
|
|
if virtual_imports in short_path:
|
|
|
|
short_path = short_path.split(virtual_imports)[1].split("/", 1)[1]
|
|
|
|
return short_path
|
|
|
|
|
|
|
|
def _get_real_root(ctx, file):
|
|
|
|
real_short_path = _get_real_short_path(file)
|
|
|
|
root = file.path[:-len(real_short_path) - 1]
|
|
|
|
|
|
|
|
if not _is_google3 and ctx.rule.attr.strip_import_prefix:
|
|
|
|
root = paths.join(root, ctx.rule.attr.strip_import_prefix[1:])
|
|
|
|
return root
|
|
|
|
|
|
|
|
def _generate_output_file(ctx, src, extension):
|
|
|
|
package = ctx.label.package
|
|
|
|
if not _is_google3:
|
|
|
|
strip_import_prefix = ctx.rule.attr.strip_import_prefix
|
|
|
|
if strip_import_prefix and strip_import_prefix != "/":
|
|
|
|
if not package.startswith(strip_import_prefix[1:]):
|
|
|
|
fail("%s does not begin with prefix %s" % (package, strip_import_prefix))
|
|
|
|
package = package[len(strip_import_prefix):]
|
|
|
|
|
|
|
|
real_short_path = _get_real_short_path(src)
|
|
|
|
real_short_path = paths.relativize(real_short_path, package)
|
|
|
|
output_filename = paths.replace_extension(real_short_path, extension)
|
|
|
|
ret = ctx.actions.declare_file(output_filename)
|
|
|
|
return ret
|
|
|
|
|
|
|
|
def _generate_include_path(src, out, extension):
|
|
|
|
short_path = _get_real_short_path(src)
|
|
|
|
short_path = paths.replace_extension(short_path, extension)
|
|
|
|
if not out.path.endswith(short_path):
|
|
|
|
fail("%s does not end with %s" % (out.path, short_path))
|
|
|
|
|
|
|
|
return out.path[:-len(short_path)]
|
|
|
|
|
|
|
|
def _filter_none(elems):
|
|
|
|
out = []
|
|
|
|
for elem in elems:
|
|
|
|
if elem:
|
|
|
|
out.append(elem)
|
|
|
|
return out
|
|
|
|
|
|
|
|
def _cc_library_func(ctx, name, hdrs, srcs, copts, includes, dep_ccinfos):
|
|
|
|
"""Like cc_library(), but callable from rules.
|
|
|
|
|
|
|
|
Args:
|
|
|
|
ctx: Rule context.
|
|
|
|
name: Unique name used to generate output files.
|
|
|
|
hdrs: Public headers that can be #included from other rules.
|
|
|
|
srcs: C/C++ source files.
|
|
|
|
copts: Additional options for cc compilation.
|
|
|
|
includes: Additional include paths.
|
|
|
|
dep_ccinfos: CcInfo providers of dependencies we should build/link against.
|
|
|
|
|
|
|
|
Returns:
|
|
|
|
CcInfo provider for this compilation.
|
|
|
|
"""
|
|
|
|
|
|
|
|
compilation_contexts = [info.compilation_context for info in dep_ccinfos]
|
|
|
|
linking_contexts = [info.linking_context for info in dep_ccinfos]
|
|
|
|
toolchain = find_cpp_toolchain(ctx)
|
|
|
|
feature_configuration = cc_common.configure_features(
|
|
|
|
ctx = ctx,
|
|
|
|
cc_toolchain = toolchain,
|
|
|
|
requested_features = ctx.features,
|
|
|
|
unsupported_features = ctx.disabled_features,
|
|
|
|
)
|
|
|
|
|
|
|
|
blaze_only_args = {}
|
|
|
|
|
|
|
|
if _is_google3:
|
|
|
|
blaze_only_args["grep_includes"] = ctx.file._grep_includes
|
|
|
|
|
|
|
|
(compilation_context, compilation_outputs) = cc_common.compile(
|
|
|
|
actions = ctx.actions,
|
|
|
|
feature_configuration = feature_configuration,
|
|
|
|
cc_toolchain = toolchain,
|
|
|
|
name = name,
|
|
|
|
srcs = srcs,
|
|
|
|
includes = includes,
|
|
|
|
public_hdrs = hdrs,
|
|
|
|
user_compile_flags = copts,
|
|
|
|
compilation_contexts = compilation_contexts,
|
|
|
|
**blaze_only_args
|
|
|
|
)
|
|
|
|
|
|
|
|
# buildifier: disable=unused-variable
|
|
|
|
(linking_context, linking_outputs) = cc_common.create_linking_context_from_compilation_outputs(
|
|
|
|
actions = ctx.actions,
|
|
|
|
name = name,
|
|
|
|
feature_configuration = feature_configuration,
|
|
|
|
cc_toolchain = toolchain,
|
|
|
|
compilation_outputs = compilation_outputs,
|
|
|
|
linking_contexts = linking_contexts,
|
|
|
|
**blaze_only_args
|
|
|
|
)
|
|
|
|
|
|
|
|
return CcInfo(
|
|
|
|
compilation_context = compilation_context,
|
|
|
|
linking_context = linking_context,
|
|
|
|
)
|
|
|
|
|
Added a codegen parameter for whether fasttables are generated or not.
Example:
$ CC=clang bazel build -c opt --copt=-g benchmarks:benchmark --//:fasttable_enabled=false
INFO: Build option --//:fasttable_enabled has changed, discarding analysis cache.
INFO: Analyzed target //benchmarks:benchmark (0 packages loaded, 913 targets configured).
INFO: Found 1 target...
Target //benchmarks:benchmark up-to-date:
bazel-bin/benchmarks/benchmark
INFO: Elapsed time: 0.760s, Critical Path: 0.58s
INFO: 7 processes: 1 internal, 6 linux-sandbox.
INFO: Build completed successfully, 7 total actions
$ bazel-bin/benchmarks/benchmark --benchmark_filter=BM_Parse_Upb
------------------------------------------------------------------------------
Benchmark Time CPU Iterations
------------------------------------------------------------------------------
BM_Parse_Upb_FileDesc_WithArena 10985 ns 10984 ns 63567 651.857MB/s
BM_Parse_Upb_FileDesc_WithInitialBlock 10556 ns 10554 ns 66138 678.458MB/s
$ CC=clang bazel build -c opt --copt=-g benchmarks:benchmark --//:fasttable_enabled=true
INFO: Build option --//:fasttable_enabled has changed, discarding analysis cache.
INFO: Analyzed target //benchmarks:benchmark (0 packages loaded, 913 targets configured).
INFO: Found 1 target...
Target //benchmarks:benchmark up-to-date:
bazel-bin/benchmarks/benchmark
INFO: Elapsed time: 0.744s, Critical Path: 0.58s
INFO: 7 processes: 1 internal, 6 linux-sandbox.
INFO: Build completed successfully, 7 total actions
$ bazel-bin/benchmarks/benchmark --benchmark_filter=BM_Parse_Upb
------------------------------------------------------------------------------
Benchmark Time CPU Iterations
------------------------------------------------------------------------------
BM_Parse_Upb_FileDesc_WithArena 3284 ns 3284 ns 213495 2.1293GB/s
BM_Parse_Upb_FileDesc_WithInitialBlock 2882 ns 2882 ns 243069 2.4262GB/s
Biggest unknown is whether this parameter should default to true or false.
4 years ago
|
|
|
# Build setting for whether fasttable code generation is enabled ###############
|
|
|
|
|
|
|
|
_FastTableEnabledInfo = provider(
|
|
|
|
"Provides fasttable configuration",
|
Added a codegen parameter for whether fasttables are generated or not.
Example:
$ CC=clang bazel build -c opt --copt=-g benchmarks:benchmark --//:fasttable_enabled=false
INFO: Build option --//:fasttable_enabled has changed, discarding analysis cache.
INFO: Analyzed target //benchmarks:benchmark (0 packages loaded, 913 targets configured).
INFO: Found 1 target...
Target //benchmarks:benchmark up-to-date:
bazel-bin/benchmarks/benchmark
INFO: Elapsed time: 0.760s, Critical Path: 0.58s
INFO: 7 processes: 1 internal, 6 linux-sandbox.
INFO: Build completed successfully, 7 total actions
$ bazel-bin/benchmarks/benchmark --benchmark_filter=BM_Parse_Upb
------------------------------------------------------------------------------
Benchmark Time CPU Iterations
------------------------------------------------------------------------------
BM_Parse_Upb_FileDesc_WithArena 10985 ns 10984 ns 63567 651.857MB/s
BM_Parse_Upb_FileDesc_WithInitialBlock 10556 ns 10554 ns 66138 678.458MB/s
$ CC=clang bazel build -c opt --copt=-g benchmarks:benchmark --//:fasttable_enabled=true
INFO: Build option --//:fasttable_enabled has changed, discarding analysis cache.
INFO: Analyzed target //benchmarks:benchmark (0 packages loaded, 913 targets configured).
INFO: Found 1 target...
Target //benchmarks:benchmark up-to-date:
bazel-bin/benchmarks/benchmark
INFO: Elapsed time: 0.744s, Critical Path: 0.58s
INFO: 7 processes: 1 internal, 6 linux-sandbox.
INFO: Build completed successfully, 7 total actions
$ bazel-bin/benchmarks/benchmark --benchmark_filter=BM_Parse_Upb
------------------------------------------------------------------------------
Benchmark Time CPU Iterations
------------------------------------------------------------------------------
BM_Parse_Upb_FileDesc_WithArena 3284 ns 3284 ns 213495 2.1293GB/s
BM_Parse_Upb_FileDesc_WithInitialBlock 2882 ns 2882 ns 243069 2.4262GB/s
Biggest unknown is whether this parameter should default to true or false.
4 years ago
|
|
|
fields = {
|
|
|
|
"enabled": "whether fasttable is enabled",
|
|
|
|
},
|
|
|
|
)
|
|
|
|
|
|
|
|
def fasttable_enabled_impl(ctx):
|
|
|
|
raw_setting = ctx.build_setting_value
|
|
|
|
|
|
|
|
if raw_setting:
|
|
|
|
# TODO(haberman): check that the target CPU supports fasttable.
|
|
|
|
pass
|
Added a codegen parameter for whether fasttables are generated or not.
Example:
$ CC=clang bazel build -c opt --copt=-g benchmarks:benchmark --//:fasttable_enabled=false
INFO: Build option --//:fasttable_enabled has changed, discarding analysis cache.
INFO: Analyzed target //benchmarks:benchmark (0 packages loaded, 913 targets configured).
INFO: Found 1 target...
Target //benchmarks:benchmark up-to-date:
bazel-bin/benchmarks/benchmark
INFO: Elapsed time: 0.760s, Critical Path: 0.58s
INFO: 7 processes: 1 internal, 6 linux-sandbox.
INFO: Build completed successfully, 7 total actions
$ bazel-bin/benchmarks/benchmark --benchmark_filter=BM_Parse_Upb
------------------------------------------------------------------------------
Benchmark Time CPU Iterations
------------------------------------------------------------------------------
BM_Parse_Upb_FileDesc_WithArena 10985 ns 10984 ns 63567 651.857MB/s
BM_Parse_Upb_FileDesc_WithInitialBlock 10556 ns 10554 ns 66138 678.458MB/s
$ CC=clang bazel build -c opt --copt=-g benchmarks:benchmark --//:fasttable_enabled=true
INFO: Build option --//:fasttable_enabled has changed, discarding analysis cache.
INFO: Analyzed target //benchmarks:benchmark (0 packages loaded, 913 targets configured).
INFO: Found 1 target...
Target //benchmarks:benchmark up-to-date:
bazel-bin/benchmarks/benchmark
INFO: Elapsed time: 0.744s, Critical Path: 0.58s
INFO: 7 processes: 1 internal, 6 linux-sandbox.
INFO: Build completed successfully, 7 total actions
$ bazel-bin/benchmarks/benchmark --benchmark_filter=BM_Parse_Upb
------------------------------------------------------------------------------
Benchmark Time CPU Iterations
------------------------------------------------------------------------------
BM_Parse_Upb_FileDesc_WithArena 3284 ns 3284 ns 213495 2.1293GB/s
BM_Parse_Upb_FileDesc_WithInitialBlock 2882 ns 2882 ns 243069 2.4262GB/s
Biggest unknown is whether this parameter should default to true or false.
4 years ago
|
|
|
|
|
|
|
return _FastTableEnabledInfo(enabled = raw_setting)
|
Added a codegen parameter for whether fasttables are generated or not.
Example:
$ CC=clang bazel build -c opt --copt=-g benchmarks:benchmark --//:fasttable_enabled=false
INFO: Build option --//:fasttable_enabled has changed, discarding analysis cache.
INFO: Analyzed target //benchmarks:benchmark (0 packages loaded, 913 targets configured).
INFO: Found 1 target...
Target //benchmarks:benchmark up-to-date:
bazel-bin/benchmarks/benchmark
INFO: Elapsed time: 0.760s, Critical Path: 0.58s
INFO: 7 processes: 1 internal, 6 linux-sandbox.
INFO: Build completed successfully, 7 total actions
$ bazel-bin/benchmarks/benchmark --benchmark_filter=BM_Parse_Upb
------------------------------------------------------------------------------
Benchmark Time CPU Iterations
------------------------------------------------------------------------------
BM_Parse_Upb_FileDesc_WithArena 10985 ns 10984 ns 63567 651.857MB/s
BM_Parse_Upb_FileDesc_WithInitialBlock 10556 ns 10554 ns 66138 678.458MB/s
$ CC=clang bazel build -c opt --copt=-g benchmarks:benchmark --//:fasttable_enabled=true
INFO: Build option --//:fasttable_enabled has changed, discarding analysis cache.
INFO: Analyzed target //benchmarks:benchmark (0 packages loaded, 913 targets configured).
INFO: Found 1 target...
Target //benchmarks:benchmark up-to-date:
bazel-bin/benchmarks/benchmark
INFO: Elapsed time: 0.744s, Critical Path: 0.58s
INFO: 7 processes: 1 internal, 6 linux-sandbox.
INFO: Build completed successfully, 7 total actions
$ bazel-bin/benchmarks/benchmark --benchmark_filter=BM_Parse_Upb
------------------------------------------------------------------------------
Benchmark Time CPU Iterations
------------------------------------------------------------------------------
BM_Parse_Upb_FileDesc_WithArena 3284 ns 3284 ns 213495 2.1293GB/s
BM_Parse_Upb_FileDesc_WithInitialBlock 2882 ns 2882 ns 243069 2.4262GB/s
Biggest unknown is whether this parameter should default to true or false.
4 years ago
|
|
|
|
|
|
|
upb_fasttable_enabled = rule(
|
|
|
|
implementation = fasttable_enabled_impl,
|
|
|
|
build_setting = config.bool(flag = True),
|
Added a codegen parameter for whether fasttables are generated or not.
Example:
$ CC=clang bazel build -c opt --copt=-g benchmarks:benchmark --//:fasttable_enabled=false
INFO: Build option --//:fasttable_enabled has changed, discarding analysis cache.
INFO: Analyzed target //benchmarks:benchmark (0 packages loaded, 913 targets configured).
INFO: Found 1 target...
Target //benchmarks:benchmark up-to-date:
bazel-bin/benchmarks/benchmark
INFO: Elapsed time: 0.760s, Critical Path: 0.58s
INFO: 7 processes: 1 internal, 6 linux-sandbox.
INFO: Build completed successfully, 7 total actions
$ bazel-bin/benchmarks/benchmark --benchmark_filter=BM_Parse_Upb
------------------------------------------------------------------------------
Benchmark Time CPU Iterations
------------------------------------------------------------------------------
BM_Parse_Upb_FileDesc_WithArena 10985 ns 10984 ns 63567 651.857MB/s
BM_Parse_Upb_FileDesc_WithInitialBlock 10556 ns 10554 ns 66138 678.458MB/s
$ CC=clang bazel build -c opt --copt=-g benchmarks:benchmark --//:fasttable_enabled=true
INFO: Build option --//:fasttable_enabled has changed, discarding analysis cache.
INFO: Analyzed target //benchmarks:benchmark (0 packages loaded, 913 targets configured).
INFO: Found 1 target...
Target //benchmarks:benchmark up-to-date:
bazel-bin/benchmarks/benchmark
INFO: Elapsed time: 0.744s, Critical Path: 0.58s
INFO: 7 processes: 1 internal, 6 linux-sandbox.
INFO: Build completed successfully, 7 total actions
$ bazel-bin/benchmarks/benchmark --benchmark_filter=BM_Parse_Upb
------------------------------------------------------------------------------
Benchmark Time CPU Iterations
------------------------------------------------------------------------------
BM_Parse_Upb_FileDesc_WithArena 3284 ns 3284 ns 213495 2.1293GB/s
BM_Parse_Upb_FileDesc_WithInitialBlock 2882 ns 2882 ns 243069 2.4262GB/s
Biggest unknown is whether this parameter should default to true or false.
4 years ago
|
|
|
)
|
|
|
|
|
|
|
|
# Dummy rule to expose select() copts to aspects ##############################
|
|
|
|
|
|
|
|
UpbProtoLibraryCoptsInfo = provider(
|
|
|
|
"Provides copts for upb proto targets",
|
|
|
|
fields = {
|
|
|
|
"copts": "copts for upb_proto_library()",
|
|
|
|
},
|
|
|
|
)
|
|
|
|
|
|
|
|
def upb_proto_library_copts_impl(ctx):
|
|
|
|
return UpbProtoLibraryCoptsInfo(copts = ctx.attr.copts)
|
|
|
|
|
|
|
|
upb_proto_library_copts = rule(
|
|
|
|
implementation = upb_proto_library_copts_impl,
|
|
|
|
attrs = {"copts": attr.string_list(default = [])},
|
|
|
|
)
|
|
|
|
|
|
|
|
# upb_proto_library / upb_proto_reflection_library shared code #################
|
|
|
|
|
|
|
|
GeneratedSrcsInfo = provider(
|
|
|
|
"Provides generated headers and sources",
|
|
|
|
fields = {
|
|
|
|
"srcs": "list of srcs",
|
|
|
|
"hdrs": "list of hdrs",
|
|
|
|
"includes": "list of extra includes",
|
|
|
|
},
|
|
|
|
)
|
|
|
|
|
|
|
|
UpbWrappedCcInfo = provider("Provider for cc_info for protos", fields = ["cc_info"])
|
|
|
|
_UpbDefsWrappedCcInfo = provider("Provider for cc_info for protos", fields = ["cc_info"])
|
|
|
|
UpbWrappedGeneratedSrcsInfo = provider("Provider for generated sources", fields = ["srcs"])
|
|
|
|
_WrappedDefsGeneratedSrcsInfo = provider(
|
|
|
|
"Provider for generated reflective sources",
|
|
|
|
fields = ["srcs"],
|
|
|
|
)
|
|
|
|
|
|
|
|
def _compile_upb_protos(ctx, generator, proto_info, proto_sources):
|
|
|
|
if len(proto_sources) == 0:
|
|
|
|
return GeneratedSrcsInfo(srcs = [], hdrs = [])
|
|
|
|
|
|
|
|
ext = "." + generator
|
|
|
|
tool = getattr(ctx.executable, "_gen_" + generator)
|
|
|
|
srcs = [_generate_output_file(ctx, name, ext + ".c") for name in proto_sources]
|
|
|
|
hdrs = [_generate_output_file(ctx, name, ext + ".h") for name in proto_sources]
|
|
|
|
transitive_sets = proto_info.transitive_descriptor_sets.to_list()
|
|
|
|
fasttable_enabled = (hasattr(ctx.attr, "_fasttable_enabled") and
|
|
|
|
ctx.attr._fasttable_enabled[_FastTableEnabledInfo].enabled)
|
Added a codegen parameter for whether fasttables are generated or not.
Example:
$ CC=clang bazel build -c opt --copt=-g benchmarks:benchmark --//:fasttable_enabled=false
INFO: Build option --//:fasttable_enabled has changed, discarding analysis cache.
INFO: Analyzed target //benchmarks:benchmark (0 packages loaded, 913 targets configured).
INFO: Found 1 target...
Target //benchmarks:benchmark up-to-date:
bazel-bin/benchmarks/benchmark
INFO: Elapsed time: 0.760s, Critical Path: 0.58s
INFO: 7 processes: 1 internal, 6 linux-sandbox.
INFO: Build completed successfully, 7 total actions
$ bazel-bin/benchmarks/benchmark --benchmark_filter=BM_Parse_Upb
------------------------------------------------------------------------------
Benchmark Time CPU Iterations
------------------------------------------------------------------------------
BM_Parse_Upb_FileDesc_WithArena 10985 ns 10984 ns 63567 651.857MB/s
BM_Parse_Upb_FileDesc_WithInitialBlock 10556 ns 10554 ns 66138 678.458MB/s
$ CC=clang bazel build -c opt --copt=-g benchmarks:benchmark --//:fasttable_enabled=true
INFO: Build option --//:fasttable_enabled has changed, discarding analysis cache.
INFO: Analyzed target //benchmarks:benchmark (0 packages loaded, 913 targets configured).
INFO: Found 1 target...
Target //benchmarks:benchmark up-to-date:
bazel-bin/benchmarks/benchmark
INFO: Elapsed time: 0.744s, Critical Path: 0.58s
INFO: 7 processes: 1 internal, 6 linux-sandbox.
INFO: Build completed successfully, 7 total actions
$ bazel-bin/benchmarks/benchmark --benchmark_filter=BM_Parse_Upb
------------------------------------------------------------------------------
Benchmark Time CPU Iterations
------------------------------------------------------------------------------
BM_Parse_Upb_FileDesc_WithArena 3284 ns 3284 ns 213495 2.1293GB/s
BM_Parse_Upb_FileDesc_WithInitialBlock 2882 ns 2882 ns 243069 2.4262GB/s
Biggest unknown is whether this parameter should default to true or false.
4 years ago
|
|
|
codegen_params = "fasttable:" if fasttable_enabled else ""
|
|
|
|
ctx.actions.run(
|
|
|
|
inputs = depset(
|
|
|
|
direct = [proto_info.direct_descriptor_set],
|
|
|
|
transitive = [proto_info.transitive_descriptor_sets],
|
|
|
|
),
|
|
|
|
tools = [tool],
|
|
|
|
outputs = srcs + hdrs,
|
|
|
|
executable = ctx.executable._protoc,
|
|
|
|
arguments = [
|
|
|
|
"--" + generator + "_out=" + codegen_params + _get_real_root(ctx, srcs[0]),
|
|
|
|
"--plugin=protoc-gen-" + generator + "=" + tool.path,
|
|
|
|
"--descriptor_set_in=" + ctx.configuration.host_path_separator.join([f.path for f in transitive_sets]),
|
|
|
|
] +
|
|
|
|
[_get_real_short_path(file) for file in proto_sources],
|
|
|
|
progress_message = "Generating upb protos for :" + ctx.label.name,
|
|
|
|
mnemonic = "GenUpbProtos",
|
|
|
|
)
|
|
|
|
return GeneratedSrcsInfo(
|
|
|
|
srcs = srcs,
|
|
|
|
hdrs = hdrs,
|
|
|
|
includes = [_generate_include_path(proto_sources[0], hdrs[0], ext + ".h")],
|
|
|
|
)
|
|
|
|
|
|
|
|
def _upb_proto_rule_impl(ctx):
|
|
|
|
if len(ctx.attr.deps) != 1:
|
|
|
|
fail("only one deps dependency allowed.")
|
|
|
|
dep = ctx.attr.deps[0]
|
|
|
|
|
|
|
|
if _WrappedDefsGeneratedSrcsInfo in dep:
|
|
|
|
srcs = dep[_WrappedDefsGeneratedSrcsInfo].srcs
|
|
|
|
elif UpbWrappedGeneratedSrcsInfo in dep:
|
|
|
|
srcs = dep[UpbWrappedGeneratedSrcsInfo].srcs
|
|
|
|
else:
|
|
|
|
fail("proto_library rule must generate UpbWrappedGeneratedSrcsInfo or " +
|
|
|
|
"_WrappedDefsGeneratedSrcsInfo (aspect should have handled this).")
|
|
|
|
|
|
|
|
if _UpbDefsWrappedCcInfo in dep:
|
|
|
|
cc_info = dep[_UpbDefsWrappedCcInfo].cc_info
|
|
|
|
elif UpbWrappedCcInfo in dep:
|
|
|
|
cc_info = dep[UpbWrappedCcInfo].cc_info
|
|
|
|
else:
|
|
|
|
fail("proto_library rule must generate UpbWrappedCcInfo or " +
|
|
|
|
"_UpbDefsWrappedCcInfo (aspect should have handled this).")
|
|
|
|
|
|
|
|
lib = cc_info.linking_context.linker_inputs.to_list()[0].libraries[0]
|
|
|
|
files = _filter_none([
|
|
|
|
lib.static_library,
|
|
|
|
lib.pic_static_library,
|
|
|
|
lib.dynamic_library,
|
|
|
|
])
|
|
|
|
return [
|
|
|
|
DefaultInfo(files = depset(files + srcs.hdrs + srcs.srcs)),
|
|
|
|
srcs,
|
|
|
|
cc_info,
|
|
|
|
]
|
|
|
|
|
|
|
|
def _upb_proto_aspect_impl(target, ctx, generator, cc_provider, file_provider):
|
|
|
|
proto_info = target[ProtoInfo]
|
|
|
|
files = _compile_upb_protos(ctx, generator, proto_info, proto_info.direct_sources)
|
|
|
|
deps = ctx.rule.attr.deps + getattr(ctx.attr, "_" + generator)
|
|
|
|
dep_ccinfos = [dep[CcInfo] for dep in deps if CcInfo in dep]
|
|
|
|
dep_ccinfos += [dep[UpbWrappedCcInfo].cc_info for dep in deps if UpbWrappedCcInfo in dep]
|
|
|
|
dep_ccinfos += [dep[_UpbDefsWrappedCcInfo].cc_info for dep in deps if _UpbDefsWrappedCcInfo in dep]
|
|
|
|
if generator == "upbdefs":
|
|
|
|
if UpbWrappedCcInfo not in target:
|
|
|
|
fail("Target should have UpbWrappedCcInfo provider")
|
|
|
|
dep_ccinfos.append(target[UpbWrappedCcInfo].cc_info)
|
|
|
|
cc_info = _cc_library_func(
|
|
|
|
ctx = ctx,
|
|
|
|
name = ctx.rule.attr.name + "." + generator,
|
|
|
|
hdrs = files.hdrs,
|
|
|
|
srcs = files.srcs,
|
|
|
|
includes = files.includes,
|
|
|
|
copts = ctx.attr._copts[UpbProtoLibraryCoptsInfo].copts,
|
|
|
|
dep_ccinfos = dep_ccinfos,
|
|
|
|
)
|
|
|
|
return [cc_provider(cc_info = cc_info), file_provider(srcs = files)]
|
|
|
|
|
|
|
|
def upb_proto_library_aspect_impl(target, ctx):
|
|
|
|
return _upb_proto_aspect_impl(target, ctx, "upb", UpbWrappedCcInfo, UpbWrappedGeneratedSrcsInfo)
|
|
|
|
|
|
|
|
def _upb_proto_reflection_library_aspect_impl(target, ctx):
|
|
|
|
return _upb_proto_aspect_impl(target, ctx, "upbdefs", _UpbDefsWrappedCcInfo, _WrappedDefsGeneratedSrcsInfo)
|
|
|
|
|
|
|
|
def _maybe_add(d):
|
|
|
|
if _is_google3:
|
|
|
|
d["_grep_includes"] = attr.label(
|
|
|
|
allow_single_file = True,
|
|
|
|
cfg = "exec",
|
|
|
|
default = "@bazel_tools//tools/cpp:grep-includes",
|
|
|
|
)
|
|
|
|
return d
|
|
|
|
|
|
|
|
# upb_proto_library() ##########################################################
|
|
|
|
|
|
|
|
upb_proto_library_aspect = aspect(
|
|
|
|
attrs = _maybe_add({
|
|
|
|
"_copts": attr.label(
|
|
|
|
default = "//:upb_proto_library_copts__for_generated_code_only_do_not_use",
|
|
|
|
),
|
|
|
|
"_gen_upb": attr.label(
|
|
|
|
executable = True,
|
|
|
|
cfg = "exec",
|
|
|
|
default = "//upbc:protoc-gen-upb",
|
|
|
|
),
|
|
|
|
"_protoc": attr.label(
|
|
|
|
executable = True,
|
|
|
|
cfg = "exec",
|
|
|
|
default = "@com_google_protobuf//:protoc",
|
|
|
|
),
|
|
|
|
"_cc_toolchain": attr.label(
|
|
|
|
default = "@bazel_tools//tools/cpp:current_cc_toolchain",
|
|
|
|
),
|
|
|
|
"_upb": attr.label_list(default = [
|
|
|
|
"//:generated_code_support__only_for_generated_code_do_not_use__i_give_permission_to_break_me",
|
|
|
|
]),
|
|
|
|
"_fasttable_enabled": attr.label(default = "//:fasttable_enabled"),
|
|
|
|
}),
|
|
|
|
implementation = upb_proto_library_aspect_impl,
|
|
|
|
provides = [
|
|
|
|
UpbWrappedCcInfo,
|
|
|
|
UpbWrappedGeneratedSrcsInfo,
|
|
|
|
],
|
|
|
|
attr_aspects = ["deps"],
|
|
|
|
fragments = ["cpp"],
|
|
|
|
toolchains = use_cpp_toolchain(),
|
|
|
|
incompatible_use_toolchain_transition = True,
|
|
|
|
)
|
|
|
|
|
|
|
|
upb_proto_library = rule(
|
|
|
|
output_to_genfiles = True,
|
|
|
|
implementation = _upb_proto_rule_impl,
|
|
|
|
attrs = {
|
|
|
|
"deps": attr.label_list(
|
|
|
|
aspects = [upb_proto_library_aspect],
|
|
|
|
allow_rules = ["proto_library"],
|
|
|
|
providers = [ProtoInfo],
|
|
|
|
),
|
|
|
|
},
|
|
|
|
)
|
|
|
|
|
|
|
|
# upb_proto_reflection_library() ###############################################
|
|
|
|
|
|
|
|
_upb_proto_reflection_library_aspect = aspect(
|
|
|
|
attrs = _maybe_add({
|
|
|
|
"_copts": attr.label(
|
|
|
|
default = "//:upb_proto_library_copts__for_generated_code_only_do_not_use",
|
|
|
|
),
|
|
|
|
"_gen_upbdefs": attr.label(
|
|
|
|
executable = True,
|
|
|
|
cfg = "exec",
|
|
|
|
default = "//upbc:protoc-gen-upbdefs",
|
|
|
|
),
|
|
|
|
"_protoc": attr.label(
|
|
|
|
executable = True,
|
|
|
|
cfg = "exec",
|
|
|
|
default = "@com_google_protobuf//:protoc",
|
|
|
|
),
|
|
|
|
"_cc_toolchain": attr.label(
|
|
|
|
default = "@bazel_tools//tools/cpp:current_cc_toolchain",
|
|
|
|
),
|
|
|
|
"_upbdefs": attr.label_list(
|
|
|
|
default = [
|
|
|
|
"//:generated_reflection_support__only_for_generated_code_do_not_use__i_give_permission_to_break_me",
|
|
|
|
],
|
|
|
|
),
|
|
|
|
}),
|
|
|
|
implementation = _upb_proto_reflection_library_aspect_impl,
|
|
|
|
provides = [
|
|
|
|
_UpbDefsWrappedCcInfo,
|
|
|
|
_WrappedDefsGeneratedSrcsInfo,
|
|
|
|
],
|
|
|
|
required_aspect_providers = [
|
|
|
|
UpbWrappedCcInfo,
|
|
|
|
UpbWrappedGeneratedSrcsInfo,
|
|
|
|
],
|
|
|
|
attr_aspects = ["deps"],
|
|
|
|
fragments = ["cpp"],
|
|
|
|
toolchains = use_cpp_toolchain(),
|
|
|
|
incompatible_use_toolchain_transition = True,
|
|
|
|
)
|
|
|
|
|
|
|
|
upb_proto_reflection_library = rule(
|
|
|
|
output_to_genfiles = True,
|
|
|
|
implementation = _upb_proto_rule_impl,
|
|
|
|
attrs = {
|
|
|
|
"deps": attr.label_list(
|
|
|
|
aspects = [
|
|
|
|
upb_proto_library_aspect,
|
|
|
|
_upb_proto_reflection_library_aspect,
|
|
|
|
],
|
|
|
|
allow_rules = ["proto_library"],
|
|
|
|
providers = [ProtoInfo],
|
|
|
|
),
|
|
|
|
},
|
|
|
|
)
|