|
|
|
|
# TODO: ErrorProne's SelfAssertions are violated in tests
|
|
|
|
|
build --javacopt=-Xep:SelfAssertion:WARN
|
|
|
|
|
|
|
|
|
|
build:dbg --compilation_mode=dbg
|
|
|
|
|
|
|
|
|
|
build:opt --compilation_mode=opt
|
|
|
|
|
|
|
|
|
|
build:san-common --config=dbg --strip=never --copt=-O0 --copt=-fno-omit-frame-pointer
|
|
|
|
|
|
|
|
|
|
build:asan --config=san-common --copt=-fsanitize=address --linkopt=-fsanitize=address
|
|
|
|
|
# ASAN hits ODR violations with shared linkage due to rules_proto.
|
|
|
|
|
build:asan --dynamic_mode=off
|
|
|
|
|
|
|
|
|
|
build:msan --config=san-common --copt=-fsanitize=memory --linkopt=-fsanitize=memory
|
|
|
|
|
build:msan --copt=-fsanitize-memory-track-origins
|
|
|
|
|
build:msan --copt=-fsanitize-memory-use-after-dtor
|
|
|
|
|
build:msan --action_env=MSAN_OPTIONS=poison_in_dtor=1
|
|
|
|
|
|
|
|
|
|
# Use our instrumented LLVM libc++ in Kokoro.
|
|
|
|
|
build:docker-msan --config=msan
|
|
|
|
|
build:docker-msan --linkopt=-L/opt/libcxx_msan/lib --linkopt=-lc++abi
|
|
|
|
|
build:docker-msan --linkopt=-Wl,-rpath,/opt/libcxx_msan/lib
|
|
|
|
|
build:docker-msan --cxxopt=-stdlib=libc++ --linkopt=-stdlib=libc++
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
build:tsan --config=san-common --copt=-fsanitize=thread --linkopt=-fsanitize=thread
|
|
|
|
|
|
|
|
|
|
build:ubsan --config=san-common --copt=-fsanitize=undefined --linkopt=-fsanitize=undefined
|
|
|
|
|
build:ubsan --action_env=UBSAN_OPTIONS=halt_on_error=1:print_stacktrace=1
|
|
|
|
|
# Workaround for the fact that Bazel links with $CC, not $CXX
|
|
|
|
|
# https://github.com/bazelbuild/bazel/issues/11122#issuecomment-613746748
|
|
|
|
|
build:ubsan --copt=-fno-sanitize=function --copt=-fno-sanitize=vptr
|
|
|
|
|
# Abseil passes nullptr to memcmp with 0 size
|
|
|
|
|
build:ubsan --copt=-fno-sanitize=nonnull-attribute
|
|
|
|
|
|
|
|
|
|
# Workaround Bazel 7 remote cache issues.
|
|
|
|
|
# See https://github.com/bazelbuild/bazel/issues/20161
|
|
|
|
|
build --experimental_remote_cache_eviction_retries=5
|
|
|
|
|
build --remote_download_outputs=all
|
|
|
|
|
|
|
|
|
|
# Build with all --incompatible flags that we can. This helps us prepare for
|
|
|
|
|
# upcoming breaking changes in Bazel. This list was generated for Bazel 6 by
|
|
|
|
|
# running bazelisk with the --migrate flag and filtering out all flags that
|
|
|
|
|
# default to true or are deprecated.
|
|
|
|
|
build --incompatible_check_sharding_support
|
|
|
|
|
build --incompatible_default_to_explicit_init_py
|
|
|
|
|
build --incompatible_disable_native_android_rules
|
|
|
|
|
build --incompatible_disable_target_provider_fields
|
|
|
|
|
build --incompatible_disallow_empty_glob
|
|
|
|
|
build --incompatible_dont_use_javasourceinfoprovider
|
|
|
|
|
build --incompatible_enable_android_toolchain_resolution
|
|
|
|
|
build --incompatible_enable_apple_toolchain_resolution
|
|
|
|
|
build --incompatible_exclusive_test_sandboxed
|
|
|
|
|
build --incompatible_remote_output_paths_relative_to_input_root
|
|
|
|
|
build --incompatible_remote_use_new_exit_code_for_lost_inputs
|
|
|
|
|
build --incompatible_sandbox_hermetic_tmp
|
|
|
|
|
build --incompatible_struct_has_no_methods
|
|
|
|
|
build --incompatible_top_level_aspects_require_providers
|
|
|
|
|
build --incompatible_use_cc_configure_from_rules_cc
|
|
|
|
|
build --incompatible_use_host_features
|
|
|
|
|
|
|
|
|
|
# We cannot yet build successfully with the following flags:
|
|
|
|
|
# --incompatible_check_testonly_for_output_files
|
|
|
|
|
# --incompatible_config_setting_private_default_visibility
|
|
|
|
|
# --incompatible_disable_starlark_host_transitions
|
|
|
|
|
# --incompatible_disallow_struct_provider_syntax
|
|
|
|
|
# --incompatible_no_implicit_file_export
|
|
|
|
|
# --incompatible_no_rule_outputs_param
|
|
|
|
|
# --incompatible_stop_exporting_language_modules
|
|
|
|
|
# --incompatible_strict_action_env
|
|
|
|
|
# --incompatible_visibility_private_attributes_at_definition
|
|
|
|
|
|
|
|
|
|
# We might be compatible with these flags, but they are not available in all
|
|
|
|
|
# Bazel versions we are currently using:
|
|
|
|
|
# --incompatible_disable_objc_library_transition
|
|
|
|
|
# --incompatible_fail_on_unknown_attributes
|
|
|
|
|
# --incompatible_merge_fixed_and_default_shell_env
|
|
|
|
|
|
|
|
|
|
# TODO: migrate all dependencies from WORKSPACE to MODULE.bazel
|
|
|
|
|
# https://github.com/protocolbuffers/protobuf/issues/14313
|
Breaking change: make protobuf comply with the C++ layering check
This check enforces that each C++ build target has the correct dependencies for
all headers that it includes. We have many targets that were not correct with
respect to this check, so I fixed them up.
I also cleaned up the C++ targets related to the well-known types. I created a
cc_proto_library() target for each one and removed the :wkt_cc_protos target,
since this was necessary to satisfy the layering check. I deleted the
//src/google/protobuf:protobuf_nowkt target and deprecated :protobuf_nowkt,
because the distinction between the :protobuf and :protobuf_nowkt targets was
not really correct. Neither one exposed the headers for the well-known types in
a way that was valid with respect to the layering check, and the idea of
bundling all the well-known types together is not idiomatic in Bazel anyway.
This is a breaking change, because the //:protobuf target no longer bundles the
well-known types. From now on they should be accessed through the new
//:*_cc_proto aliases in our top-level package.
I renamed the :port_def target to :port, which simplifies things a bit by
matching our internal name.
The original motivation for this change was that to move utf8_range onto our CI
infrastructure, we needed to make its dependency rules_fuzzing compatible with
Bazel 6. The rules_fuzzing project builds with the layering check, and I found
that the process of upgrading it to Bazel 6 made it take a dependency on
protobuf, which caused it to break due to layering violations. I was able to
work around this, but it would still be nice to comply with the layering check
so that we don't have to worry about this kind of thing in the future.
PiperOrigin-RevId: 595516736
12 months ago
|
|
|
common --noenable_bzlmod
|
|
|
|
|
|
|
|
|
|
# For easier debugging of build failures.
|
|
|
|
|
common --announce_rc
|
|
|
|
|
build --verbose_failures
|
|
|
|
|
|
Breaking change: make protobuf comply with the C++ layering check
This check enforces that each C++ build target has the correct dependencies for
all headers that it includes. We have many targets that were not correct with
respect to this check, so I fixed them up.
I also cleaned up the C++ targets related to the well-known types. I created a
cc_proto_library() target for each one and removed the :wkt_cc_protos target,
since this was necessary to satisfy the layering check. I deleted the
//src/google/protobuf:protobuf_nowkt target and deprecated :protobuf_nowkt,
because the distinction between the :protobuf and :protobuf_nowkt targets was
not really correct. Neither one exposed the headers for the well-known types in
a way that was valid with respect to the layering check, and the idea of
bundling all the well-known types together is not idiomatic in Bazel anyway.
This is a breaking change, because the //:protobuf target no longer bundles the
well-known types. From now on they should be accessed through the new
//:*_cc_proto aliases in our top-level package.
I renamed the :port_def target to :port, which simplifies things a bit by
matching our internal name.
The original motivation for this change was that to move utf8_range onto our CI
infrastructure, we needed to make its dependency rules_fuzzing compatible with
Bazel 6. The rules_fuzzing project builds with the layering check, and I found
that the process of upgrading it to Bazel 6 made it take a dependency on
protobuf, which caused it to break due to layering violations. I was able to
work around this, but it would still be nice to comply with the layering check
so that we don't have to worry about this kind of thing in the future.
PiperOrigin-RevId: 595516736
12 months ago
|
|
|
# Important: this flag ensures that we remain compliant with the C++ layering
|
|
|
|
|
# check.
|
|
|
|
|
build --features=layering_check
|
