Remove outdated comment on attributes in trace.proto (#327)

* Remove outdated comment on attributes in trace.proto

One can just look up the definition of `KeyValue` and `AnyValue` in `common.proto` which will stay up to date.

* Reference API spec in trace.proto
pull/330/head
Armin Ruech 3 years ago committed by GitHub
parent e57e849443
commit e2680d3e88
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
  1. 6
      opentelemetry/proto/trace/v1/trace.proto

@ -158,14 +158,16 @@ message Span {
// This field is semantically required and it is expected that end_time >= start_time.
fixed64 end_time_unix_nano = 8;
// attributes is a collection of key/value pairs. The value can be a string,
// an integer, a double or the Boolean values `true` or `false`. Note, global attributes
// attributes is a collection of key/value pairs. Note, global attributes
// like server name can be set using the resource API. Examples of attributes:
//
// "/http/user_agent": "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_14_2) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/71.0.3578.98 Safari/537.36"
// "/http/server_latency": 300
// "abc.com/myattribute": true
// "abc.com/score": 10.239
//
// The OpenTelemetry API specification further restricts the allowed value types:
// https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/common/common.md#attributes
repeated opentelemetry.proto.common.v1.KeyValue attributes = 9;
// dropped_attributes_count is the number of attributes that were discarded. Attributes

Loading…
Cancel
Save