Clarify what empty instrumentation name means, and missing instrumentation library (#245)

* Clarify what empty instrumentation name means, and missing instrumentation library

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>

* Update opentelemetry/proto/logs/v1/logs.proto

Co-authored-by: Yuri Shkuro <yurishkuro@users.noreply.github.com>

* Update opentelemetry/proto/logs/v1/logs.proto

Co-authored-by: Yuri Shkuro <yurishkuro@users.noreply.github.com>

* Update opentelemetry/proto/logs/v1/logs.proto

Co-authored-by: Yuri Shkuro <yurishkuro@users.noreply.github.com>

* Update opentelemetry/proto/common/v1/common.proto

Co-authored-by: Tigran Najaryan <4194920+tigrannajaryan@users.noreply.github.com>

* Update common.proto

Co-authored-by: Yuri Shkuro <yurishkuro@users.noreply.github.com>
Co-authored-by: Tigran Najaryan <4194920+tigrannajaryan@users.noreply.github.com>

opentelemetry/proto/common/v1/common.proto

@@ -72,6 +72,7 @@ message StringKeyValue {
 // InstrumentationLibrary is a message representing the instrumentation library information
 // such as the fully qualified name and version. 
 message InstrumentationLibrary {
+  // An empty instrumentation library name means the name is unknown. 
   string name = 1;
   string version = 2;
 }

opentelemetry/proto/logs/v1/logs.proto

@@ -27,7 +27,7 @@ option go_package = "github.com/open-telemetry/opentelemetry-proto/gen/go/logs/v
 // A collection of InstrumentationLibraryLogs from a Resource.
 message ResourceLogs {
   // The resource for the logs in this message.
-    // If this field is not set then no resource info is known.
+  // If this field is not set then resource info is unknown.
   opentelemetry.proto.resource.v1.Resource resource = 1;
 
   // A list of InstrumentationLibraryLogs that originate from a resource.
@@ -37,7 +37,8 @@ message ResourceLogs {
 // A collection of Logs produced by an InstrumentationLibrary.
 message InstrumentationLibraryLogs {
   // The instrumentation library information for the logs in this message.
-    // If this field is not set then no library info is known.
+  // Semantically when InstrumentationLibrary isn't set, it is equivalent with
+  // an empty instrumentation library name (unknown).
   opentelemetry.proto.common.v1.InstrumentationLibrary instrumentation_library = 1;
 
   // A list of log records.
@@ -46,7 +47,7 @@ message InstrumentationLibraryLogs {
 
 // Possible values for LogRecord.SeverityNumber.
 enum SeverityNumber {
-    // UNSPECIFIED is the default SeverityNumber, it MUST not be used.
+  // UNSPECIFIED is the default SeverityNumber, it MUST NOT be used.
   SEVERITY_NUMBER_UNSPECIFIED = 0;
   SEVERITY_NUMBER_TRACE  = 1;
   SEVERITY_NUMBER_TRACE2 = 2;

opentelemetry/proto/metrics/v1/metrics.proto

@@ -37,7 +37,8 @@ message ResourceMetrics {
 // A collection of Metrics produced by an InstrumentationLibrary.
 message InstrumentationLibraryMetrics {
   // The instrumentation library information for the metrics in this message.
-  // If this field is not set then no library info is known.
+  // Semantically when InstrumentationLibrary isn't set, it is equivalent with
+  // an empty instrumentation library name (unknown).
   opentelemetry.proto.common.v1.InstrumentationLibrary instrumentation_library = 1;
 
   // A list of metrics that originate from an instrumentation library.

opentelemetry/proto/trace/v1/trace.proto

@@ -37,7 +37,8 @@ message ResourceSpans {
 // A collection of Spans produced by an InstrumentationLibrary.
 message InstrumentationLibrarySpans {
   // The instrumentation library information for the spans in this message.
-  // If this field is not set then no library info is known.
+  // Semantically when InstrumentationLibrary isn't set, it is equivalent with
+  // an empty instrumentation library name (unknown).
   opentelemetry.proto.common.v1.InstrumentationLibrary instrumentation_library = 1;
 
   // A list of Spans that originate from an instrumentation library.