diff --git a/modules/cvv/src/controller/view_controller.cpp b/modules/cvv/src/controller/view_controller.cpp index d81fcfd45..fc41da6da 100644 --- a/modules/cvv/src/controller/view_controller.cpp +++ b/modules/cvv/src/controller/view_controller.cpp @@ -64,21 +64,21 @@ void ViewController::addCallType(const QString typeName, TabFactory constr) ViewController::callTabType[typeName] = constr; } -std::unique_ptr +static std::unique_ptr makeFilterCallTab(cvv::util::Reference call) { return cvv::util::make_unique( *call.castTo()); } -std::unique_ptr +static std::unique_ptr makeMatchCallTab(cvv::util::Reference call) { return cvv::util::make_unique( *call.castTo()); } -std::unique_ptr +static std::unique_ptr makeImageCallTab(cvv::util::Reference call) { return cvv::util::make_unique( diff --git a/modules/cvv/src/qtutil/filter/changed_pixels_widget.cpp b/modules/cvv/src/qtutil/filter/changed_pixels_widget.cpp index 6cbbabb82..061429689 100644 --- a/modules/cvv/src/qtutil/filter/changed_pixels_widget.cpp +++ b/modules/cvv/src/qtutil/filter/changed_pixels_widget.cpp @@ -14,7 +14,7 @@ void changedPixelImage(const cv::Mat& mat0, const cv::Mat& mat1, cv::Mat& out); template void changedPixelImage(const cv::Mat& mat0, const cv::Mat& mat1, cv::Mat& out); -void changedPixelImage(const cv::Mat& mat0, const cv::Mat& mat1, cv::Mat& out) +static void changedPixelImage(const cv::Mat& mat0, const cv::Mat& mat1, cv::Mat& out) { // need same size if (mat0.size() != mat1.size()) diff --git a/modules/cvv/src/qtutil/matchview/keypointmanagement.cpp b/modules/cvv/src/qtutil/matchview/keypointmanagement.cpp index a5445049f..12a30e79e 100644 --- a/modules/cvv/src/qtutil/matchview/keypointmanagement.cpp +++ b/modules/cvv/src/qtutil/matchview/keypointmanagement.cpp @@ -142,7 +142,7 @@ void KeyPointManagement::setSelection( void KeyPointManagement::addSetting() { - addSetting(std::move(util::make_unique(univers_))); + addSetting(util::make_unique(univers_)); } @@ -176,7 +176,7 @@ void KeyPointManagement::removeSetting(KeyPointSettingsSelector *setting) void KeyPointManagement::addSelection() { - addSelection(std::move(util::make_unique(univers_))); + addSelection(util::make_unique(univers_)); } void KeyPointManagement::addSelection(std::unique_ptr selection) diff --git a/modules/cvv/src/qtutil/matchview/matchmanagement.cpp b/modules/cvv/src/qtutil/matchview/matchmanagement.cpp index fea7ee480..7bc8ea886 100644 --- a/modules/cvv/src/qtutil/matchview/matchmanagement.cpp +++ b/modules/cvv/src/qtutil/matchview/matchmanagement.cpp @@ -137,7 +137,7 @@ void MatchManagement::setSelection( void MatchManagement::addSetting() { - addSetting(std::move(util::make_unique(univers_))); + addSetting(util::make_unique(univers_)); } @@ -172,7 +172,7 @@ void MatchManagement::removeSetting(MatchSettingsSelector *setting) void MatchManagement::addSelection() { - addSelection(std::move(util::make_unique(univers_))); + addSelection(util::make_unique(univers_)); } void MatchManagement::addSelection(std::unique_ptr selection) diff --git a/modules/cvv/src/qtutil/matchview/matchscene.hpp b/modules/cvv/src/qtutil/matchview/matchscene.hpp index e9b739737..38c02291f 100644 --- a/modules/cvv/src/qtutil/matchview/matchscene.hpp +++ b/modules/cvv/src/qtutil/matchview/matchscene.hpp @@ -44,7 +44,7 @@ class MatchSceneGraphicsView : public QGraphicsView emit signalResized(); } - virtual void contextMenuEvent(QContextMenuEvent *event) + virtual void contextMenuEvent(QContextMenuEvent *event) CV_OVERRIDE { emit signalContextMenu(event->globalPos()); //event->ignore(); diff --git a/modules/cvv/src/qtutil/util.cpp b/modules/cvv/src/qtutil/util.cpp index 26f526692..97c9c4da8 100644 --- a/modules/cvv/src/qtutil/util.cpp +++ b/modules/cvv/src/qtutil/util.cpp @@ -335,7 +335,7 @@ bool checkValueRange(const cv::Mat &mat, DepthType min, * @param res The error code. * @return The result. */ -std::pair errorResult(ImageConversionResult res, +static std::pair errorResult(ImageConversionResult res, const cv::Mat &mat) { switch (res) diff --git a/modules/cvv/src/qtutil/zoomableimage.cpp b/modules/cvv/src/qtutil/zoomableimage.cpp index 762adb2e9..ce62daab6 100644 --- a/modules/cvv/src/qtutil/zoomableimage.cpp +++ b/modules/cvv/src/qtutil/zoomableimage.cpp @@ -137,7 +137,7 @@ template std::string printPixel(const cv::Mat &mat, int i, int j) * @return The channels of pixel mat,col from mat as a string. (or ">6 * channels") */ -std::string printPixel(const cv::Mat &mat, int i, int j) +static std::string printPixel(const cv::Mat &mat, int i, int j) { if (i >= 0 && j >= 0) { diff --git a/modules/cvv/src/view/defaultfilterview.cpp b/modules/cvv/src/view/defaultfilterview.cpp index b7f90b6d5..1ded5a298 100644 --- a/modules/cvv/src/view/defaultfilterview.cpp +++ b/modules/cvv/src/view/defaultfilterview.cpp @@ -41,8 +41,7 @@ DefaultFilterView::DefaultFilterView(const std::vector &images, accor->insert( QString("Image Information: ") + QString::number(count), - std::move( - util::make_unique(*zoomIm))); + util::make_unique(*zoomIm)); zoomIm->setMat(image); @@ -51,7 +50,7 @@ DefaultFilterView::DefaultFilterView(const std::vector &images, histogram->setVisible(false); connect(zoomIm.get(), SIGNAL(updateArea(QRectF, qreal)), histogram.get(), SLOT(setArea(QRectF, qreal))); - accor->insert(QString("Histogram: ") + QString::number(count), std::move(util::make_unique(*histogram))); + accor->insert(QString("Histogram: ") + QString::number(count), util::make_unique(*histogram)); imageLayout->addWidget(zoomIm.release(), 0, count); imageLayout->addWidget(histogram.release(), 1, count); diff --git a/modules/cvv/src/view/dual_filter_view.cpp b/modules/cvv/src/view/dual_filter_view.cpp index 4e5d3608d..c98f3e4c9 100644 --- a/modules/cvv/src/view/dual_filter_view.cpp +++ b/modules/cvv/src/view/dual_filter_view.cpp @@ -69,8 +69,7 @@ DualFilterView::DualFilterView(std::array images, QWidget *parent) accor->insert( QString("Image Information: ") + QString::number(count), - std::move( - util::make_unique(*zoomIm))); + util::make_unique(*zoomIm)); if (count != 1) { @@ -99,7 +98,7 @@ DualFilterView::DualFilterView(std::array images, QWidget *parent) syncVec.push_back(lambda(rawImages_.at(1), 2)); accor->insert("Zoom synchronization", - std::move(util::make_unique(syncVec)), true, 1); + util::make_unique(syncVec), true, 1); //ensure that all images have same width imwid->setLayout(imageLayout.release()); diff --git a/modules/cvv/src/view/image_view.cpp b/modules/cvv/src/view/image_view.cpp index 3f5077bc2..6c0545e80 100644 --- a/modules/cvv/src/view/image_view.cpp +++ b/modules/cvv/src/view/image_view.cpp @@ -32,8 +32,7 @@ ImageView::ImageView(const cv::Mat &image, QWidget *parent) accor->setMaximumWidth(300); auto zoomim = util::make_unique(); - accor->insert(QString("ImageInformation:"), - std::move(util::make_unique(*zoomim,false))); + accor->insert(QString("ImageInformation:"), util::make_unique(*zoomim,false)); zoomim->setMat(image); auto histogram = util::make_unique(); @@ -41,7 +40,7 @@ ImageView::ImageView(const cv::Mat &image, QWidget *parent) histogram->setVisible(false); connect(zoomim.get(), SIGNAL(updateArea(QRectF, qreal)), histogram.get(), SLOT(setArea(QRectF, qreal))); - accor->insert(QString("Histogram:"), std::move(util::make_unique(*histogram))); + accor->insert(QString("Histogram:"), util::make_unique(*histogram)); this->image = (*zoomim); imageLayout->addWidget(zoomim.release(), 0, 0); diff --git a/modules/cvv/src/view/linematchview.cpp b/modules/cvv/src/view/linematchview.cpp index 3caa36508..d56e48db5 100644 --- a/modules/cvv/src/view/linematchview.cpp +++ b/modules/cvv/src/view/linematchview.cpp @@ -66,18 +66,15 @@ LineMatchView::LineMatchView(std::vector leftKeyPoints, accor->insert("Match Settings", std::move(matchmnt)); accor->insert("KeyPoint Settings", std::move(keyPointmnt)); accor->insert("Show selection in rawview window", - std::move(util::make_unique(leftKeyPoints, + util::make_unique(leftKeyPoints, rightKeyPoints, matches, matchManagment_, - keyManagment_))); - - accor->insert("Sync Zoom ", - std::move(matchscene_ptr->getSyncZoomWidget())); - accor->insert("Left Image ", - std::move(matchscene_ptr->getLeftMatInfoWidget())); - accor->insert("Right Image ", - std::move(matchscene_ptr->getRightMatInfoWidget())); + keyManagment_)); + + accor->insert("Sync Zoom ", matchscene_ptr->getSyncZoomWidget()); + accor->insert("Left Image ", matchscene_ptr->getLeftMatInfoWidget()); + accor->insert("Right Image ", matchscene_ptr->getRightMatInfoWidget()); layout->addWidget(accor.release()); layout->addWidget(matchscene.release()); diff --git a/modules/cvv/src/view/linematchview.hpp b/modules/cvv/src/view/linematchview.hpp index 049c02fd6..d44653a2c 100644 --- a/modules/cvv/src/view/linematchview.hpp +++ b/modules/cvv/src/view/linematchview.hpp @@ -56,19 +56,19 @@ class LineMatchView : public MatchView return matchManagment_->getCurrentSelection(); } - virtual std::vector getKeyPointSelection() + virtual std::vector getKeyPointSelection() CV_OVERRIDE { return keyManagment_->getCurrentSelection(); } public slots: - virtual void setMatchSelection(std::vector selection) + virtual void setMatchSelection(std::vector selection) CV_OVERRIDE { matchManagment_->setSelection(selection); } - virtual void setKeyPointSelection(std::vector selection) + virtual void setKeyPointSelection(std::vector selection) CV_OVERRIDE { keyManagment_->setSelection(selection); } diff --git a/modules/cvv/src/view/pointmatchview.cpp b/modules/cvv/src/view/pointmatchview.cpp index b7874186b..dddd283b1 100644 --- a/modules/cvv/src/view/pointmatchview.cpp +++ b/modules/cvv/src/view/pointmatchview.cpp @@ -46,11 +46,11 @@ PointMatchView::PointMatchView(std::vector leftKeyPoints, accor->insert("Match Settings", std::move(matchmnt)); accor->insert("Sync Zoom ", - std::move(matchscene_ptr->getSyncZoomWidget())); + matchscene_ptr->getSyncZoomWidget()); accor->insert("Left Image ", - std::move(matchscene_ptr->getLeftMatInfoWidget())); + matchscene_ptr->getLeftMatInfoWidget()); accor->insert("Right Image ", - std::move(matchscene_ptr->getRightMatInfoWidget())); + matchscene_ptr->getRightMatInfoWidget()); layout->addWidget(accor.release()); layout->addWidget(matchscene.release()); diff --git a/modules/cvv/src/view/pointmatchview.hpp b/modules/cvv/src/view/pointmatchview.hpp index e9919ac21..e6a749e66 100644 --- a/modules/cvv/src/view/pointmatchview.hpp +++ b/modules/cvv/src/view/pointmatchview.hpp @@ -58,7 +58,7 @@ class PointMatchView : public MatchView public slots: - virtual void setMatchSelection(std::vector selection) + virtual void setMatchSelection(std::vector selection) CV_OVERRIDE { matchManagment_->setSelection(selection); } diff --git a/modules/cvv/src/view/singlefilterview.cpp b/modules/cvv/src/view/singlefilterview.cpp index 7eb9d4d32..4ea9781e5 100644 --- a/modules/cvv/src/view/singlefilterview.cpp +++ b/modules/cvv/src/view/singlefilterview.cpp @@ -44,8 +44,7 @@ SingleFilterView::SingleFilterView(const std::vector &images, auto originalZoomIm = util::make_unique(image); accor->insert( QString("Info original image ") + QString::number(count), - std::move( - util::make_unique(*originalZoomIm))); + util::make_unique(*originalZoomIm)); syncVec.push_back(originalZoomIm.get()); @@ -66,8 +65,7 @@ SingleFilterView::SingleFilterView(const std::vector &images, accor->insert( QString("Info filtered image ") + QString::number(count), - std::move( - util::make_unique(*filterZoomIm))); + util::make_unique(*filterZoomIm)); syncVec.push_back(filterZoomIm.get()); @@ -84,7 +82,7 @@ SingleFilterView::SingleFilterView(const std::vector &images, imwid->setLayout(imageLayout.release()); accor->insert("Zoom synchronization", - std::move(util::make_unique(syncVec)), true, 1); + util::make_unique(syncVec), true, 1); layout->addWidget(accor.release()); layout->addWidget(imwid.release()); diff --git a/modules/cvv/src/view/translationsmatchview.cpp b/modules/cvv/src/view/translationsmatchview.cpp index d0fe0ac24..40deef66b 100644 --- a/modules/cvv/src/view/translationsmatchview.cpp +++ b/modules/cvv/src/view/translationsmatchview.cpp @@ -57,17 +57,17 @@ TranslationMatchView::TranslationMatchView( accor->insert("Match Settings", std::move(matchmnt)); accor->insert("KeyPoint Settings", std::move(keyPointmnt)); accor->insert("Show selection in rawview window", - std::move(util::make_unique(leftKeyPoints, + util::make_unique(leftKeyPoints, rightKeyPoints, matches, matchManagment_, - keyManagment_))); + keyManagment_)); accor->insert("Sync Zoom ", - std::move(matchscene_ptr->getSyncZoomWidget())); + matchscene_ptr->getSyncZoomWidget()); accor->insert("Left Image ", - std::move(matchscene_ptr->getLeftMatInfoWidget())); + matchscene_ptr->getLeftMatInfoWidget()); accor->insert("Right Image ", - std::move(matchscene_ptr->getRightMatInfoWidget())); + matchscene_ptr->getRightMatInfoWidget()); layout->addWidget(accor.release()); layout->addWidget(matchscene.release()); diff --git a/modules/cvv/src/view/translationsmatchview.hpp b/modules/cvv/src/view/translationsmatchview.hpp index 3cbdcd47e..822137630 100644 --- a/modules/cvv/src/view/translationsmatchview.hpp +++ b/modules/cvv/src/view/translationsmatchview.hpp @@ -60,19 +60,19 @@ class TranslationMatchView : public MatchView return matchManagment_->getCurrentSelection(); } - virtual std::vector getKeyPointSelection() + virtual std::vector getKeyPointSelection() CV_OVERRIDE { return keyManagment_->getCurrentSelection(); } public slots: - virtual void setMatchSelection(std::vector selection) + virtual void setMatchSelection(std::vector selection) CV_OVERRIDE { matchManagment_->setSelection(selection); } - virtual void setKeyPointSelection(std::vector selection) + virtual void setKeyPointSelection(std::vector selection) CV_OVERRIDE { keyManagment_->setSelection(selection); }