diff --git a/modules/aruco/tutorials/charuco_detection/images/board.jpg b/modules/aruco/tutorials/charuco_detection/images/charucoboard.jpg similarity index 100% rename from modules/aruco/tutorials/charuco_detection/images/board.jpg rename to modules/aruco/tutorials/charuco_detection/images/charucoboard.jpg diff --git a/modules/ovis/CMakeLists.txt b/modules/ovis/CMakeLists.txt index 246f374d8..870e95d4c 100644 --- a/modules/ovis/CMakeLists.txt +++ b/modules/ovis/CMakeLists.txt @@ -16,6 +16,10 @@ elseif(OGRE_VERSION VERSION_GREATER 1.10) # we need C++11 for OGRE 1.11 endif() endif() +if(OGRE_VERSION VERSION_LESS 1.10.10) + message(WARNING "opencv_ovis: Ogre >= 1.10.10 recommended for interactive windows") +endif() + include_directories(${OGRE_INCLUDE_DIRS}) link_directories(${OGRE_LIBRARY_DIRS}) diff --git a/modules/ovis/src/ovis.cpp b/modules/ovis/src/ovis.cpp index 7883ce651..9c1d9388d 100644 --- a/modules/ovis/src/ovis.cpp +++ b/modules/ovis/src/ovis.cpp @@ -181,7 +181,7 @@ struct Application : public OgreBites::ApplicationContext, public OgreBites::Inp int flags; Application(const Ogre::String& _title, const Size& sz, int _flags) - : OgreBites::ApplicationContext("ovis", false), sceneMgr(NULL), title(_title), w(sz.width), + : OgreBites::ApplicationContext("ovis"), sceneMgr(NULL), title(_title), w(sz.width), h(sz.height), key_pressed(-1), flags(_flags) { if(utils::getConfigurationParameterBool("OPENCV_OVIS_VERBOSE_LOG", false)) diff --git a/modules/sfm/samples/trajectory_reconstruccion.cpp b/modules/sfm/samples/trajectory_reconstruction.cpp similarity index 100% rename from modules/sfm/samples/trajectory_reconstruccion.cpp rename to modules/sfm/samples/trajectory_reconstruction.cpp diff --git a/modules/sfm/src/projection.cpp b/modules/sfm/src/projection.cpp index 56effd114..49e73d98d 100644 --- a/modules/sfm/src/projection.cpp +++ b/modules/sfm/src/projection.cpp @@ -55,34 +55,34 @@ namespace sfm template void -homogeneousToEuclidean(const Mat & _X, Mat & _x) +homogeneousToEuclidean(const Mat & X_, Mat & x_) { - int d = _X.rows - 1; + int d = X_.rows - 1; - const Mat_ & X_rows = _X.rowRange(0,d); - const Mat_ h = _X.row(d); + const Mat_ & X_rows = X_.rowRange(0,d); + const Mat_ h = X_.row(d); const T * h_ptr = h[0], *h_ptr_end = h_ptr + h.cols; const T * X_ptr = X_rows[0]; - T * x_ptr = _x.ptr(0); + T * x_ptr = x_.ptr(0); for (; h_ptr != h_ptr_end; ++h_ptr, ++X_ptr, ++x_ptr) { const T * X_col_ptr = X_ptr; - T * x_col_ptr = x_ptr, *x_col_ptr_end = x_col_ptr + d * _x.step1(); - for (; x_col_ptr != x_col_ptr_end; X_col_ptr+=X_rows.step1(), x_col_ptr+=_x.step1() ) + T * x_col_ptr = x_ptr, *x_col_ptr_end = x_col_ptr + d * x_.step1(); + for (; x_col_ptr != x_col_ptr_end; X_col_ptr+=X_rows.step1(), x_col_ptr+=x_.step1() ) *x_col_ptr = (*X_col_ptr) / (*h_ptr); } } void -homogeneousToEuclidean(InputArray _X, OutputArray _x) +homogeneousToEuclidean(InputArray X_, OutputArray x_) { // src - const Mat X = _X.getMat(); + const Mat X = X_.getMat(); // dst - _x.create(X.rows-1, X.cols, X.type()); - Mat x = _x.getMat(); + x_.create(X.rows-1, X.cols, X.type()); + Mat x = x_.getMat(); // type if( X.depth() == CV_32F ) @@ -96,11 +96,11 @@ homogeneousToEuclidean(InputArray _X, OutputArray _x) } void -euclideanToHomogeneous(InputArray _x, OutputArray _X) +euclideanToHomogeneous(InputArray x_, OutputArray X_) { - const Mat x = _x.getMat(); + const Mat x = x_.getMat(); const Mat last_row = Mat::ones(1, x.cols, x.type()); - vconcat(x, last_row, _X); + vconcat(x, last_row, X_); } template @@ -111,16 +111,16 @@ projectionFromKRt(const Mat_ &K, const Mat_ &R, const Mat_ &t, Mat_ } void -projectionFromKRt(InputArray _K, InputArray _R, InputArray _t, OutputArray _P) +projectionFromKRt(InputArray K_, InputArray R_, InputArray t_, OutputArray P_) { - const Mat K = _K.getMat(), R = _R.getMat(), t = _t.getMat(); + const Mat K = K_.getMat(), R = R_.getMat(), t = t_.getMat(); const int depth = K.depth(); CV_Assert((K.cols == 3 && K.rows == 3) && (t.cols == 1 && t.rows == 3) && (K.size() == R.size())); CV_Assert((depth == CV_32F || depth == CV_64F) && depth == R.depth() && depth == t.depth()); - _P.create(3, 4, depth); + P_.create(3, 4, depth); - Mat P = _P.getMat(); + Mat P = P_.getMat(); // type if( depth == CV_32F ) @@ -136,33 +136,33 @@ projectionFromKRt(InputArray _K, InputArray _R, InputArray _t, OutputArray _P) template void -KRtFromProjection( const Mat_ &_P, Mat_ _K, Mat_ _R, Mat_ _t ) +KRtFromProjection( const Mat_ &P_, Mat_ K_, Mat_ R_, Mat_ t_ ) { libmv::Mat34 P; libmv::Mat3 K, R; libmv::Vec3 t; - cv2eigen( _P, P ); + cv2eigen( P_, P ); libmv::KRt_From_P( P, &K, &R, &t ); - eigen2cv( K, _K ); - eigen2cv( R, _R ); - eigen2cv( t, _t ); + eigen2cv( K, K_ ); + eigen2cv( R, R_ ); + eigen2cv( t, t_ ); } void -KRtFromProjection( InputArray _P, OutputArray _K, OutputArray _R, OutputArray _t ) +KRtFromProjection( InputArray P_, OutputArray K_, OutputArray R_, OutputArray t_ ) { - const Mat P = _P.getMat(); + const Mat P = P_.getMat(); const int depth = P.depth(); CV_Assert((P.cols == 4 && P.rows == 3) && (depth == CV_32F || depth == CV_64F)); - _K.create(3, 3, depth); - _R.create(3, 3, depth); - _t.create(3, 1, depth); + K_.create(3, 3, depth); + R_.create(3, 3, depth); + t_.create(3, 1, depth); - Mat K = _K.getMat(), R = _R.getMat(), t = _t.getMat(); + Mat K = K_.getMat(), R = R_.getMat(), t = t_.getMat(); // type if( depth == CV_32F ) @@ -177,19 +177,19 @@ KRtFromProjection( InputArray _P, OutputArray _K, OutputArray _R, OutputArray _t template T -depthValue( const Mat_ &_R, const Mat_ &_t, const Mat_ &_X ) +depthValue( const Mat_ &R_, const Mat_ &t_, const Mat_ &X_ ) { - Matx R(_R); - Vec t(_t); + Matx R(R_); + Vec t(t_); - if ( _X.rows == 3) + if ( X_.rows == 3) { - Vec X(_X); + Vec X(X_); return (R*X)(2) + t(2); } else { - Vec X(_X); + Vec X(X_); Vec Xe; homogeneousToEuclidean(X,Xe); return depthValue( Mat(R), Mat(t), Mat(Xe) ); @@ -197,9 +197,9 @@ depthValue( const Mat_ &_R, const Mat_ &_t, const Mat_ &_X ) } double -depth( InputArray _R, InputArray _t, InputArray _X) +depth( InputArray R_, InputArray t_, InputArray X_) { - const Mat R = _R.getMat(), t = _t.getMat(), X = _X.getMat(); + const Mat R = R_.getMat(), t = t_.getMat(), X = X_.getMat(); const int depth = R.depth(); CV_Assert( R.rows == 3 && R.cols == 3 && t.rows == 3 && t.cols == 1 ); CV_Assert( (X.rows == 3 && X.cols == 1) || (X.rows == 4 && X.cols == 1) ); diff --git a/modules/sfm/tutorials/sfm_trajectory_estimation/sfm_trajectory_estimation.markdown b/modules/sfm/tutorials/sfm_trajectory_estimation/sfm_trajectory_estimation.markdown index e01373483..beca4c4df 100644 --- a/modules/sfm/tutorials/sfm_trajectory_estimation/sfm_trajectory_estimation.markdown +++ b/modules/sfm/tutorials/sfm_trajectory_estimation/sfm_trajectory_estimation.markdown @@ -14,7 +14,7 @@ In this tutorial you will learn how to use the reconstruction api for camera mot Code ---- -@include sfm/samples/trajectory_reconstruccion.cpp +@include sfm/samples/trajectory_reconstruction.cpp Explanation ----------- diff --git a/modules/text/CMakeLists.txt b/modules/text/CMakeLists.txt index 5d0f89f0d..20f9cd752 100644 --- a/modules/text/CMakeLists.txt +++ b/modules/text/CMakeLists.txt @@ -7,7 +7,7 @@ if(NOT CMAKE_CROSSCOMPILING OR OPENCV_FIND_TESSERACT) if(Tesseract_FOUND) message(STATUS "Tesseract: YES") set(HAVE_TESSERACT 1) - ocv_include_directories(${Tesseract_INCLUDE_DIR}) + ocv_include_directories(${Tesseract_INCLUDE_DIRS}) ocv_target_link_libraries(${the_module} ${Tesseract_LIBRARIES}) else() message(STATUS "Tesseract: NO")