From 6f006e50dc2cff6ba8b316640d769db1ac08e2ca Mon Sep 17 00:00:00 2001 From: Andrey Pavlenko Date: Fri, 31 May 2013 18:58:30 +0400 Subject: [PATCH 1/2] setting 'char' to be signed by default since some tests fail when it's wrong (e.g. native compilation on ARM Linux) --- cmake/OpenCVCompilerOptions.cmake | 3 +++ 1 file changed, 3 insertions(+) diff --git a/cmake/OpenCVCompilerOptions.cmake b/cmake/OpenCVCompilerOptions.cmake index aeed112ae0..bded2d41fe 100644 --- a/cmake/OpenCVCompilerOptions.cmake +++ b/cmake/OpenCVCompilerOptions.cmake @@ -47,6 +47,9 @@ macro(add_extra_compiler_option option) endif() endmacro() +# some OpenCV tests fail when 'char' is 'unsigned' by default +add_extra_compiler_option(-fsigned-char) + if(MINGW) # http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40838 # here we are trying to workaround the problem From 081c47e3df9819e025520ea7b77cc627cd4ccdbe Mon Sep 17 00:00:00 2001 From: Andrey Pavlenko Date: Fri, 31 May 2013 19:55:51 +0400 Subject: [PATCH 2/2] making the comment less ambigous --- cmake/OpenCVCompilerOptions.cmake | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cmake/OpenCVCompilerOptions.cmake b/cmake/OpenCVCompilerOptions.cmake index bded2d41fe..7a91b188ae 100644 --- a/cmake/OpenCVCompilerOptions.cmake +++ b/cmake/OpenCVCompilerOptions.cmake @@ -47,7 +47,7 @@ macro(add_extra_compiler_option option) endif() endmacro() -# some OpenCV tests fail when 'char' is 'unsigned' by default +# OpenCV fails some tests when 'char' is 'unsigned' by default add_extra_compiler_option(-fsigned-char) if(MINGW)