From 962f5c9b82a6ea1239eb417c67b39a0446128e80 Mon Sep 17 00:00:00 2001 From: Alexander Alekhin Date: Mon, 7 Dec 2020 21:18:47 +0000 Subject: [PATCH] videoio(test): skip GStreamer in 'frame_timestamp' tests - CAP_PROP_POS_MSEC is not reliable --- modules/videoio/src/cap_gstreamer.cpp | 2 ++ modules/videoio/test/test_video_io.cpp | 9 ++++++++- 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/modules/videoio/src/cap_gstreamer.cpp b/modules/videoio/src/cap_gstreamer.cpp index 5821fb0180..08c25ca573 100644 --- a/modules/videoio/src/cap_gstreamer.cpp +++ b/modules/videoio/src/cap_gstreamer.cpp @@ -1062,6 +1062,8 @@ double GStreamerCapture::getProperty(int propId) const switch(propId) { case CV_CAP_PROP_POS_MSEC: + CV_LOG_ONCE_WARNING(NULL, "OpenCV | GStreamer: CAP_PROP_POS_MSEC property result may be unrealiable: " + "https://github.com/opencv/opencv/issues/19025"); format = GST_FORMAT_TIME; status = gst_element_query_position(sink.get(), CV_GST_FORMAT(format), &value); if(!status) { diff --git a/modules/videoio/test/test_video_io.cpp b/modules/videoio/test/test_video_io.cpp index 19fc32b53e..44947f02f4 100644 --- a/modules/videoio/test/test_video_io.cpp +++ b/modules/videoio/test/test_video_io.cpp @@ -237,6 +237,11 @@ public: if (!isBackendAvailable(apiPref, cv::videoio_registry::getStreamBackends())) throw SkipTestException(cv::String("Backend is not available/disabled: ") + cv::videoio_registry::getBackendName(apiPref)); + // GStreamer: https://github.com/opencv/opencv/issues/19025 + if (apiPref == CAP_GSTREAMER) + throw SkipTestException(cv::String("Backend ") + cv::videoio_registry::getBackendName(apiPref) + + cv::String(" does not return reliable values for CAP_PROP_POS_MSEC property")); + if (((apiPref == CAP_FFMPEG) && ((ext == "h264") || (ext == "h265")))) throw SkipTestException(cv::String("Backend ") + cv::videoio_registry::getBackendName(apiPref) + cv::String(" does not support CAP_PROP_POS_MSEC option")); @@ -253,10 +258,12 @@ public: double timestamp = 0; ASSERT_NO_THROW(cap >> img); EXPECT_NO_THROW(timestamp = cap.get(CAP_PROP_POS_MSEC)); + if (cvtest::debugLevel > 0) + std::cout << "i = " << i << ": timestamp = " << timestamp << std::endl; const double frame_period = 1000.f/bunny_param.getFps(); // NOTE: eps == frame_period, because videoCapture returns frame begining timestamp or frame end // timestamp depending on codec and back-end. So the first frame has timestamp 0 or frame_period. - EXPECT_NEAR(timestamp, i*frame_period, frame_period); + EXPECT_NEAR(timestamp, i*frame_period, frame_period) << "i=" << i; } } };