mirror of https://github.com/opencv/opencv.git
Merge pull request #25901 from mshabunin:fix-riscv-aarch-baseline
RISC-V/AArch64: disable CPU features detection #25901 This PR is the first step in fixing current issues with NEON/RVV, FP16, BF16 and other CPU features on AArch64 and RISC-V platforms. On AArch64 and RISC-V platforms we usually have the platform set by default in the toolchain when we compile it or in the cmake toolchain file or in CMAKE_CXX_FLAGS by user. Then, there are two ways to set platform options: a) "-mcpu=<some_cpu>" ; b) "-march=<arch description>" (e.g. "rv64gcv"). Furthermore, there are no similar "levels" of optimizations as for x86_64, instead we have features (RVV, FP16,...) which can be enabled or disabled. So, for example, if a user has "rv64gc" set by the toolchain and we want to enable RVV. Then we need to somehow parse their current feature set and append "v" (vector optimizations) to this string. This task is quite hard and the whole procedure is prone to errors. I propose to use "CPU_BASELINE=DETECT" by default on AArch64 and RISC-V platforms. And somehow remove other features or make them read-only/detect-only, so that OpenCV wouldn't add any extra "-march" flags to the default configuration. We would rely only on the flags provided by the compiler and cmake toolchain file. We can have some predefined configurations in our cmake toolchain files. Changes made by this PR: - `CMakeLists.txt`: - use `CMAKE_CROSSCOMPILING` instead of `CMAKE_TOOLCHAIN_FILE` to detect cross-compilation. This might be useful in cases of native compilation with a toolchain file - removed obsolete variables `ENABLE_NEON` and `ENABLE_VFPV3`, the first one have been turned ON by default on AArch64 platform which caused setting `CPU_BASELINE=NEON` - raise minimum cmake version allowed to 3.7 to allow using `CMAKE_CXX_FLAGS_INIT` in toolchain files - added separate files with arch flags for native compilation on AArch64 and RISC-V, these files will be used in our toolchain files and in regular cmake - use `DETECT` as default value for `CPU_BASELINE` also allow `NATIVE`, warn user if other values were used (only for AArch64 and RISC-V) - for each feature listed in `CPU_DISPATCH` check if corresponding `CPU_${opt}_FLAGS_ON` has been provided, warn user if it is empty (only for AArch64 and RISC-V) - use `CPU_BASELINE_DISABLE` variable to actually turn off macros responsible for corresponding features even if they are enabled by compiler - removed Aarch64 feature merge procedure (it didn't support `-mcpu` and built-in `-march`) - reworked AArch64 and two RISC-V cmake toolchain files (does not affect Android/OSX/iOS/Win): - use `CMAKE_CXX_FLAGS_INIT` to set compiler flags - use variables `ENABLE_BF16`, `ENABLE_DOTPROD`, `ENABLE_RVV`, `ENABLE_FP16` to control `-march` - AArch64: removed other compiler and linker flags - `-fdata-sections`, `-fsigned-char`, `-Wl,--no-undefined`, `-Wl,--gc-sections` - already set by OpenCV - `-Wa,--noexecstack`, `-Wl,-z,noexecstack`, `-Wl,-z,relro`, `-Wl,-z,now` - can be enabled by OpenCV via `ENABLE_HARDENING` - `-Wno-psabi` - this option used to disable some warnings on older ARM platforms, shouldn't harm - ARM: removed same common flags as for AArch64, but left `-mthumb` and `--fix-cortex-a8`, `-z nocopyreloc`pull/26146/head
Maksim Shabunin
2 months ago
committed by
GitHub
parent
85923c8f30
commit
4c81e174bf
11 changed files with 115 additions and 81 deletions
@ -1 +1,9 @@ |
||||
# empty |
||||
if((CMAKE_CXX_COMPILER_ID MATCHES "GNU" OR CMAKE_CXX_COMPILER_ID MATCHES "Clang") |
||||
AND NOT CMAKE_CROSSCOMPILING |
||||
AND NOT CMAKE_TOOLCHAIN_FILE) |
||||
if(CMAKE_SYSTEM_PROCESSOR STREQUAL "aarch64") # Maybe use AARCH64 variable? |
||||
include(${CMAKE_CURRENT_LIST_DIR}/../../platforms/linux/flags-aarch64.cmake) |
||||
elseif(CMAKE_SYSTEM_PROCESSOR STREQUAL "riscv64") |
||||
include(${CMAKE_CURRENT_LIST_DIR}/../../platforms/linux/flags-riscv64.cmake) |
||||
endif() |
||||
endif() |
||||
|
||||
@ -0,0 +1,19 @@ |
||||
# see https://gcc.gnu.org/onlinedocs/gcc/AArch64-Options.html#index-march |
||||
function(ocv_set_platform_flags VAR) |
||||
unset(flags) |
||||
if(ENABLE_BF16) |
||||
set(flags "${flags}+bf16") |
||||
endif() |
||||
if(ENABLE_DOTPROD) |
||||
set(flags "${flags}+dotprod") |
||||
endif() |
||||
if(ENABLE_FP16) |
||||
set(flags "${flags}+fp16") |
||||
endif() |
||||
if(DEFINED ENABLE_NEON AND NOT ENABLE_NEON) |
||||
set(flags "${flags}+nosimd") |
||||
endif() |
||||
if(flags) |
||||
set(${VAR} "-march=armv8.2-a${flags}" PARENT_SCOPE) |
||||
endif() |
||||
endfunction() |
||||
@ -0,0 +1,9 @@ |
||||
# see https://gcc.gnu.org/onlinedocs/gcc/RISC-V-Options.html#index-march-14 |
||||
function(ocv_set_platform_flags VAR) |
||||
if(ENABLE_RVV OR RISCV_RVV_SCALABLE) |
||||
set(flags "-march=rv64gcv") |
||||
else() |
||||
set(flags "-march=rv64gc") |
||||
endif() |
||||
set(${VAR} "${flags}" PARENT_SCOPE) |
||||
endfunction() |
||||
@ -1,10 +1,11 @@ |
||||
set(CMAKE_SYSTEM_NAME Linux) |
||||
set(CMAKE_SYSTEM_VERSION 1) |
||||
set(CMAKE_SYSTEM_PROCESSOR riscv64) |
||||
set(GNU_MACHINE riscv64-unknown-linux-gnu CACHE STRING "GNU compiler triple") |
||||
|
||||
if(NOT DEFINED CMAKE_CXX_FLAGS) # guards toolchain multiple calls |
||||
set(CMAKE_C_FLAGS "-march=rv64gc") |
||||
set(CMAKE_CXX_FLAGS "-march=rv64gc") |
||||
include("${CMAKE_CURRENT_LIST_DIR}/flags-riscv64.cmake") |
||||
if(COMMAND ocv_set_platform_flags) |
||||
ocv_set_platform_flags(CMAKE_CXX_FLAGS_INIT) |
||||
ocv_set_platform_flags(CMAKE_C_FLAGS_INIT) |
||||
endif() |
||||
|
||||
include("${CMAKE_CURRENT_LIST_DIR}/riscv-gnu.toolchain.cmake") |
||||
|
||||
Loading…
Reference in new issue