From 35f96d6da76099d80180439c857a4abe5cb17966 Mon Sep 17 00:00:00 2001 From: Jeremy Huddleston Sequoia Date: Fri, 5 Dec 2014 10:22:11 -0800 Subject: [PATCH] Fix tautologies in calibfilter.cpp which cause a build failure when using -Werror=address with clang-3.5 http://code.opencv.org/issues/4048 Signed-off-by: Jeremy Huddleston Sequoia --- modules/legacy/src/calibfilter.cpp | 98 ++++++++++++++---------------- 1 file changed, 46 insertions(+), 52 deletions(-) diff --git a/modules/legacy/src/calibfilter.cpp b/modules/legacy/src/calibfilter.cpp index 49ff6e52dc..6eb50a90d4 100644 --- a/modules/legacy/src/calibfilter.cpp +++ b/modules/legacy/src/calibfilter.cpp @@ -95,11 +95,8 @@ bool CvCalibFilter::SetEtalon( CvCalibEtalonType type, double* params, Stop(); - if (latestPoints != NULL) - { - for( i = 0; i < MAX_CAMERAS; i++ ) - cvFree( latestPoints + i ); - } + for( i = 0; i < MAX_CAMERAS; i++ ) + cvFree( latestPoints + i ); if( type == CV_CALIB_ETALON_USER || type != etalonType ) { @@ -523,64 +520,61 @@ void CvCalibFilter::DrawPoints( CvMat** dstarr ) return; } - if( latestCounts ) + for( i = 0; i < cameraCount; i++ ) { - for( i = 0; i < cameraCount; i++ ) + if( dstarr[i] && latestCounts[i] ) { - if( dstarr[i] && latestCounts[i] ) - { - CvMat dst_stub, *dst; - int count = 0; - bool found = false; - CvPoint2D32f* pts = 0; + CvMat dst_stub, *dst; + int count = 0; + bool found = false; + CvPoint2D32f* pts = 0; - GetLatestPoints( i, &pts, &count, &found ); + GetLatestPoints( i, &pts, &count, &found ); - dst = cvGetMat( dstarr[i], &dst_stub ); + dst = cvGetMat( dstarr[i], &dst_stub ); - static const CvScalar line_colors[] = - { - {{0,0,255}}, - {{0,128,255}}, - {{0,200,200}}, - {{0,255,0}}, - {{200,200,0}}, - {{255,0,0}}, - {{255,0,255}} - }; - - const int colorCount = sizeof(line_colors)/sizeof(line_colors[0]); - const int r = 4; - CvScalar color = line_colors[0]; - CvPoint prev_pt = { 0, 0}; - - for( j = 0; j < count; j++ ) - { - CvPoint pt; - pt.x = cvRound(pts[j].x); - pt.y = cvRound(pts[j].y); + static const CvScalar line_colors[] = + { + {{0,0,255}}, + {{0,128,255}}, + {{0,200,200}}, + {{0,255,0}}, + {{200,200,0}}, + {{255,0,0}}, + {{255,0,255}} + }; + + const int colorCount = sizeof(line_colors)/sizeof(line_colors[0]); + const int r = 4; + CvScalar color = line_colors[0]; + CvPoint prev_pt = { 0, 0}; + + for( j = 0; j < count; j++ ) + { + CvPoint pt; + pt.x = cvRound(pts[j].x); + pt.y = cvRound(pts[j].y); - if( found ) - { - if( etalonType == CV_CALIB_ETALON_CHESSBOARD ) - color = line_colors[(j/cvRound(etalonParams[0]))%colorCount]; - else - color = CV_RGB(0,255,0); + if( found ) + { + if( etalonType == CV_CALIB_ETALON_CHESSBOARD ) + color = line_colors[(j/cvRound(etalonParams[0]))%colorCount]; + else + color = CV_RGB(0,255,0); - if( j != 0 ) - cvLine( dst, prev_pt, pt, color, 1, CV_AA ); - } + if( j != 0 ) + cvLine( dst, prev_pt, pt, color, 1, CV_AA ); + } - cvLine( dst, cvPoint( pt.x - r, pt.y - r ), - cvPoint( pt.x + r, pt.y + r ), color, 1, CV_AA ); + cvLine( dst, cvPoint( pt.x - r, pt.y - r ), + cvPoint( pt.x + r, pt.y + r ), color, 1, CV_AA ); - cvLine( dst, cvPoint( pt.x - r, pt.y + r), - cvPoint( pt.x + r, pt.y - r), color, 1, CV_AA ); + cvLine( dst, cvPoint( pt.x - r, pt.y + r), + cvPoint( pt.x + r, pt.y - r), color, 1, CV_AA ); - cvCircle( dst, pt, r+1, color, 1, CV_AA ); + cvCircle( dst, pt, r+1, color, 1, CV_AA ); - prev_pt = pt; - } + prev_pt = pt; } } }