From 24f82c755add423e52a9b43238b9ab0a0411788f Mon Sep 17 00:00:00 2001
From: Andrey Kamaev <no@email>
Date: Thu, 5 Apr 2012 07:25:52 +0000
Subject: [PATCH] Improved accuracy of SSE-optimized BayerXX2GRAY conversion;
 added regression test

---
 modules/imgproc/src/color.cpp       | 18 +++++++++---------
 modules/imgproc/test/test_color.cpp | 26 ++++++++++++++++++++++++--
 2 files changed, 33 insertions(+), 11 deletions(-)

diff --git a/modules/imgproc/src/color.cpp b/modules/imgproc/src/color.cpp
index 75d1f5a3ac..e33c645fbe 100644
--- a/modules/imgproc/src/color.cpp
+++ b/modules/imgproc/src/color.cpp
@@ -1767,26 +1767,26 @@ public:
             __m128i r1 = _mm_loadu_si128((const __m128i*)(bayer+bayer_step));
             __m128i r2 = _mm_loadu_si128((const __m128i*)(bayer+bayer_step*2));
             
-            __m128i b1 = _mm_add_epi16(_mm_srli_epi16(_mm_slli_epi16(r0, 8), 8),
-                                       _mm_srli_epi16(_mm_slli_epi16(r2, 8), 8));
+            __m128i b1 = _mm_add_epi16(_mm_srli_epi16(_mm_slli_epi16(r0, 8), 7),
+                                       _mm_srli_epi16(_mm_slli_epi16(r2, 8), 7));
             __m128i b0 = _mm_add_epi16(b1, _mm_srli_si128(b1, 2));
             b1 = _mm_slli_epi16(_mm_srli_si128(b1, 2), 1);
             
-            __m128i g0 = _mm_add_epi16(_mm_srli_epi16(r0, 8), _mm_srli_epi16(r2, 8));
-            __m128i g1 = _mm_srli_epi16(_mm_slli_epi16(r1, 8), 8);
+            __m128i g0 = _mm_add_epi16(_mm_srli_epi16(r0, 7), _mm_srli_epi16(r2, 7));
+            __m128i g1 = _mm_srli_epi16(_mm_slli_epi16(r1, 8), 7);
             g0 = _mm_add_epi16(g0, _mm_add_epi16(g1, _mm_srli_si128(g1, 2)));
             g1 = _mm_slli_epi16(_mm_srli_si128(g1, 2), 2);
             
             r0 = _mm_srli_epi16(r1, 8);
-            r1 = _mm_slli_epi16(_mm_add_epi16(r0, _mm_srli_si128(r0, 2)), 1);
-            r0 = _mm_slli_epi16(r0, 2);
-            
+            r1 = _mm_slli_epi16(_mm_add_epi16(r0, _mm_srli_si128(r0, 2)), 2);
+            r0 = _mm_slli_epi16(r0, 3);
+
             g0 = _mm_add_epi16(_mm_mulhi_epi16(b0, _b2y), _mm_mulhi_epi16(g0, _g2y));
             g1 = _mm_add_epi16(_mm_mulhi_epi16(b1, _b2y), _mm_mulhi_epi16(g1, _g2y));
             g0 = _mm_add_epi16(g0, _mm_mulhi_epi16(r0, _r2y));
             g1 = _mm_add_epi16(g1, _mm_mulhi_epi16(r1, _r2y));
-            g0 = _mm_srli_epi16(g0, 1);
-            g1 = _mm_srli_epi16(g1, 1);
+            g0 = _mm_srli_epi16(g0, 2);
+            g1 = _mm_srli_epi16(g1, 2);
             g0 = _mm_packus_epi16(g0, g0);
             g1 = _mm_packus_epi16(g1, g1);
             g0 = _mm_unpacklo_epi8(g0, g1);
diff --git a/modules/imgproc/test/test_color.cpp b/modules/imgproc/test/test_color.cpp
index 68008b714d..d14543ff02 100644
--- a/modules/imgproc/test/test_color.cpp
+++ b/modules/imgproc/test/test_color.cpp
@@ -1672,11 +1672,33 @@ TEST(Imgproc_ColorRGB, accuracy) { CV_ColorRGBTest test; test.safe_run(); }
 TEST(Imgproc_ColorBayer, accuracy) { CV_ColorBayerTest test; test.safe_run(); }
 
 
-TEST(Imgproc_ColorBayerVNG, accuracy)
+TEST(Imgproc_ColorBayer, regression)
 {
     cvtest::TS& ts = *cvtest::TS::ptr();
 
-    Mat given = imread(string(ts.get_data_path()) + "/cvtcolor/bayerVNG_input.png", CV_LOAD_IMAGE_GRAYSCALE);
+    Mat given = imread(string(ts.get_data_path()) + "/cvtcolor/bayer_input.png", CV_LOAD_IMAGE_GRAYSCALE);
+    Mat gold = imread(string(ts.get_data_path()) + "/cvtcolor/bayer_gold.png", CV_LOAD_IMAGE_UNCHANGED);
+    Mat result;
+
+    cvtColor(given, result, CV_BayerBG2GRAY);
+
+    EXPECT_EQ(gold.type(), result.type());
+    EXPECT_EQ(gold.cols, result.cols);
+    EXPECT_EQ(gold.rows, result.rows);
+
+    Mat diff;
+    absdiff(gold, result, diff);
+    //imshow("diff", diff);
+    //waitKey();
+
+    EXPECT_EQ(0, countNonZero(diff.reshape(1) > 1));
+}
+
+TEST(Imgproc_ColorBayerVNG, regression)
+{
+    cvtest::TS& ts = *cvtest::TS::ptr();
+
+    Mat given = imread(string(ts.get_data_path()) + "/cvtcolor/bayer_input.png", CV_LOAD_IMAGE_GRAYSCALE);
     Mat gold = imread(string(ts.get_data_path()) + "/cvtcolor/bayerVNG_gold.png", CV_LOAD_IMAGE_UNCHANGED);
     Mat result;