From d9870ed54b27f853d43b4aaaf4daec86e92bd20e Mon Sep 17 00:00:00 2001 From: Dylan Baker Date: Tue, 25 Jul 2023 11:25:58 -0700 Subject: [PATCH] modules/python3: exclude name_prefix and name_suffix We can remove these from `permittedKwargs` (like we've already done for `typed_kwargs`) and then remove the in body checks. --- mesonbuild/modules/python3.py | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/mesonbuild/modules/python3.py b/mesonbuild/modules/python3.py index 90ee9529f..bc4d9af3a 100644 --- a/mesonbuild/modules/python3.py +++ b/mesonbuild/modules/python3.py @@ -47,14 +47,10 @@ class Python3Module(ExtensionModule): 'sysconfig_path': self.sysconfig_path, }) - @permittedKwargs(known_shmod_kwargs) + @permittedKwargs(known_shmod_kwargs - {'name_prefix', 'name_suffix'}) @typed_pos_args('python3.extension_module', str, varargs=(str, mesonlib.File, CustomTarget, CustomTargetIndex, GeneratedList, StructuredSources, ExtractedObjects, BuildTarget)) @typed_kwargs('python3.extension_module', *_MOD_KWARGS, allow_unknown=True) def extension_module(self, state: ModuleState, args: T.Tuple[str, T.List[BuildTargetSource]], kwargs: SharedModuleKW): - if 'name_prefix' in kwargs: - raise mesonlib.MesonException('Name_prefix is set automatically, specifying it is forbidden.') - if 'name_suffix' in kwargs: - raise mesonlib.MesonException('Name_suffix is set automatically, specifying it is forbidden.') host_system = state.host_machine.system if host_system == 'darwin': # Default suffix is 'dylib' but Python does not use it for extensions.