unit tests: Be more specific in checking for commands

'-w' in c_command will check for it as a substring, which will also
match '-wd', etc. So match it with quotes. This won't give us false
positives, but might give us false negatives in case the argument is not
quoted, but that's better behaviour for a test.

The alternative is to split the string command, but the command does not
necessarily obey shell quoting rules, so we cannot reliably use
shlex.split().
pull/1253/head
Nirbheek Chauhan 8 years ago
parent 54697b4130
commit c8bb7f2217
  1. 12
      run_unittests.py

@ -221,15 +221,15 @@ class LinuxlikeTests(unittest.TestCase):
self.assertIsNotNone(vala_command)
self.assertIsNotNone(c_command)
# -w suppresses all warnings, should be there in Vala but not in C
self.assertTrue('-w' in vala_command)
self.assertFalse('-w' in c_command)
self.assertTrue("'-w'" in vala_command)
self.assertFalse("'-w'" in c_command)
# -Wall enables all warnings, should be there in C but not in Vala
self.assertFalse('-Wall' in vala_command)
self.assertTrue('-Wall' in c_command)
self.assertFalse("'-Wall'" in vala_command)
self.assertTrue("'-Wall'" in c_command)
# -Werror converts warnings to errors, should always be there since it's
# injected by an unrelated piece of code and the project has werror=true
self.assertTrue('-Werror' in vala_command)
self.assertTrue('-Werror' in c_command)
self.assertTrue("'-Werror'" in vala_command)
self.assertTrue("'-Werror'" in c_command)
def test_static_compile_order(self):
'''

Loading…
Cancel
Save