python compiled extensions should never need to expose any symbol other than PyInit_* which is declared with default visibility via PyMODINIT_FUNC on supported compilers. Thus, a reasonably sane default is to mark any other symbols as hidden, while still respecting any manually specified visibility. Gate this on the version of python itself, as not all versions decorate PyMODINIT_FUNC properly.pull/10380/head
parent
7c4087ace5
commit
aa874ea0d0
3 changed files with 22 additions and 0 deletions
@ -0,0 +1,12 @@ |
||||
## Python extension modules now build with hidden visibility |
||||
|
||||
Python extension modules are usually expected to only export a single symbol, |
||||
decorated with the `PyMODINIT_FUNC` macro and providing the module entry point. |
||||
On versions of python >= 3.9, the python headers contain GNU symbol visibility |
||||
attributes to mark the init function with default visibility; it is then safe |
||||
to set the [[shared_module]] inherited kwarg `gnu_symbol_visibility: 'hidden'`. |
||||
|
||||
In the interest of doing the right thing out of the box, this is now the |
||||
default for extension modules for found installations that are new enough to |
||||
have this set, which is not expected to break anything, but remains possible to |
||||
set explicitly (in which case that will take precedence). |
Loading…
Reference in new issue