mesontest: Fix --repeat with --gdb

It would add --args to `wrap` repeatedly for each re-run, resulting in
gdb erroring out with `--args: No such file or directory.`

Also don't make --gdb and --wrapper mutually exclusive. Sometimes people
want to run under a wrapper *and* run it under gdb.
pull/1421/head
Nirbheek Chauhan 8 years ago
parent 62c7dcf32d
commit 9fffcef290
  1. 6
      mesontest.py

@ -421,7 +421,9 @@ TIMEOUT: %4d
wrap = ['gdb', '--quiet', '--nh'] wrap = ['gdb', '--quiet', '--nh']
if self.options.repeat > 1: if self.options.repeat > 1:
wrap += ['-ex', 'run', '-ex', 'quit'] wrap += ['-ex', 'run', '-ex', 'quit']
elif self.options.wrapper: # Signal the end of arguments to gdb
wrap += ['--args']
if self.options.wrapper:
wrap += self.options.wrapper wrap += self.options.wrapper
assert(isinstance(wrap, list)) assert(isinstance(wrap, list))
return wrap return wrap
@ -452,8 +454,6 @@ TIMEOUT: %4d
if self.options.gdb: if self.options.gdb:
test.timeout = None test.timeout = None
if len(test.cmd_args):
wrap.append('--args')
if not test.is_parallel or self.options.gdb: if not test.is_parallel or self.options.gdb:
self.drain_futures(futures, logfile, jsonlogfile) self.drain_futures(futures, logfile, jsonlogfile)

Loading…
Cancel
Save