Remove -pipe from default list of args. Closes #8508.

pull/8573/head
Jussi Pakkanen 4 years ago
parent ea48edbb0f
commit 9ab4dadef9
  1. 10
      docs/markdown/snippets/nopipe.md
  2. 6
      mesonbuild/compilers/fortran.py
  3. 2
      mesonbuild/compilers/mixins/clike.py
  4. 3
      mesonbuild/interpreter.py

@ -0,0 +1,10 @@
## `-pipe` no longer used by default
Meson used to add the `-pipe` command line argument to all compilers
that supported it, but no longer does. If you need this, then you can
add it manually. However note that you should not do this unless you
have actually measured that it provides performance improvements. In
our tests we could not find a case where adding `-pipe` made
compilation faster and using `-pipe` [can cause sporadic build
failures in certain
cases](https://github.com/mesonbuild/meson/issues/8508).

@ -336,12 +336,6 @@ class IntelFortranCompiler(IntelGnuLikeCompiler, FortranCompiler):
def get_preprocess_only_args(self) -> T.List[str]:
return ['-cpp', '-EP']
def get_always_args(self) -> T.List[str]:
"""Ifort doesn't have -pipe."""
val = super().get_always_args()
val.remove('-pipe')
return val
def language_stdlib_only_link_flags(self) -> T.List[str]:
return ['-lifcore', '-limf']

@ -155,7 +155,7 @@ class CLikeCompiler(Compiler):
'''
Args that are always-on for all C compilers other than MSVC
'''
return ['-pipe'] + self.get_largefile_args()
return self.get_largefile_args()
def get_no_stdinc_args(self) -> T.List[str]:
return ['-nostdinc']

@ -4716,9 +4716,6 @@ This warning will become a hard error in a future Meson release.
elif arg == '-g':
mlog.warning(f'Consider using the built-in debug option instead of using "{arg}".',
location=self.current_node)
elif arg == '-pipe':
mlog.warning("You don't need to add -pipe, Meson will use it automatically when it is available.",
location=self.current_node)
elif arg.startswith('-fsanitize'):
mlog.warning(f'Consider using the built-in option for sanitizers instead of using "{arg}".',
location=self.current_node)

Loading…
Cancel
Save