diff --git a/backends.py b/backends.py index 424d9001f..cf8b90a2c 100644 --- a/backends.py +++ b/backends.py @@ -176,9 +176,12 @@ class Backend(): if pathsegs[0] == 'subprojects': pathsegs = pathsegs[2:] fixedpath = os.sep.join(pathsegs) - objbase = os.path.join(fixedpath, osrc.fname).replace('/', '_').replace('\\', '_') + print('fname', osrc.fname) + objbase = osrc.fname.replace('/', '_').replace('\\', '_') + print('objbase', objbase) objname = os.path.join(proj_dir_to_build_root, targetdir, os.path.basename(objbase) + suffix) + print('objname', objname) result.append(objname) return result diff --git a/interpreter.py b/interpreter.py index 5db9717f8..05e30a1d5 100644 --- a/interpreter.py +++ b/interpreter.py @@ -1774,14 +1774,16 @@ class Interpreter(): self.validate_extraction(obj.held_object) return obj.method_call(method_name, args, kwargs) + # Only permit object extraction from the same subproject def validate_extraction(self, buildtarget): - if self.subproject_dir == '': + if not self.subdir.startswith(self.subproject_dir): if buildtarget.subdir.startswith(self.subproject_dir): raise InterpreterException('Tried to extract objects from a subproject target.') else: - lead = '/'.join(self.subdir.split('/')[0:2]) if not buildtarget.subdir.startswith(lead): - raise InterpreterException('Tried to extract objects from a different subproject target.') + raise InterpreterException('Tried to extract objects from the main project from a subproject.') + if self.subdir.split('/')[1] != buildtarget.subdir.split('/')[1]: + raise InterpreterException('Tried to extract objects from a different subproject.') def array_method_call(self, obj, method_name, args): if method_name == 'contains': diff --git a/test cases/failing/16 extract object subdir/meson.build b/test cases/common/84 extract from nested subdir/meson.build similarity index 100% rename from test cases/failing/16 extract object subdir/meson.build rename to test cases/common/84 extract from nested subdir/meson.build diff --git a/test cases/failing/16 extract object subdir/src/first/lib_first.c b/test cases/common/84 extract from nested subdir/src/first/lib_first.c similarity index 100% rename from test cases/failing/16 extract object subdir/src/first/lib_first.c rename to test cases/common/84 extract from nested subdir/src/first/lib_first.c diff --git a/test cases/failing/16 extract object subdir/src/first/meson.build b/test cases/common/84 extract from nested subdir/src/first/meson.build similarity index 100% rename from test cases/failing/16 extract object subdir/src/first/meson.build rename to test cases/common/84 extract from nested subdir/src/first/meson.build diff --git a/test cases/failing/16 extract object subdir/src/meson.build b/test cases/common/84 extract from nested subdir/src/meson.build similarity index 100% rename from test cases/failing/16 extract object subdir/src/meson.build rename to test cases/common/84 extract from nested subdir/src/meson.build diff --git a/test cases/failing/16 extract object subdir/tst/first/exe_first.c b/test cases/common/84 extract from nested subdir/tst/first/exe_first.c similarity index 100% rename from test cases/failing/16 extract object subdir/tst/first/exe_first.c rename to test cases/common/84 extract from nested subdir/tst/first/exe_first.c diff --git a/test cases/failing/16 extract object subdir/tst/first/meson.build b/test cases/common/84 extract from nested subdir/tst/first/meson.build similarity index 100% rename from test cases/failing/16 extract object subdir/tst/first/meson.build rename to test cases/common/84 extract from nested subdir/tst/first/meson.build diff --git a/test cases/failing/16 extract object subdir/tst/meson.build b/test cases/common/84 extract from nested subdir/tst/meson.build similarity index 100% rename from test cases/failing/16 extract object subdir/tst/meson.build rename to test cases/common/84 extract from nested subdir/tst/meson.build diff --git a/test cases/common/84 extract subproject object/main.c b/test cases/failing/16 extract from subproject/main.c similarity index 100% rename from test cases/common/84 extract subproject object/main.c rename to test cases/failing/16 extract from subproject/main.c diff --git a/test cases/common/84 extract subproject object/meson.build b/test cases/failing/16 extract from subproject/meson.build similarity index 100% rename from test cases/common/84 extract subproject object/meson.build rename to test cases/failing/16 extract from subproject/meson.build diff --git a/test cases/common/84 extract subproject object/subprojects/sub_project/meson.build b/test cases/failing/16 extract from subproject/subprojects/sub_project/meson.build similarity index 100% rename from test cases/common/84 extract subproject object/subprojects/sub_project/meson.build rename to test cases/failing/16 extract from subproject/subprojects/sub_project/meson.build diff --git a/test cases/common/84 extract subproject object/subprojects/sub_project/sub_lib.c b/test cases/failing/16 extract from subproject/subprojects/sub_project/sub_lib.c similarity index 100% rename from test cases/common/84 extract subproject object/subprojects/sub_project/sub_lib.c rename to test cases/failing/16 extract from subproject/subprojects/sub_project/sub_lib.c