From 891b4ffe3372c840322f5586430dcba34acf6d53 Mon Sep 17 00:00:00 2001 From: Eli Schwartz Date: Sun, 25 Dec 2022 16:42:00 -0500 Subject: [PATCH] dependencies: better logging of pkg-config call outputs If `pkg-config --modversion foobar` fails, we don't know why. The general issue here, though, is that call_pkgbin routinely logs stdout for informational purposes, but not stderr. Fixes #11076 --- mesonbuild/dependencies/pkgconfig.py | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/mesonbuild/dependencies/pkgconfig.py b/mesonbuild/dependencies/pkgconfig.py index 231ec5183..76dc3ef07 100644 --- a/mesonbuild/dependencies/pkgconfig.py +++ b/mesonbuild/dependencies/pkgconfig.py @@ -124,7 +124,11 @@ class PkgConfigDependency(ExternalDependency): p, out, err = Popen_safe(cmd, env=env) rc, out, err = p.returncode, out.strip(), err.strip() call = ' '.join(cmd) - mlog.debug(f"Called `{call}` -> {rc}\n{out}") + mlog.debug(f"Called `{call}` -> {rc}") + if out: + mlog.debug(f'stdout:\n{out}\n-----------') + if err: + mlog.debug(f'stderr:\n{err}\n-----------') return rc, out, err @staticmethod