Emscripten version numbers are unrelated to Clang version numbers, so it is necessary to change the version checks for `c_std=c17` & co. Without that, no project that defaults to C17 or newer will build with Emscripten. See https://github.com/pyodide/pyodide/discussions/4762 for more context. Also note that this bug caused defaulting to C17 in scikit-learn to be reverted (scikit-learn#29015), and it may be a problem for SciPy 1.14.0 too since that release will upgrade from C99 to C17. Co-authored-by: Loic Esteve <loic.esteve@ymail.com>pull/13224/head
parent
7d28ff2939
commit
77db04ffa6
2 changed files with 16 additions and 1 deletions
@ -1,4 +1,9 @@ |
||||
project('emcctest', 'c', 'cpp') |
||||
project('emcctest', 'c', 'cpp', |
||||
default_options: [ |
||||
'c_std=c17', |
||||
'cpp_std=c++17', |
||||
] |
||||
) |
||||
|
||||
executable('hello-c', 'hello.c') |
||||
executable('hello', 'hello.cpp') |
||||
|
Loading…
Reference in new issue