unittests/pic: Actually test that setting b_staticpic works

The previous test was tautological for the second half because:

a) b_staticpic=true is the default
b) We weren't refetching the compdb
pull/897/head
Nirbheek Chauhan 8 years ago
parent 69ca8f5b54
commit 7307f6a5c8
  1. 12
      run_unittests.py

@ -13,7 +13,7 @@
# See the License for the specific language governing permissions and # See the License for the specific language governing permissions and
# limitations under the License. # limitations under the License.
import unittest, os, sys, shutil import unittest, os, sys, shutil, time
import subprocess import subprocess
import re, json import re, json
import tempfile import tempfile
@ -77,9 +77,15 @@ class LinuxlikeTests(unittest.TestCase):
self.init(testdir) self.init(testdir)
compdb = self.get_compdb() compdb = self.get_compdb()
self.assertTrue('-fPIC' in compdb[0]['command']) self.assertTrue('-fPIC' in compdb[0]['command'])
self.setconf('-Db_staticpic=true') # This is needed to increase the difference between build.ninja's
# timestamp and coredata.dat's timestamp due to a Ninja bug.
# https://github.com/ninja-build/ninja/issues/371
time.sleep(1)
self.setconf('-Db_staticpic=false')
# Regenerate build
self.build() self.build()
self.assertFalse('-fPIC' not in compdb[0]['command']) compdb = self.get_compdb()
self.assertTrue('-fPIC' not in compdb[0]['command'])
if __name__ == '__main__': if __name__ == '__main__':
unittest.main() unittest.main()

Loading…
Cancel
Save