From 58c124d48a278e0d428cc4ecb3883b7ba5f55565 Mon Sep 17 00:00:00 2001 From: Eli Schwartz Date: Thu, 17 Feb 2022 01:25:17 -0500 Subject: [PATCH] project tests: fine-tune the check for whether we are in CI Follow-up on commit 4274e0f42a9673df981dd7a7a456f4d4fcfe5452. We want to allow tests to be skipped freely in third-party environments, so this should check the jobname, not whether $CI exists. We will anyways raise an error when trying to run the project tests, if $CI is set but no jobname is set. --- run_project_tests.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/run_project_tests.py b/run_project_tests.py index 55ab6d4da..926f4ef38 100755 --- a/run_project_tests.py +++ b/run_project_tests.py @@ -972,7 +972,7 @@ def have_java() -> bool: def skip_dont_care(t: TestDef) -> bool: # Everything is optional when not running on CI - if not under_ci: + if ci_jobname is None: return True # Non-frameworks test are allowed to determine their own skipping under CI (currently)