From 3ef332e89a7050d0c03801099a0649e00c187278 Mon Sep 17 00:00:00 2001
From: Dylan Baker <dylan@pnwbakers.com>
Date: Fri, 2 Sep 2022 15:03:13 -0700
Subject: [PATCH] pylint: enable global-variable-not-assigned

The `global` statement is only needed to assign to global variables, not
read or mutate them. So calling `global.mutate()` is fine, but not
`var = foo`, which would otherwise shadow `var`.
---
 .pylintrc                             | 1 -
 mesonbuild/mesonlib/universal.py      | 1 -
 mesonbuild/mlog.py                    | 1 -
 mesonbuild/scripts/symbolextractor.py | 1 -
 4 files changed, 4 deletions(-)

diff --git a/.pylintrc b/.pylintrc
index 945dca7fc..f62775b6b 100644
--- a/.pylintrc
+++ b/.pylintrc
@@ -24,7 +24,6 @@ disable=
     exec-used,
     fixme,
     global-statement,
-    global-variable-not-assigned,
     implicit-str-concat,
     import-error,
     import-outside-toplevel,
diff --git a/mesonbuild/mesonlib/universal.py b/mesonbuild/mesonlib/universal.py
index 4fbdf1ecf..6f6daf489 100644
--- a/mesonbuild/mesonlib/universal.py
+++ b/mesonbuild/mesonlib/universal.py
@@ -229,7 +229,6 @@ def verbose_git(cmd: T.List[str], workingdir: T.Union[str, bytes, os.PathLike],
     return p.returncode == 0
 
 def set_meson_command(mainfile: str) -> None:
-    global python_command
     global _meson_command
     # On UNIX-like systems `meson` is a Python script
     # On Windows `meson` and `meson.exe` are wrapper exes
diff --git a/mesonbuild/mlog.py b/mesonbuild/mlog.py
index cd067389e..1bdc1ca2a 100644
--- a/mesonbuild/mlog.py
+++ b/mesonbuild/mlog.py
@@ -396,7 +396,6 @@ def format_list(input_list: T.List[str]) -> str:
 
 @contextmanager
 def nested(name: str = '') -> T.Generator[None, None, None]:
-    global log_depth
     log_depth.append(name)
     try:
         yield
diff --git a/mesonbuild/scripts/symbolextractor.py b/mesonbuild/scripts/symbolextractor.py
index 8f61ad495..8992e9480 100644
--- a/mesonbuild/scripts/symbolextractor.py
+++ b/mesonbuild/scripts/symbolextractor.py
@@ -53,7 +53,6 @@ def write_if_changed(text: str, outfilename: str) -> None:
         f.write(text)
 
 def print_tool_warning(tools: T.List[str], msg: str, stderr: T.Optional[str] = None) -> None:
-    global TOOL_WARNING_FILE
     if os.path.exists(TOOL_WARNING_FILE):
         return
     m = f'{tools!r} {msg}. {RELINKING_WARNING}'