CustomTarget: require install_dir only when install is true (#519)

9 years ago · 35ef1d109a
parent 8cd359acbb
commit 35ef1d109a
1 changed files with 6 additions and 5 deletions
--- a/mesonbuild/build.py
+++ b/mesonbuild/build.py
@ -871,11 +871,12 @@ class CustomTarget:
            self.install = kwargs['install']
            if not isinstance(self.install, bool):
                raise InvalidArguments('"install" must be boolean.')
-            if 'install_dir' not in kwargs:
-                raise InvalidArguments('"install_dir" not specified.')
-            self.install_dir = kwargs['install_dir']
-            if not(isinstance(self.install_dir, str)):
-                raise InvalidArguments('"install_dir" must be a string.')
+            if self.install:
+                if 'install_dir' not in kwargs:
+                    raise InvalidArguments('"install_dir" not specified.')
+                self.install_dir = kwargs['install_dir']
+                if not(isinstance(self.install_dir, str)):
+                    raise InvalidArguments('"install_dir" must be a string.')
        else:
            self.install = False
        self.build_always = kwargs.get('build_always', False)