Merge pull request #8403 from dcbaker/submit/rust-fix-shared-internal-linking

Submit/rust fix shared internal linking

mesonbuild/backend/ninjabackend.py

@@ -1608,12 +1608,19 @@ int dummy;
                 # dependency, so that collisions with libraries in rustc's
                 # sysroot don't cause ambiguity
                 args += ['--extern', '{}={}'.format(d.name, os.path.join(d.subdir, d.filename))]
+            elif d.typename == 'static library':
+                # Rustc doesn't follow Meson's convention that static libraries
+                # are called .a, and implementation libraries are .lib, so we
+                # have to manually handle that.
+                if rustc.linker.id == 'link':
+                    args += ['-C', f'link-arg={self.get_target_filename_for_linking(d)}']
+                else:
+                    args += ['-l', f'static={d.name}']
+                external_deps.extend(d.external_deps)
             else:
-                # Rust uses -l for non rust dependencies, but we still need to add (shared|static)=foo
+                # Rust uses -l for non rust dependencies, but we still need to
-                _type = 'static' if d.typename == 'static library' else 'shared'
+                # add dylib=foo
-                args += ['-l', f'{_type}={d.name}']
+                args += ['-l', f'dylib={d.name}']
-                if d.typename == 'static library':
-                    external_deps.extend(d.external_deps)
         for e in external_deps:
             for a in e.get_link_args():
                 if a.endswith(('.dll', '.so', '.dylib')):

test cases/rust/16 internal c dependencies/lib.c

@@ -0,0 +1,6 @@
+#include <stdio.h>
+#include "lib.h"
+
+void c_func(void) {
+    printf("This is a " MODE " C library\n");
+}

test cases/rust/16 internal c dependencies/lib.h

@@ -0,0 +1,22 @@
+#pragma once
+
+#if defined _WIN32 || defined __CYGWIN__
+  #if defined BUILDING_ADDER
+    #define DLL_PUBLIC __declspec(dllexport)
+  #else
+    #define DLL_PUBLIC __declspec(dllimport)
+  #endif
+#else
+  #if defined __GNUC__
+    #if defined BUILDING_ADDER
+      #define DLL_PUBLIC __attribute__ ((visibility("default")))
+    #else
+      #define DLL_PUBLIC
+    #endif
+  #else
+    #pragma message("Compiler does not support symbol visibility.")
+    #define DLL_PUBLIC
+  #endif
+#endif
+
+DLL_PUBLIC void c_func(void);

test cases/rust/16 internal c dependencies/main.rs

@@ -0,0 +1,9 @@
+extern "C" {
+    fn c_func();
+}
+
+fn main() {
+    unsafe {
+        c_func();
+    }
+}

test cases/rust/16 internal c dependencies/meson.build

@@ -0,0 +1,14 @@
+project('internal dependencies', 'c', 'rust')
+
+test_prog = find_program('test.py')
+
+static = static_library('static', 'lib.c', c_args : '-DMODE="static"')
+exe = executable('static', 'main.rs', link_with : static)
+test('static linkage', test_prog, args : [exe, 'This is a static C library'])
+
+# Shared linkage with rust doesn't work on macOS with meson, yet
+if host_machine.system() != 'darwin'
+  shared = shared_library('shared', 'lib.c', c_args : '-DMODE="shared"')
+  exe = executable('shared', 'main.rs', link_with : shared)
+  test('shared linkage', test_prog, args : [exe, 'This is a shared C library'])
+endif

test cases/rust/16 internal c dependencies/test.py

@@ -0,0 +1,25 @@
+#!/usr/bin/env python3
+
+import argparse
+import subprocess
+import sys
+
+
+def main() -> None:
+    parser = argparse.ArgumentParser()
+    parser.add_argument('command')
+    parser.add_argument('expected')
+    args = parser.parse_args()
+
+    out = subprocess.run(args.command, stdout=subprocess.PIPE)
+    actual = out.stdout.decode().strip()
+
+    if args.expected != actual:
+        print('expected:', args.expected, file=sys.stderr)
+        print('actual:  ', actual, file=sys.stderr)
+        sys.exit(1)
+    sys.exit(0)
+
+
+if __name__ == "__main__":
+    main()