Warn about using non-existent pkgconfig variables

I'm not sure this is a good idea, but at the moment it seems a bit too easy
to write something like dep.get_pkgconfig_variable('inculdedir:') (sic) and
not notice it's not doing anything useful.
pull/2947/head
Jon Turney 7 years ago committed by Jussi Pakkanen
parent b37706737c
commit 22a1596a97
  1. 9
      mesonbuild/dependencies/base.py

@ -16,6 +16,7 @@
# Custom logic for several other packages are in separate files.
import os
import re
import sys
import stat
import shlex
@ -532,6 +533,14 @@ class PkgConfigDependency(ExternalDependency):
(self.type_string, self.name))
else:
variable = out.strip()
# pkg-config doesn't distinguish between empty and non-existent variables
# use the variable list to check for variable existence
if not variable:
ret, out = self._call_pkgbin(['--print-variables', self.name])
if not re.search(r'^' + variable_name + r'$', out, re.MULTILINE):
mlog.warning("pkgconfig variable '%s' not defined for dependency %s." % (variable_name, self.name))
mlog.debug('Got pkgconfig variable %s : %s' % (variable_name, variable))
return variable

Loading…
Cancel
Save