From 12df9c46f58747c79e8745a29befe570d47ef78a Mon Sep 17 00:00:00 2001 From: Jussi Pakkanen Date: Wed, 11 Oct 2017 01:39:26 +0300 Subject: [PATCH] Check that link_with arguments in declare_dependency are not external dependencies. --- mesonbuild/interpreter.py | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/mesonbuild/interpreter.py b/mesonbuild/interpreter.py index d9ab73356..727c68851 100644 --- a/mesonbuild/interpreter.py +++ b/mesonbuild/interpreter.py @@ -1579,6 +1579,10 @@ class Interpreter(InterpreterBase): if not isinstance(d, (dependencies.Dependency, dependencies.ExternalLibrary, dependencies.InternalDependency)): raise InterpreterException('Dependencies must be external deps') final_deps.append(d) + for l in libs: + if isinstance(l, dependencies.Dependency): + raise InterpreterException('''Entries in "link_with" may only be self-built targets, +external dependencies (including libraries) must go to "dependencies".''') dep = dependencies.InternalDependency(version, incs, compile_args, link_args, libs, sources, final_deps) return DependencyHolder(dep)