From 0c95d92404cfc5cebb32c886484946a8a42f6e79 Mon Sep 17 00:00:00 2001 From: Xavier Claessens Date: Mon, 12 Oct 2020 16:02:54 -0400 Subject: [PATCH] pkgconfig: InternalDependency's ext_deps should be private by default This fixes a regression introduced by https://github.com/mesonbuild/meson/pull/7488. InternalDependency's ext_deps previously where simply ignored, but that PR has effect to add many more public Requires in generated pc files. --- mesonbuild/modules/pkgconfig.py | 2 +- run_unittests.py | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/mesonbuild/modules/pkgconfig.py b/mesonbuild/modules/pkgconfig.py index 38c96a9ca..968e1eede 100644 --- a/mesonbuild/modules/pkgconfig.py +++ b/mesonbuild/modules/pkgconfig.py @@ -173,7 +173,7 @@ class DependenciesHelper: for t in link_whole_targets: self._add_link_whole(t, public) # And finally its external dependencies - add_libs(external_deps) + self.add_priv_libs(external_deps) def _add_link_whole(self, t, public): # Don't include static libraries that we link_whole. But we still need to diff --git a/run_unittests.py b/run_unittests.py index 8f1c52a68..03cd82b83 100755 --- a/run_unittests.py +++ b/run_unittests.py @@ -6105,7 +6105,8 @@ class LinuxlikeTests(BasePlatformTests): # See common/47 pkgconfig-gen/meson.build for description of the case this test with open(os.path.join(privatedir1, 'simple2.pc')) as f: content = f.read() - self.assertIn('Libs: -L${libdir} -lsimple2 -lz -lsimple1', content) + self.assertIn('Libs: -L${libdir} -lsimple2 -lsimple1', content) + self.assertIn('Libs.private: -lz', content) with open(os.path.join(privatedir1, 'simple3.pc')) as f: content = f.read()