|
|
|
# Copyright 2014-2016 The Meson development team
|
|
|
|
|
|
|
|
# Licensed under the Apache License, Version 2.0 (the "License");
|
|
|
|
# you may not use this file except in compliance with the License.
|
|
|
|
# You may obtain a copy of the License at
|
|
|
|
|
|
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
|
|
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
|
|
# distributed under the License is distributed on an "AS IS" BASIS,
|
|
|
|
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
|
|
# See the License for the specific language governing permissions and
|
|
|
|
# limitations under the License.
|
|
|
|
|
|
|
|
import os
|
|
|
|
from . import (coredata, mesonlib, build)
|
|
|
|
from . import mintro
|
|
|
|
|
|
|
|
def add_arguments(parser):
|
|
|
|
coredata.register_builtin_arguments(parser)
|
|
|
|
parser.add_argument('builddir', nargs='?', default='.')
|
|
|
|
parser.add_argument('--clearcache', action='store_true', default=False,
|
|
|
|
help='Clear cached state (e.g. found dependencies)')
|
|
|
|
|
|
|
|
|
|
|
|
class ConfException(mesonlib.MesonException):
|
|
|
|
pass
|
|
|
|
|
|
|
|
|
|
|
|
class Conf:
|
|
|
|
def __init__(self, build_dir):
|
|
|
|
self.build_dir = build_dir
|
|
|
|
if not os.path.isdir(os.path.join(build_dir, 'meson-private')):
|
|
|
|
raise ConfException('Directory %s does not seem to be a Meson build directory.' % build_dir)
|
|
|
|
self.build = build.load(self.build_dir)
|
|
|
|
self.coredata = coredata.load(self.build_dir)
|
|
|
|
|
|
|
|
def clear_cache(self):
|
|
|
|
self.coredata.deps = {}
|
|
|
|
|
|
|
|
def set_options(self, options):
|
|
|
|
self.coredata.set_options(options)
|
|
|
|
|
|
|
|
def save(self):
|
|
|
|
# Only called if something has changed so overwrite unconditionally.
|
|
|
|
coredata.save(self.coredata, self.build_dir)
|
|
|
|
# We don't write the build file because any changes to it
|
|
|
|
# are erased when Meson is executed the next time, i.e. when
|
|
|
|
# Ninja is run.
|
|
|
|
|
|
|
|
@staticmethod
|
|
|
|
def print_aligned(arr):
|
|
|
|
def make_lower_case(val):
|
|
|
|
if isinstance(val, bool):
|
|
|
|
return str(val).lower()
|
|
|
|
elif isinstance(val, list):
|
|
|
|
return [make_lower_case(i) for i in val]
|
|
|
|
else:
|
|
|
|
return str(val)
|
|
|
|
|
Don't use len() to test emptiness vs not emptiness
Meson has a common pattern of using 'if len(foo) == 0:' or
'if len(foo) != 0:', however, this is a common anti-pattern in python.
Instead tests for emptiness/non-emptiness should be done with a simple
'if foo:' or 'if not foo:'
Consider the following:
>>> import timeit
>>> timeit.timeit('if len([]) == 0: pass')
0.10730923599840025
>>> timeit.timeit('if not []: pass')
0.030033907998586074
>>> timeit.timeit('if len(['a', 'b', 'c', 'd']) == 0: pass')
0.1154778649979562
>>> timeit.timeit("if not ['a', 'b', 'c', 'd']: pass")
0.08259823200205574
>>> timeit.timeit('if len("") == 0: pass')
0.089759664999292
>>> timeit.timeit('if not "": pass')
0.02340641999762738
>>> timeit.timeit('if len("foo") == 0: pass')
0.08848102600313723
>>> timeit.timeit('if not "foo": pass')
0.04032287199879647
And for the one additional case of 'if len(foo.strip()) == 0', which can
be replaced with 'if not foo.isspace()'
>>> timeit.timeit('if len(" ".strip()) == 0: pass')
0.15294511600222904
>>> timeit.timeit('if " ".isspace(): pass')
0.09413968399894657
>>> timeit.timeit('if len(" abc".strip()) == 0: pass')
0.2023209120015963
>>> timeit.timeit('if " abc".isspace(): pass')
0.09571301700270851
In other words, it's always a win to not use len(), when you don't
actually want to check the length.
8 years ago
|
|
|
if not arr:
|
|
|
|
return
|
|
|
|
|
mesonconf: reorder output columns
mesonconf prints build dir information in the order of
'Option' 'Description' 'Current Value' and, optionally, 'Possible Value'.
The Description tends to be longer and push the following values far
right, sometimes way far than fits in the full screen size of a
terminal on a FullHD monitor.
Experienced users know which options they want to change without
looking at the description string however they need to check the
current values for sure.
This patch moves the description to the last column. Now mesonconf
prints options in the following order:
'Option' 'Current Value' 'Possible Value' 'Description'
To implement this, mainly print_aligned() is modified. The second
argument of the function is changed from
- array of array of string to
- array of dict with 'name', 'descr', 'value', and 'choices,
which maps to 'option', 'description', 'current value' and 'possible
values', respectively.
Since the position of the possible values are moved before its
description, the presence and the length of it affects header as well
as the following description. Thus, we cal curate it before printing
the header.
To avoid re-calculation, we keep string version of the values and
flattened version of the possible values _in the given array_, which
means that now the print_aligned() function modify the the given
array. The current callers do not use the passing array. So there
should be no bad effects.
8 years ago
|
|
|
titles = {'name': 'Option', 'descr': 'Description', 'value': 'Current Value', 'choices': 'Possible Values'}
|
|
|
|
|
|
|
|
name_col = [titles['name'], '-' * len(titles['name'])]
|
|
|
|
value_col = [titles['value'], '-' * len(titles['value'])]
|
|
|
|
choices_col = [titles['choices'], '-' * len(titles['choices'])]
|
|
|
|
descr_col = [titles['descr'], '-' * len(titles['descr'])]
|
|
|
|
|
|
|
|
choices_found = False
|
|
|
|
for opt in arr:
|
|
|
|
name_col.append(opt['name'])
|
|
|
|
descr_col.append(opt['descr'])
|
|
|
|
if isinstance(opt['value'], list):
|
|
|
|
value_col.append('[{0}]'.format(', '.join(make_lower_case(opt['value']))))
|
mesonconf: reorder output columns
mesonconf prints build dir information in the order of
'Option' 'Description' 'Current Value' and, optionally, 'Possible Value'.
The Description tends to be longer and push the following values far
right, sometimes way far than fits in the full screen size of a
terminal on a FullHD monitor.
Experienced users know which options they want to change without
looking at the description string however they need to check the
current values for sure.
This patch moves the description to the last column. Now mesonconf
prints options in the following order:
'Option' 'Current Value' 'Possible Value' 'Description'
To implement this, mainly print_aligned() is modified. The second
argument of the function is changed from
- array of array of string to
- array of dict with 'name', 'descr', 'value', and 'choices,
which maps to 'option', 'description', 'current value' and 'possible
values', respectively.
Since the position of the possible values are moved before its
description, the presence and the length of it affects header as well
as the following description. Thus, we cal curate it before printing
the header.
To avoid re-calculation, we keep string version of the values and
flattened version of the possible values _in the given array_, which
means that now the print_aligned() function modify the the given
array. The current callers do not use the passing array. So there
should be no bad effects.
8 years ago
|
|
|
else:
|
|
|
|
value_col.append(make_lower_case(opt['value']))
|
|
|
|
if opt['choices']:
|
|
|
|
choices_found = True
|
|
|
|
if isinstance(opt['choices'], list):
|
|
|
|
choices_col.append('[{0}]'.format(', '.join(make_lower_case(opt['choices']))))
|
|
|
|
else:
|
|
|
|
choices_col.append(make_lower_case(opt['choices']))
|
|
|
|
else:
|
|
|
|
choices_col.append('')
|
|
|
|
|
|
|
|
col_widths = (max([len(i) for i in name_col], default=0),
|
|
|
|
max([len(i) for i in value_col], default=0),
|
|
|
|
max([len(i) for i in choices_col], default=0),
|
|
|
|
max([len(i) for i in descr_col], default=0))
|
mesonconf: reorder output columns
mesonconf prints build dir information in the order of
'Option' 'Description' 'Current Value' and, optionally, 'Possible Value'.
The Description tends to be longer and push the following values far
right, sometimes way far than fits in the full screen size of a
terminal on a FullHD monitor.
Experienced users know which options they want to change without
looking at the description string however they need to check the
current values for sure.
This patch moves the description to the last column. Now mesonconf
prints options in the following order:
'Option' 'Current Value' 'Possible Value' 'Description'
To implement this, mainly print_aligned() is modified. The second
argument of the function is changed from
- array of array of string to
- array of dict with 'name', 'descr', 'value', and 'choices,
which maps to 'option', 'description', 'current value' and 'possible
values', respectively.
Since the position of the possible values are moved before its
description, the presence and the length of it affects header as well
as the following description. Thus, we cal curate it before printing
the header.
To avoid re-calculation, we keep string version of the values and
flattened version of the possible values _in the given array_, which
means that now the print_aligned() function modify the the given
array. The current callers do not use the passing array. So there
should be no bad effects.
8 years ago
|
|
|
|
|
|
|
for line in zip(name_col, value_col, choices_col, descr_col):
|
|
|
|
if choices_found:
|
|
|
|
print(' {0:{width[0]}} {1:{width[1]}} {2:{width[2]}} {3:{width[3]}}'.format(*line, width=col_widths))
|
|
|
|
else:
|
|
|
|
print(' {0:{width[0]}} {1:{width[1]}} {3:{width[3]}}'.format(*line, width=col_widths))
|
|
|
|
|
|
|
|
def print_options(self, title, options):
|
|
|
|
print('\n{}:'.format(title))
|
|
|
|
if not options:
|
|
|
|
print(' No {}\n'.format(title.lower()))
|
|
|
|
arr = []
|
|
|
|
for k in sorted(options):
|
|
|
|
o = options[k]
|
|
|
|
d = o.description
|
|
|
|
v = o.value
|
|
|
|
c = o.choices
|
|
|
|
if isinstance(o, coredata.UserUmaskOption):
|
|
|
|
v = format(v, '04o')
|
|
|
|
arr.append({'name': k, 'descr': d, 'value': v, 'choices': c})
|
|
|
|
self.print_aligned(arr)
|
|
|
|
|
|
|
|
def print_conf(self):
|
|
|
|
print('Core properties:')
|
|
|
|
print(' Source dir', self.build.environment.source_dir)
|
|
|
|
print(' Build dir ', self.build.environment.build_dir)
|
|
|
|
|
|
|
|
dir_option_names = ['bindir',
|
|
|
|
'datadir',
|
|
|
|
'includedir',
|
|
|
|
'infodir',
|
|
|
|
'libdir',
|
|
|
|
'libexecdir',
|
|
|
|
'localedir',
|
|
|
|
'localstatedir',
|
|
|
|
'mandir',
|
|
|
|
'prefix',
|
|
|
|
'sbindir',
|
|
|
|
'sharedstatedir',
|
|
|
|
'sysconfdir']
|
|
|
|
test_option_names = ['errorlogs',
|
|
|
|
'stdsplit']
|
|
|
|
core_option_names = [k for k in self.coredata.builtins if k not in dir_option_names + test_option_names]
|
|
|
|
|
|
|
|
dir_options = {k: o for k, o in self.coredata.builtins.items() if k in dir_option_names}
|
|
|
|
test_options = {k: o for k, o in self.coredata.builtins.items() if k in test_option_names}
|
|
|
|
core_options = {k: o for k, o in self.coredata.builtins.items() if k in core_option_names}
|
|
|
|
|
|
|
|
self.print_options('Core options', core_options)
|
|
|
|
self.print_options('Backend options', self.coredata.backend_options)
|
|
|
|
self.print_options('Base options', self.coredata.base_options)
|
|
|
|
self.print_options('Compiler options', self.coredata.compiler_options)
|
|
|
|
self.print_options('Directories', dir_options)
|
|
|
|
self.print_options('Project options', self.coredata.user_options)
|
|
|
|
self.print_options('Testing options', test_options)
|
|
|
|
|
|
|
|
|
|
|
|
def run(options):
|
|
|
|
coredata.parse_cmd_line_options(options)
|
|
|
|
builddir = os.path.abspath(os.path.realpath(options.builddir))
|
|
|
|
try:
|
|
|
|
c = Conf(builddir)
|
|
|
|
save = False
|
|
|
|
if len(options.cmd_line_options) > 0:
|
|
|
|
c.set_options(options.cmd_line_options)
|
|
|
|
coredata.update_cmd_line_file(builddir, options)
|
|
|
|
save = True
|
|
|
|
elif options.clearcache:
|
|
|
|
c.clear_cache()
|
|
|
|
save = True
|
|
|
|
else:
|
|
|
|
c.print_conf()
|
|
|
|
if save:
|
|
|
|
c.save()
|
|
|
|
mintro.update_build_options(c.coredata, c.build.environment.info_dir)
|
|
|
|
except ConfException as e:
|
|
|
|
print('Meson configurator encountered an error:')
|
|
|
|
raise e
|
|
|
|
return 0
|