Behdad Esfahbod
a96508cfc9
[msan] Add MSAN_OPTIONS=exitcode=42
...
Default exit value is 77, which causes autotools to "skip" test.
6 years ago
Behdad Esfahbod
45f5aa9790
[circleci] Disable msan and ubsan builds
...
https://github.com/harfbuzz/harfbuzz/issues/1174
https://github.com/harfbuzz/harfbuzz/issues/1175
6 years ago
Behdad Esfahbod
2d93148a0f
Ignore weak symbols in check-symbols.sh
...
Some clang versions leave a std::round(float) weak symbol around...
6 years ago
Behdad Esfahbod
55bae6825e
[docs] A few improvements
...
If we wrote just this much every day...
6 years ago
Behdad Esfahbod
57fa2c23de
Readjust Hebrew composition again
6 years ago
Behdad Esfahbod
7f335390f3
Revert change that would decompose text if GPOS mark feature is available
...
https://github.com/harfbuzz/harfbuzz/issues/653#issuecomment-423905920
6 years ago
Behdad Esfahbod
a6f4b2f7cd
Fix normalization
...
62d1e0852a (commitcomment-30613091)
6 years ago
Behdad Esfahbod
3583fb03b1
Simplify ZWJ-skipping a bit
...
Towards disabling ZWJ-skipping in certain GPOS contexts.
Part of https://github.com/flutter/flutter/issues/16886
6 years ago
Behdad Esfahbod
9516cbd3df
Reinit skippy iters when auto_zwj / auto_zwnj change
...
Ouch. How did we not hit this bug before...
6 years ago
Behdad Esfahbod
62d1e0852a
Prefer decomposed form if font has GPOS mark feature
...
Fixes https://github.com/harfbuzz/harfbuzz/issues/653
6 years ago
Behdad Esfahbod
d7f21777e6
[ot-font] Fix leak
...
Fixes https://github.com/harfbuzz/harfbuzz/issues/1171
I'm glad we have leak-detector bots now.
6 years ago
Ebrahim Byagowi
ae39a53f55
Add bots with address- and thread-sanitizer
6 years ago
Matt Oliver
24dd6c1a9d
src/hb-blob.cc: Fix mmap functionality with UWP.
6 years ago
Khaled Hosny
b7f1bbc2f8
[test] Fix printing subprocess error messages
...
Decode the string as Python 3 returns bytes string, and also don’t
assume that it ends with a new line.
6 years ago
Ebrahim Byagowi
403019482b
Fix test-subset-* leak issues
...
See also https://github.com/harfbuzz/harfbuzz/pull/1169
6 years ago
Ebrahim Byagowi
f6ebe1f4dc
Fix test-ot-math leak issue
...
See also https://github.com/harfbuzz/harfbuzz/pull/1169
6 years ago
Ebrahim Byagowi
669ac81ac5
Fix test-set leak issue
...
See also https://github.com/harfbuzz/harfbuzz/pull/1169
6 years ago
Ebrahim Byagowi
ef9307fd22
Fix test-font leak issue
...
See also https://github.com/harfbuzz/harfbuzz/pull/1169
6 years ago
Behdad Esfahbod
5fd8bce945
[morx] Fix mark_set check
6 years ago
Behdad Esfahbod
0739b28169
[aat] Minor
6 years ago
Behdad Esfahbod
7671cb9b04
[coretext] Minor
6 years ago
Behdad Esfahbod
dc8ed45292
[morx] Implement forward/backward processing
...
We reverse too many times. Can be optimized. But I doubt many fonts
use reverse lookups, so doesn't matter.
Other than not applying user features, this completes morx table
implementation.
6 years ago
Behdad Esfahbod
3bccd62196
[morx] Implement horiz-only/vert-only subtables
6 years ago
Behdad Esfahbod
041a08de3d
[morx] Improve buffer position in Insertion w DontAdvance and wo
...
Just speculation. Needs tests to determine which is correct behavior.
6 years ago
Behdad Esfahbod
388ab91642
[morx] Implement InsertionChain
6 years ago
David Corbett
d8d1e7df00
Don't enforce a native direction for Old Hungarian
6 years ago
Simon Hausmann
6a97d0f3d3
Fix installation of cmake config when building with cmake ( #1161 )
...
When building with the auto tools, the manually mantained
harfbuzz-config.cmake is installed. When building with cmake, we can use
cmake to generate the correct config files for us and install them.
6 years ago
Behdad Esfahbod
606bf57430
Revert forcing use of single-parameter static_assert()
...
Some clang versions define static_assert as a macro apparently, so we cannot
redefine it...
This reverts commit 94bfea0ce6
.
This reverts commit 4e62627831
.
6 years ago
Behdad Esfahbod
cbcaba6ffd
One more bot fix
6 years ago
Behdad Esfahbod
94bfea0ce6
Fix build, another try
6 years ago
Behdad Esfahbod
89dd4b9597
Fix bots
...
"Unused private member" warning turned error. ugh.
6 years ago
Behdad Esfahbod
4e62627831
Enforce single-param static_assert() only
...
So we don't accidentally break it again.
6 years ago
Behdad Esfahbod
f1a86e1e6f
Remove unused try
6 years ago
Behdad Esfahbod
ebd50b3c83
Fix static_assert
6 years ago
Behdad Esfahbod
10642b3fbf
Disallow null-enabled offsets to unsized structures...
...
...like UnsizedArrayOf<>.
This fixes a class of crasher bugs, mostly with color and AAT tables. We
cannot use nullable offsets to varsized data that does not declare min_size,
because it's nost safe to use our fixed-size null pool for types that have
their size external. So, use non_null'able offsets for these.
A further enhancement would be to make use of min_size in Null<> itself.
Will try that after.
6 years ago
Behdad Esfahbod
9ff76c6025
[morx] Respect default feature settings
...
Does NOT apply user-selected features. But at least now enables
correct subtables.
6 years ago
Behdad Esfahbod
2f97da6e2d
[aat] Change version field
6 years ago
Behdad Esfahbod
29c2bd1795
[morx] Add stub for InsertionChain
6 years ago
Behdad Esfahbod
f8ccb545c4
[dfont] Disable null-processsing for offsets
...
An offset to unsized arrayis not safe to be redirected to our fixed-sized
null pool. Plus, we want to reject, not repair, bad-looking dfonts.
6 years ago
Behdad Esfahbod
01b9148d9a
[unicode] Move Fitzpatrick hack from ot-layout into unicode.hh
6 years ago
Behdad Esfahbod
6ebbf514ac
Minor
6 years ago
Behdad Esfahbod
957dbed388
Fix builds
6 years ago
Behdad Esfahbod
4653e6cf3c
[aat] Add enums for pre-defined state and classes
...
Not sure how I didn't add before...
6 years ago
Behdad Esfahbod
67449c3933
Don't dereference offset before check_struct()
6 years ago
Behdad Esfahbod
ca746f261e
[dfont] Also check dataLen range in sanitize
...
Just to disagree with myself re being done with this code...
6 years ago
Behdad Esfahbod
3789c557ca
[dfont] Solve the mystery +2 offset thing!
...
Previously, ResourceForkHeader was defined as 30 bytes, having the typeCountM1 as last member.
There was a mysterious offset-by-2 in the code, derived from FontTools and JDK code this was
ported from.
In testing, I observed that typeListZ offset is actually 28. Suggesting that the typeCountM1
does NOT actually belong to ResourceForkHeader, but belongs to the array itself. Adjusting for
that resolves the mystery +2 offset hack, so everything is clean and good now.
This, concludes my dfont hacking. The code looks great now, and I'm happy to leave it.
Fuzzers might disagree though, we will see!
6 years ago
Behdad Esfahbod
effc7ced72
Rename HeadlessArrayOf::len to lenP1
...
So it doesn't accidentally match our templates, etc.
6 years ago
Behdad Esfahbod
180a88a96c
[dfont] Some more
6 years ago
Behdad Esfahbod
0ab0f1e5ac
[dfont] Push methods further down
6 years ago
Behdad Esfahbod
8c9bdcc1fe
[dfont] Minor
6 years ago