84dbfacfec
[subset] fix collect_variation_idx in PairPosFormat2
4 years ago
d356d0f79c
[subset] optimize ValueRecord's for PairPosFormat1.
4 years ago
f9fbe4817e
[subset] implement value record optimization for PairPosFormat2.
4 years ago
badb8e409b
[subset] use copy_values for PairPos serialize.
4 years ago
2f50283cd3
[subset] Begin implementing ValueRecord optimization:
...
remove value records which have a zero value.
4 years ago
5df7c668ba
[subset] In SinglePosFormat1 serialize only 1 value record.
...
Previously one record per glyph in the subset was serialized.
4 years ago
92757f6809
[subset] Don't drop anchor device tables when dropping hints. These may contain variation data.
...
Update subseting expected files to match latest version of fontTools.
4 years ago
6fddc2bbf9
[subset] subset layout tables (G*) by default.
4 years ago
425ba1f4ab
[subset] fixes infinite loop in hb_set_get_max().
...
Fixes https://oss-fuzz.com/testcase-detail/5363902507515904
4 years ago
ec4321068b
[subset] fix infinite loop caused by alloc failure in repacker.
...
Fixes: https://oss-fuzz.com/testcase-detail/5609112151916544 .
4 years ago
0e845d973e
[subset] fix memory leak in repacker caused by failed alloc.
...
Fixes: https://oss-fuzz.com/testcase-detail/5616763250278400 .
4 years ago
3fb62cdc14
[subset] fail on offset overflow in tables that we don't repack.
...
Fixes: https://oss-fuzz.com/testcase-detail/5229304507138048
4 years ago
19e096aa97
Merge pull request #2067 from harfbuzz/null-size
...
Avoid undefined-behavior, another try
4 years ago
ed2ee8a8c2
Revert "Disable -Wunused-macros under GCC"
...
This reverts commit 1b1413246b
4 years ago
47cbf8f2c4
[test] Silence more compiler warnings
4 years ago
1b1413246b
Disable -Wunused-macros under GCC
...
Since the pragram in hb-ot-shape-complex-indic-table.cc didn't seem to
silence GCC, eg:
../../src/hb-ot-shape-complex-indic-table.cc:55: warning: macro "ISC_TL" is not used [-Wunused-macros]
55 | #define ISC_TL INDIC_SYLLABIC_CATEGORY_TONE_LETTER /* 7 chars; Tone_Letter */
disable it at compiler level.
4 years ago
23a28f5ad0
Avoid undefined-behavior
...
If a struct had (because it's a union) sizeof that is larger than the null_size,
we were providing only null_size bytes for its Null object. We know we'd never
access beyond that, but is undefined-behavior nonetheless according to the
standard.
The alternative fix would have required use of flexible-arrays, which are not
standard and have their own issues in various compiler. We've discussed that
extensively in the follow Mozilla issue (currently locked; I've asked that it
be opened):
https://bugzilla.mozilla.org/show_bug.cgi?id=1577584
Part of
https://github.com/harfbuzz/harfbuzz/pull/2067
4 years ago
499248c533
[blob] Use min_size, instead of null_size in .as<T>()
...
Part of https://github.com/harfbuzz/harfbuzz/pull/2067
4 years ago
a4fb5da984
[ci] Enable DirectWrite in win32 tarballs
4 years ago
f2240d12c2
[ci] Use -j2 for make and ninja in distcheck job
...
Lets see if this makes it faster without crashing gcc.
4 years ago
f5c922b709
[ci] Try to stop distcheck job from crashing gcc
4 years ago
e116058bba
[directwrite] Use correct UTF-16 string length
...
Fixes https://github.com/harfbuzz/harfbuzz/issues/2474
4 years ago
668acff1f0
similarly improve comments on Hebrew ccc 18 & 19
...
Should have committed this along with commit 9658435a25
4 years ago
43d955207b
improve comments on Hebrew ccc 18 & 19
...
improve comments to reflect that:
ccc 18 includes both "flavors" of qamats: qamats [gadol] and qamats qatan
ccc 19 includes both "flavors" of holam: holam [not haser for vav] and holam haser for vav
This code and its comments may have been written before these code points were added to Unicode.
I.e. originally, these comments may have been complete, but they may have become incomplete in the meantime.
4 years ago
4cc4cd3b24
[docs] Fix spelling typo ( #2945 )
4 years ago
9dc9f0385d
[subset] fix for fuzzer testcase: https://oss-fuzz.com/testcase-detail/5858518134554624
4 years ago
430a67ceab
[subset] COLRv1 struct definitions
4 years ago
553ffaf682
[subset] fix for fuzzer testcase: https://oss-fuzz.com/testcase-detail/6382598554255360
...
avoid writing to null pointer
4 years ago
4af5dacedc
[subset] add fuzzer testcase
4 years ago
8b686afeb5
[subset] add unlikely().
4 years ago
64122b5a44
[subset] don't visit lookup if covered glyph set has failed.
...
If covered glyph set is in error then the same lookup can be recursed into repeatedly potentially causing a fuzzer timeout. Fixes: https://oss-fuzz.com/testcase-detail/5416421032067072 .
4 years ago
4ec18c85e6
[subset] add subsetting tests with drop hints and layout subsetting enabled.
4 years ago
6f98a8ed46
[subset] Anchor should only use format 1 when hints are dropped.
...
Refactor Anchor to have a subset method instead of copy. This also allows
use to use serialize_subset in several places which simplifies calculating
offset bases.
4 years ago
71d6d15600
[subset] clamp distance to prevent shifting outside of the limits of int64.
...
Fixes https://oss-fuzz.com/testcase-detail/4961171477233664 .
4 years ago
fcacd17748
[ot] Update _hb_glyph_info_is_default_ignorable_and_not_hidden()
...
Used _hb_glyph_info_substituted() similar to the change made to
_hb_glyph_info_is_default_ignorable() in
7686ff854b
4 years ago
596f4258d0
[subset] copy Lookup::markFilteringSet when subseting.
4 years ago
d3a2f999e4
Fix up build
...
This was left out; oops.
4 years ago
c35d786397
[subset] never drop the 'pref' feature.
...
Never ever drop feature 'pref', even if it's empty. Harfbuzz uses it to choose the shaper for Khmer.
4 years ago
092094f705
Use as_array() and range loops in a few places
4 years ago
55e7f3fe32
[subset] Match FeatureVariationRecord dropping from fontTools.
...
Only drop records with no matching features that are at the end of the list. See: cab7d13dc0
4 years ago
f0c78e0282
[subset] don't drop features referenced in a feature variation substitution.
4 years ago
dae99b7769
[subset] don't keep FeatureVariationRecord's with no subsittutions.
4 years ago
85b0728783
Add full variable font subsetting test.
4 years ago
c4b49075f6
Update CMakeLists.txt
...
Keep the warning.
4 years ago
9945f32746
Test fix to export target include directories
4 years ago
b10741ca7f
[subset] when closing glyphs in context lookups don't use a current glyph set if a lookup is already applied.
4 years ago
2773d05740
[subset] Add a test case using NotoNastaliqUrdu.
4 years ago
8ef4257dc8
[sanitize] change max ops to track number of bytes processed.
...
Counting bytes as the operations is likely to be a better proxy for how
much work processing the table will cost vs. the current approach of
counting the number of sub-objects.
This should allow checks for max features, max scripts, etc. to be removed.
I tested this change against the full collection of fonts at https://github.com/google/fonts
and a max ops factor of 3 was sufficient to successfully sanitize all of them.
4 years ago
70110f6aaa
Modify OffsetTo<>::sanitize() overflow check
...
The code in question was introduced in 70eb2ff682https://github.com/harfbuzz/harfbuzz/pull/2923
4 years ago
4dba749d83
Add SortedArray{16,32}Of<>
4 years ago
Qunxin Liu
Garret Rieger
Behdad Esfahbod
Khaled Hosny
Ben Denckla
Ambient Lighter
Timo Suoranta